mmc: omap_hsmmc: use for OMAP5 as well
PATCH 1/1 mmc: omap_hsmmc: use for OMAP5 as well
From: Amarinder Bindra <[email protected]>
OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.
--- drivers/mmc/host/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/mmc/host/Kconfig +3 -3
@@ -254,11 +254,11 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 + depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5 help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a - Multimedia Card slot, say Y or M here. + If you have an OMAP2430 or OMAP3 board or OMAP4 board or OMAP5 + board with a Multimedia Card slot, say Y or M here. If unsure, say N.
Signature · 1 line
1.7.9.5
Quoted 11 lines · On Friday 28 June 2013 06:04 PM, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.Signed-off-by Amarinder Bindra <[email protected]>Acked-by Felipe Balbi <[email protected]>Acked-by Nishanth Menon <[email protected]>
Looks good to me,
Quoted 24 lines
--- drivers/mmc/host/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/mmc/host/Kconfig +3
-3@@ -254,11 +254,11 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 + depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5 help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a - Multimedia Card slot, say Y or M here. + If you have an OMAP2430 or OMAP3 board or OMAP4 board or OMAP5 + board with a Multimedia Card slot, say Y or M here. If unsure, say N.
Hi guys,
Quoted 9 lines · Balaji T K
Quoted 8 lines · On Friday 28 June 2013 06:04 PM, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Amarinder Bindra <[email protected]>Acked-by Felipe Balbi <[email protected]>Acked-by Nishanth Menon <[email protected]>Looks good to me,
Acked-by Balaji T K <[email protected]>
I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4.
Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this:
---
drivers/mmc/host/Kconfig +1 -2
@@ -273,10 +273,9 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a + If you have an OMAP2430, OMAP3, OMAP4 or AM3xx board with a Multimedia Card slot, say Y or M here. If unsure, say N.
Signature · 3 lines
Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com
Quoted 20 lines · Ezequiel Garcia
Hi guys,
Quoted 9 lines · Balaji T K
Quoted 8 lines · On Friday 28 June 2013 06:04 PM, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.Quoted 7 lines
Quoted 3 lines
Signed-off-by Amarinder Bindra <[email protected]>Acked-by Felipe Balbi <[email protected]>Acked-by Nishanth Menon <[email protected]>Looks good to me,
Acked-by Balaji T K <[email protected]>
Quoted 6 lines
I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4.
Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this:
frankly speaking, this driver should be deleted and all users should be moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except for a couple quirks which can be easily worked around.
Signature · 1 line
balbi
Quoted 24 lines · Felipe Balbi
Quoted 23 lines · Ezequiel Garcia
Hi guys,
Quoted 9 lines · Balaji T K
Quoted 8 lines · On Friday 28 June 2013 06:04 PM, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.Quoted 7 lines
Quoted 3 lines
Signed-off-by Amarinder Bindra <[email protected]>Acked-by Felipe Balbi <[email protected]>Acked-by Nishanth Menon <[email protected]>Looks good to me,
Acked-by Balaji T K <[email protected]>I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4.
Quoted 7 lines
Quoted 3 lines
Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this:
frankly speaking, this driver should be deleted and all users should be moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except for a couple quirks which can be easily worked around.
Do we take that as a NAK to this specific patch?
I am not complaining about the future migration to a solution that is much more generic and scalable, but having fixes for current problems should'nt be ignored IMHO.
How about a depends on CONFIG_ARCH_OMAP2PLUS instead? will that solve our pains with all OMAP2+ usin this?
Signature · 2 lines
Regards, Nishanth Menon
Quoted 25 lines · Nishanth Menon
Quoted 24 lines · Felipe Balbi
Quoted 23 lines · Ezequiel Garcia
Hi guys,
Quoted 9 lines · Balaji T K
Quoted 8 lines · On Friday 28 June 2013 06:04 PM, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.Quoted 7 lines
Quoted 3 lines
Signed-off-by Amarinder Bindra <[email protected]>Acked-by Felipe Balbi <[email protected]>Acked-by Nishanth Menon <[email protected]>Looks good to me,
Acked-by Balaji T K <[email protected]>I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4.
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this:
frankly speaking, this driver should be deleted and all users should be moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except for a couple quirks which can be easily worked around.
@Felipe:
Do you mind giving me some hints about this quirks? I'm not too familiar with these drivers.
Quoted 6 lines
Do we take that as a NAK to this specific patch?
I am not complaining about the future migration to a solution that is much more generic and scalable, but having fixes for current problems should'nt be ignored IMHO.
Of course.
Quoted 2 lines
How about a depends on
CONFIG_ARCH_OMAP2PLUSinstead? will that solve our pains with all OMAP2+ usin this?
Yes, I think that using ARCH_OMAP2PLUS should do. FWIW, until we have sdhci ready to replace omap_hsmmc, we have no choice but to apply such a patch.
@Nishant, Balaji: Can you take care of resending this?
Thanks!
Signature · 3 lines
Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com
Quoted 30 lines · Ezequiel Garcia
Quoted 29 lines · Nishanth Menon
Quoted 28 lines · Felipe Balbi
Quoted 26 lines · Ezequiel Garcia
Hi guys,
Quoted 9 lines · Balaji T K
Quoted 8 lines · On Friday 28 June 2013 06:04 PM, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.Quoted 7 lines
Quoted 3 lines
Signed-off-by Amarinder Bindra <[email protected]>Acked-by Felipe Balbi <[email protected]>Acked-by Nishanth Menon <[email protected]>Looks good to me,
Acked-by Balaji T K <[email protected]>I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4.
Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this:
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
frankly speaking, this driver should be deleted and all users should be moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except for a couple quirks which can be easily worked around.
@Felipe:
Do you mind giving me some hints about this quirks? I'm not too familiar with these drivers.
one of the quirks is that TI decided to registers into one (because they both had 16-bits reserved, so, well, we can make the HW 0.0000000000001 dollar cheaper :-p )
The other is related where our SDHCI registers start. Because of TI's added registers (SYSConfig and REVISION, etc), SDHCI registers have an offset which generic SDHCI driver, doesn't cope with right now.
Quoted 7 lines
Quoted 6 lines
Do we take that as a NAK to this specific patch?
I am not complaining about the future migration to a solution that is much more generic and scalable, but having fixes for current problems should'nt be ignored IMHO.
Quoted 8 lines
Of course.
Quoted 2 lines
How about a depends on
CONFIG_ARCH_OMAP2PLUSinstead? will that solve our pains with all OMAP2+ usin this?Yes, I think that using
ARCH_OMAP2PLUSshould do. FWIW, until we have sdhci ready to replaceomap_hsmmc, we have no choice but to apply such a patch.
if you do change to ARCH_OMAP2PLUS, please also add COMPILE_TEST (ARCH_OMAP2PLUS || COMPILE_TEST) so we can build in other archs.
Signature · 1 line
balbi
Quoted 25 lines · Nishanth Menon
Quoted 24 lines · Felipe Balbi
Quoted 23 lines · Ezequiel Garcia
Hi guys,
Quoted 9 lines · Balaji T K
Quoted 8 lines · On Friday 28 June 2013 06:04 PM, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is also used for OMAP5 MMC controller operation. Considering that the device tree entries are already there for this, allow the driver to be built when only OMAP5 is enabled. This allows MMC root filesystems to be available in "OMAP5 only" configurations.Quoted 7 lines
Quoted 3 lines
Signed-off-by Amarinder Bindra <[email protected]>Acked-by Felipe Balbi <[email protected]>Acked-by Nishanth Menon <[email protected]>Looks good to me,
Acked-by Balaji T K <[email protected]>I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4.
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this:
frankly speaking, this driver should be deleted and all users should be moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except for a couple quirks which can be easily worked around.
Do we take that as a NAK to this specific patch?
heh, not really. We can't prevent bug fixes to this driver just because long ago TI decided to write a TI-specific driver when it could just re-use SDHCI :-)
Signature · 1 line
balbi
PATCH v2 1/1 mmc: omap_hsmmc: use the generic config for omap2plus devices
In reply to [email protected]From: Amarinder Bindra <[email protected]>
OMAP's hs_mmc driver is used for MMC controller operation on many omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).
Considering that the device tree entries are already present for these, allow the driver to be built using the config ARCH_OMAP2PLUS rather than individually adding a config for each SoC to enable the support.
Use COMPILE_TEST to enable the build for other platforms.
---
Changes in v2:
- Use the config ARCH_OMAP2PLUS to enable the driver
- Use COMPILE_TEST
- Update the commit message
v1: https://patchwork.kernel.org/patch/2824632/
drivers/mmc/host/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/mmc/host/Kconfig +3 -3
@@ -254,11 +254,11 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 + depends on ARCH_OMAP2PLUS || COMPILE_TEST help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a - Multimedia Card slot, say Y or M here. + If you have an omap2plus board with a Multimedia Card slot, + say Y or M here. If unsure, say N.
Signature · 1 line
1.7.9.5
Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices
Quoted 10 lines · On 21:36-20130710, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is used for MMC controller operation on many omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).Considering that the device tree entries are already present for these, allow the driver to be built using the config
ARCH_OMAP2PLUSrather than individually adding a config for each SoC to enable the support.
Quoted 6 lines
Use
COMPILE_TESTto enable the build for other platforms.Signed-off-by Amarinder Bindra <[email protected]>Cc Ezequiel Garcia <[email protected]>Cc Felipe Balbi <[email protected]>Cc Nishanth Menon <[email protected]>
works for O5.
Signature · 2 lines
Regards, Nishanth Menon
Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices
In reply to [email protected]Quoted 10 lines · On Wed, Jul 10, 2013 at 09:36:24PM +0530, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is used for MMC controller operation on many omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).Considering that the device tree entries are already present for these, allow the driver to be built using the config
ARCH_OMAP2PLUSrather than individually adding a config for each SoC to enable the support.
Quoted 6 lines
Use
COMPILE_TESTto enable the build for other platforms.Signed-off-by Amarinder Bindra <[email protected]>Cc Ezequiel Garcia <[email protected]>Cc Felipe Balbi <[email protected]>Cc Nishanth Menon <[email protected]>
Signature · 7 lines
Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices
In reply to [email protected]Quoted 10 lines · On Wed, Jul 10, 2013 at 09:36:24PM +0530, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is used for MMC controller operation on many omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).Considering that the device tree entries are already present for these, allow the driver to be built using the config
ARCH_OMAP2PLUSrather than individually adding a config for each SoC to enable the support.
Quoted 6 lines
Use
COMPILE_TESTto enable the build for other platforms.Signed-off-by Amarinder Bindra <[email protected]>Cc Ezequiel Garcia <[email protected]>Cc Felipe Balbi <[email protected]>Cc Nishanth Menon <[email protected]>
Signature · 1 line
balbi
Balaji T K
Acked-byRe: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices
Quoted 11 lines · Felipe Balbi
Quoted 10 lines · On Wed, Jul 10, 2013 at 09:36:24PM +0530, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is used for MMC controller operation on many omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).Considering that the device tree entries are already present for these, allow the driver to be built using the config
ARCH_OMAP2PLUSrather than individually adding a config for each SoC to enable the support.
Quoted 9 lines
Quoted 6 lines
Use
COMPILE_TESTto enable the build for other platforms.Signed-off-by Amarinder Bindra <[email protected]>Cc Ezequiel Garcia <[email protected]>Cc Felipe Balbi <[email protected]>Cc Nishanth Menon <[email protected]>Acked-by Felipe Balbi <[email protected]>
Re: [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices
In reply to [email protected]Hi,
Quoted 5 lines · On Wed, Jul 10 2013, [email protected] wrote:
From: Amarinder Bindra <[email protected]>
OMAP's
hs_mmcdriver is used for MMC controller operation on many omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).
Quoted 8 lines
Considering that the device tree entries are already present for these, allow the driver to be built using the config
ARCH_OMAP2PLUSrather than individually adding a config for each SoC to enable the support.Use
COMPILE_TESTto enable the build for other platforms.Signed-off-by Amarinder Bindra <[email protected]>
Thanks, pushed to mmc-next for 3.12.
- Chris.
Signature · 1 line
Chris Ball <[email protected]> <http://printf.net/>