Skip to contentSkip to conversation

ath5k: fix extra set bit in multicast mask

PATCH New Bob Copeland 1 participant 1 message Jul 11, 2013 Atheros ATH5K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath5k: fix extra set bit in multicast mask

Bit 32 was always set which looks to have been accidental, according to git history.

---

Just found this while reading old code -- I could maybe see bit 0 being special, but bit 32 seemed odd. Then looked back through the history and looks like it was accidentally added when prepare_multicast() was introduced; prior both were initialized to 0.

 drivers/net/wireless/ath/ath5k/mac80211-ops.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath5k/mac80211-ops.c +1 -1
index 06f86f4..f5f1bc7 100644
@@ -325,7 +325,7 @@ ath5k_prepare_multicast(struct ieee80211_hw *hw,
 	struct netdev_hw_addr *ha;
 
 	mfilt[0] = 0;
-	mfilt[1] = 1;
+	mfilt[1] = 0;
 
 	netdev_hw_addr_list_for_each(ha, mc_list) {
 		/* calculate XOR of eight 6-bit values */
Signature · 4 lines
1.7.10.4

-- 
Bob Copeland %% www.bobcopeland.com