Skip to contentSkip to conversation

Thermal: CPU Package temperature thermal

DISCUSSION Dave Jones 2 participants 2 messages Jul 11, 2013 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw

Review

Quoted 4 lines
(quoted diff) +4 -0
+static int sys_get_curr_temp(struct thermal_zone_device *tzd, unsigned long *temp)
+static int sys_get_trip_temp(struct thermal_zone_device *tzd,
+int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
+static int sys_get_trip_type(struct thermal_zone_device *thermal,

I saw these and thought "huh, syscalls in a module?"

Perhaps a better prefix can be used here for these function names ?

Dave

#2 lore raw
Quoted 7 lines · Dave Jones

Review

Quoted 4 lines
(quoted diff) +4 -0
+static int sys_get_curr_temp(struct thermal_zone_device *tzd, unsigned long *temp)
+static int sys_get_trip_temp(struct thermal_zone_device *tzd,
+int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
+static int sys_get_trip_type(struct thermal_zone_device *thermal,

I saw these and thought "huh, syscalls in a module?"

Quoted 5 lines

Perhaps a better prefix can be used here for these function names ?

Dave

Certainly. Here "sys" stands for "sys-fs".

Thanks,
Srinivas