Skip to contentSkip to conversation

x86: make sure IDT is page aligned

PATCH New Kees Cook 1 participant 1 message Jul 15, 2013

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 x86: make sure IDT is page aligned

Since the IDT is referenced from a fixmap, make sure it is page aligned. This avoids the risk of the IDT ever being moved in the bss and having the mapping be offset, resulting in calling incorrect handlers. In the current upstream kernel this is not a manifested bug, but heavily patched kernels (such as those using the PaX patch series) did encounter this bug.

---
Note: this is the minimal change for 3.10/stable and 3.11/stable only

---
 arch/x86/kernel/head_64.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/head_64.S +1 -1
index 5e4d8a8..77e6d3e 100644
@@ -513,7 +513,7 @@ ENTRY(phys_base)
 #include "../../x86/xen/xen-head.S"
 	
 	.section .bss, "aw", @nobits
-	.align L1_CACHE_BYTES
+	.align PAGE_SIZE
 ENTRY(idt_table)
 	.skip IDT_ENTRIES * 16
 
Signature · 6 lines
1.7.9.5


-- 
Kees Cook
Chrome OS Security