Skip to contentSkip to conversation

xfs_metadump: manpage fix regarding frozen fs

PATCH Applied Eric Sandeen 3 participants 4 messages Jul 16, 2013 – Jul 22, 2013

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 xfs_metadump: manpage fix regarding frozen fs

The xfs_metadump manpage states that metadump works on a frozen filesystem; it does not. In fact, there is no way to detect a frozen filesystem, so we can't make it work, either.

So just remove this from the manpage; unmounted or RO mounted is what is enforced by xfs_metadump.

Signed-off-by Eric Sandeen <[email protected]>

---

man/man8/xfs_metadump.8 +2 -4
index 26cea97..4fa1b1c 100644
@@ -32,10 +32,8 @@ is \-, then the output is sent to stdout. This allows the output to be
 redirected to another program such as a compression application.
 .PP
 .B xfs_metadump
-should only be used to copy unmounted filesystems, read-only mounted
-filesystems, or frozen filesystems (see
-.BR xfs_freeze (8)).
-Otherwise, the generated dump could be inconsistent or corrupt.
+may only be used to copy unmounted filesystems, or read-only mounted
+filesystems.
 .PP
 .B xfs_metadump
 does not alter the source filesystem in any way. The

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw

Hey Eric,

Quoted 9 lines · Eric Sandeen

The xfs_metadump manpage states that metadump works on a frozen filesystem; it does not. In fact, there is no way to detect a frozen filesystem, so we can't make it work, either.

So just remove this from the manpage; unmounted or RO mounted is what is enforced by xfs_metadump.

Signed-off-by Eric Sandeen <[email protected]>

I gave this a try and it *seemed* to work fine on a frozen filesystem. Can you provide a bit of detail about why xfs_metadump doesn't work on frozen filesystems? What am I missing?

Thanks,
Ben

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 8 lines · Ben Myers

Hey Eric,

Quoted 5 lines · Eric Sandeen

The xfs_metadump manpage states that metadump works on a frozen filesystem; it does not. In fact, there is no way to detect a frozen filesystem, so we can't make it work, either.

Quoted 9 lines
Quoted 4 lines

So just remove this from the manpage; unmounted or RO mounted is what is enforced by xfs_metadump.

Signed-off-by Eric Sandeen <[email protected]>

I gave this a try and it *seemed* to work fine on a frozen filesystem. Can you provide a bit of detail about why xfs_metadump doesn't work on frozen filesystems? What am I missing?

Hum, when I tried it it didn't work. I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work?

-Eric

Quoted 2 lines

Thanks,
Ben

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by Applied
#3 lore raw
Quoted 13 lines · Eric Sandeen
Quoted 11 lines · Ben Myers

Hey Eric,

Quoted 8 lines · Eric Sandeen

The xfs_metadump manpage states that metadump works on a frozen filesystem; it does not. In fact, there is no way to detect a frozen filesystem, so we can't make it work, either.

So just remove this from the manpage; unmounted or RO mounted is what is enforced by xfs_metadump.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Eric Sandeen <[email protected]>

I gave this a try and it *seemed* to work fine on a frozen filesystem. Can you provide a bit of detail about why xfs_metadump doesn't work on frozen filesystems? What am I missing?

Hum, when I tried it it didn't work. I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work?

Gah. As we discussed on IRC, I was wrong. So, so wrong.

Reviewed-by Ben Myers <[email protected]>

Applied.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs