build for pv-grub stubdom

PATCH In review IAN DELANEY 3 participants 10 messages Jul 21, 2013 – Aug 13, 2013 3 messages not in the archive

Share & tools

IAN DELANEY

author

2013-07-21 16:36 UTC #0 lore raw

Does this

install -d -m0755 -p "/mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image//usr/lib/xen/boot" install -m0644 -p mini-os-x86_32-grub/mini-os.gz "/mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image//usr/lib/xen/boot/pv-grub-x86_32.gz"
make: Leaving directory `/mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom'

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
Completed installing xen-pvgrub-4.3.0
into /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image/

* QA Notice: make jobserver unavailable:
*
* make[1]: warning: jobserver unavailable: using -j1. Add `+'
to parent make rule.
* make[1]: warning: jobserver unavailable: using -j1. Add `+'
to parent make rule.

* QA Notice: Package triggers severe warnings which indicate that it
* may exhibit random runtime failures.
* ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
warning: implicit declaration of function
‘kill’ [-Wimplicit-function-declaration]
* ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit
declaration of function ‘do_exit’ [-Wimplicit-function-declaration]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
warning: implicit declaration of function
‘memcpy’ [-Wimplicit-function-declaration]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:5:
warning: implicit declaration of function
‘memmove’ [-Wimplicit-function-declaration]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:5:
warning: implicit declaration of function
‘memset’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
warning: implicit declaration of function
‘kill’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/fstat64r.c:65:3:
warning: implicit declaration of function
‘_fstat64’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/open64r.c:62:3:
warning: implicit declaration of function
‘_open64’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/lseek64r.c:61:3:
warning: implicit declaration of function
‘lseek64’ [-Wimplicit-function-declaration]
* ../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:355:7:
warning: implicit declaration of function
‘profil’ [-Wimplicit-function-declaration]
* ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit
declaration of function ‘do_exit’ [-Wimplicit-function-declaration]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
warning: implicit declaration of function
‘memcpy’ [-Wimplicit-function-declaration]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:5:
warning: implicit declaration of function
‘memmove’ [-Wimplicit-function-declaration]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:5:
warning: implicit declaration of function
‘memset’ [-Wimplicit-function-declaration]

* QA Notice: Package triggers severe warnings which indicate that it
* may exhibit random runtime failures.
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:14:
warning: incompatible implicit declaration of built-in function
‘memcpy’ [enabled by default]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:14:
warning: incompatible implicit declaration of built-in function
‘memmove’ [enabled by default]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:14:
warning: incompatible implicit declaration of built-in function
‘memset’ [enabled by default]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:14:
warning: incompatible implicit declaration of built-in function
‘memcpy’ [enabled by default]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:14:
warning: incompatible implicit declaration of built-in function
‘memmove’ [enabled by default]
* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:14:
warning: incompatible implicit declaration of built-in function
‘memset’ [enabled by default]

* Please do not file a Gentoo bug and instead report the above QA
* issues directly to the upstream developers of this software.
* Homepage: http://xen.org/

draw any concern from anyone? These have been in place for a long time in 4.x.x. Basically portage keep a memory of any and all gcc warnings and lists them all in one list at the build's end. I highlighted them before, thought I might 'try again'.

Signature · 8 lines

kind regards

Ian Delaney

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

Ian Campbell

2013-07-22 18:09 UTC #1 lore raw

Quoted 1 line · IAN DELANEY

Does this

[...]

Quoted 4 lines

draw any concern from anyone? These have been in place for a long time in 4.x.x. Basically portage keep a memory of any and all gcc warnings and lists them all in one list at the build's end. I highlighted them before, thought I might 'try again'.

Thanks for bringing them up.

These mostly seem to be from 3rd party code included with Xen (mostly newlib it seems). Unless there are upstream fixes which we could backport (or resync to a new-newlib) I don't think we care all that much. There are also plans afoot to replace newlib with something better, so it might not even be worth doing that.

Ian.

Samuel Thibault

2013-07-26 13:55 UTC #2 lore raw

In reply to IAN DELANEY

Hello,

Quoted 7 lines · IAN DELANEY, le Mon 22 Jul 2013 00:36:43 +0800, a écrit :

* ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
warning: implicit declaration of function
‘kill’ [-Wimplicit-function-declaration]
‘_fstat64’ [-Wimplicit-function-declaration] ‘_open64’ [-Wimplicit-function-declaration] ‘lseek64’ [-Wimplicit-function-declaration]
‘profil’ [-Wimplicit-function-declaration]

We don't actually provide these functions.

Quoted 2 lines

* ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit declaration of function ‘do_exit’ [-Wimplicit-function-declaration]

This should be fixed by this I guess:

stubdom/grub/config.h +1 -0

index 1649d51..15a6583 100644
@@ -2,6 +2,7 @@
 #undef putchar
 #include <ctype.h>
 #include <string.h>
+#include <kernel.h>
 #define debug _debug
 #define grub_halt(a) do_exit()
 #define printf grub_printf

Quoted 3 lines

* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
warning: implicit declaration of function
‘memcpy’ [-Wimplicit-function-declaration]

And that, by that:

xen/include/xen/libelf.h +2 -0

index 2a6fa54..e65db6d 100644
@@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
 #ifdef __XEN__
 #include <public/elfnote.h>
 #include <public/features.h>
+#include <xen/string.h>
 #else
 #include <xen/elfnote.h>
 #include <xen/features.h>
 
 #include <stdarg.h>
+#include <string.h>
 
 struct elf_binary;
 typedef void elf_log_callback(struct elf_binary*, void *caller_data,

Samuel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

Ian Campbell

2013-07-29 08:17 UTC #3 lore raw

Quoted 11 lines · Samuel Thibault

Hello,
Quoted 7 lines · IAN DELANEY, le Mon 22 Jul 2013 00:36:43 +0800, a écrit :
* ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
warning: implicit declaration of function
‘kill’ [-Wimplicit-function-declaration]
‘_fstat64’ [-Wimplicit-function-declaration] ‘_open64’ [-Wimplicit-function-declaration] ‘lseek64’ [-Wimplicit-function-declaration]
‘profil’ [-Wimplicit-function-declaration]

Quoted 6 lines

We don't actually provide these functions.
Quoted 2 lines
* ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit declaration of function ‘do_exit’ [-Wimplicit-function-declaration]
This should be fixed by this I guess:

Ian, can you confirm if these work. If so the Samuel please can I get a S-o-b (and ideally a commit message so I don't have to fabricate one).

Thanks,
Ian.

Quoted 39 lines

stubdom/grub/config.h +1 -0

index 1649d51..15a6583 100644
@@ -2,6 +2,7 @@
 #undef putchar
 #include <ctype.h>
 #include <string.h>
+#include <kernel.h>
 #define debug _debug
 #define grub_halt(a) do_exit()
 #define printf grub_printf

Quoted 4 lines

* /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
warning: implicit declaration of function
‘memcpy’ [-Wimplicit-function-declaration]

And that, by that:

xen/include/xen/libelf.h +2 -0

index 2a6fa54..e65db6d 100644
@@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
 #ifdef __XEN__
 #include <public/elfnote.h>
 #include <public/features.h>
+#include <xen/string.h>
 #else
 #include <xen/elfnote.h>
 #include <xen/features.h>
 
 #include <stdarg.h>
+#include <string.h>
 
 struct elf_binary;
 typedef void elf_log_callback(struct elf_binary*, void *caller_data,

Quoted 6 lines

Samuel
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ian Campbell

2013-07-31 12:05 UTC #5 lore raw

Adding the list back, please don't drop CCs.

Quoted 6 lines · IAN DELANEY

you caught me off guard somewhat here. I thought from
< There are also plans afoot to replace newlib with something better, < so it might not even be worth doing that.
it was too trivial.

I did say "might not" and Samuel seemed happy to fix at least some of them so we might as take those fixes.

Quoted 26 lines

You have killed a few off. I added the patch by
Samuel Thibault (same as what you sent) to xen-pvgrub which builds the stubdom and we're down to
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Completed installing xen-pvgrub-4.3.0
into /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image/
* QA Notice: make jobserver unavailable:
*
* make[1]: warning: jobserver unavailable: using -j1. Add `+'
to parent make rule.
* make[1]: warning: jobserver unavailable: using -j1. Add `+'
to parent make rule.
* QA Notice: Package triggers severe warnings which indicate that it
* may exhibit random runtime failures.
* ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
warning: implicit declaration of function
‘kill’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
warning: implicit declaration of function
‘kill’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/fstat64r.c:65:3:
warning: implicit declaration of function
‘_fstat64’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/lseek64r.c:61:3:

Quoted 8 lines

warning: implicit declaration of function
‘lseek64’ [-Wimplicit-function-declaration]
* ../../../../../newlib-1.16.0/newlib/libc/reent/open64r.c:62:3:
warning: implicit declaration of function
‘_open64’ [-Wimplicit-function-declaration]
* ../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:355:7:
warning: implicit declaration of function
‘profil’ [-Wimplicit-function-declaration]

I think these are all the ones which Samuel indicated were simply not supported by mini-os. We must not end up linking these files or else there would be a link time error.

Quoted 2 lines

* Please do not file a Gentoo bug and instead report the above QA
* issues directly to the upstream developers of this software.

Hrm. I would rather hope that bugs would be reported to the Gentoo maintainer who would take responsiblity with the upstream relationship rather than pushing it onto the end users who may not be in a position to make a good report about an issue seen with an ebuild.

Or maybe I misunderstand how Gentoo QA is structured and/or where/who this suggestion is actually reported to.

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ian Campbell

2013-07-31 13:56 UTC #7 lore raw

I've put the list back on the CC, plerase use reply to all.

Quoted 25 lines · IAN DELANEY

Quoted 16 lines · On Wed, 31 Jul 2013 13:05:24 +0100 Ian Campbell <[email protected]> wrote:
Adding the list back, please don't drop CCs.
I think these are all the ones which Samuel indicated were simply not supported by mini-os. We must not end up linking these files or else there would be a link time error.
Quoted 2 lines
* Please do not file a Gentoo bug and instead report the above QA
* issues directly to the upstream developers of this software.
Hrm. I would rather hope that bugs would be reported to the Gentoo maintainer who would take responsiblity with the upstream relationship rather than pushing it onto the end users who may not be in a position to make a good report about an issue seen with an ebuild.
Quoted 5 lines
Or maybe I misunderstand how Gentoo QA is structured and/or where/who this suggestion is actually reported to.
Ian.

Quoted 8 lines

Well gentoo QA is pretty 'low level' in this regard or instance. For 1 I am the xen gentoo maintainer and it was me who observed and sent it, however your point remains valid in essence. The portage package itself basically has a ready made list of various known gcc, build, test, install errors and actions them accordingly. Some errors will have the msg prompting to report to gentoo bugzilla. These ones have been determined to warrant pointing to upstream directly. The point is somewhat moot since it's me bringing it to yr attention.

OK, that's fine. I was mostly concerned about a clueless but enthusiastic user picking them up and sending them here with no context or understanding or ability answer followup questions, which mostly jsut wastes everyone's time.

Quoted 5 lines

"We must not end up linking these files or else there would be a link time error" I have some trouble with from its technical aspect rather than a linguistic one. It's not clear to me whether this is an observation of what's happening in the build process or, well, something else. Either way many thanks for picking up on the issue(s).

Right, By "must not" I meant "we aren't in practice".

Ian.

A message that is not in the archive (sent off-list or not yet received): [email protected]

IAN DELANEY

author

2013-08-01 06:55 UTC #9 lore raw

Quoted 4 lines · On Wed, 31 Jul 2013 14:56:10 +0100 Ian Campbell <[email protected]> wrote:

You've dropped the list again. I'm going to reply publicly cutting out the bit about mva in case he takes offence on the comments about his English ;-). I've replied to just that bit below.

Actually mva was helpful and we got to the bottom of several of the

Quoted 5 lines

issues he reported. He wasn't at all the sort of clueless user I mention in my public reply.
Ian.

sorry Ian, (nice name) I'm a bit naive when it comes to email and CC, I don't actually email much despite being s dev, I'm kind of a minor player, however see I CCd to [email protected], do you wish for more? I'm glad to see mva's input lead to bearing some nice fruit, and he's definitely no clueless user.

Signature · 3 lines

kind regards

Ian Delaney

Samuel Thibault

2013-08-13 21:12 UTC #10 lore raw

In reply to Ian Campbell

Quoted 2 lines · Ian Campbell, le Wed 31 Jul 2013 13:05:24 +0100, a écrit :

I think these are all the ones which Samuel indicated were simply not supported by mini-os.

Yes.

Samuel

Samuel Thibault

2013-07-29 09:18 UTC #11 lore raw

PATCH 1/1 Fix stubdom undeclared function build warnings

In reply to Samuel Thibault

This includes a few headers to fix some missing function declarations.

Signed-off-by Samuel Thibault <[email protected]>

stubdom/grub/config.h +1 -0

index 1649d51..15a6583 100644
@@ -2,6 +2,7 @@
 #undef putchar
 #include <ctype.h>
 #include <string.h>
+#include <kernel.h>
 #define debug _debug
 #define grub_halt(a) do_exit()
 #define printf grub_printf

xen/include/xen/libelf.h +2 -0

index 2a6fa54..e65db6d 100644
@@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
 #ifdef __XEN__
 #include <public/elfnote.h>
 #include <public/features.h>
+#include <xen/string.h>
 #else
 #include <xen/elfnote.h>
 #include <xen/features.h>
 
 #include <stdarg.h>
+#include <string.h>
 
 struct elf_binary;
 typedef void elf_log_callback(struct elf_binary*, void *caller_data,

Ian Campbell

2013-08-02 16:08 UTC #12 lore raw

Re: [PATCH] Fix stubdom undeclared function build warnings

Quoted 1 line · Samuel Thibault

This includes a few headers to fix some missing function declarations.

I inserted:

../grub-upstream/stage2/builtins.c:1728:3: warning: implicit declaration of function ‘do_exit’ [-Wimplicit-function-declaration] stubdom/include/xen/libelf/libelf.h:453:5: warning: implicit declaration of function ‘memcpy’ [-Wimplicit-function-declaration]

Quoted 1 line

Signed-off-by Samuel Thibault <[email protected]>

Acked + added a Reported-by for IAN + applied.

Quoted 32 lines

stubdom/grub/config.h +1 -0

index 1649d51..15a6583 100644
@@ -2,6 +2,7 @@
 #undef putchar
 #include <ctype.h>
 #include <string.h>
+#include <kernel.h>
 #define debug _debug
 #define grub_halt(a) do_exit()
 #define printf grub_printf

xen/include/xen/libelf.h +2 -0

index 2a6fa54..e65db6d 100644
@@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
 #ifdef __XEN__
 #include <public/elfnote.h>
 #include <public/features.h>
+#include <xen/string.h>
 #else
 #include <xen/elfnote.h>
 #include <xen/features.h>
 
 #include <stdarg.h>
+#include <string.h>
 
 struct elf_binary;
 typedef void elf_log_callback(struct elf_binary*, void *caller_data,

Quoted 4 lines

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel