s390: Kconfig: select 'TTY' when 'S390_GUEST' enabled.

PATCH In review Chen Gang 2 participants 4 messages Jul 23, 2013 – Jul 24, 2013 2 messages not in the archive

Subsystems (2)

s390 Multifunction devices (MFD)

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20130723104703.GB26775@osiris

Chen Gang

author

2013-07-23 23:53 UTC #2 lore raw

Quoted 8 lines · Heiko Carstens

Quoted 7 lines · Chen Gang
'VIRTIO_CONSOLE' depends on 'TTY', so need select 'TTY' explicitly before select 'VIRTIO_CONSOLE'.
Or randconfig can generate a config file which enable 'VIRTIO_CONSOLE' but disable 'TTY' (e.g. the attachment).

Quoted 9 lines

Quoted 4 lines
Signed-off-by Chen Gang <[email protected]>
---
 arch/s390/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks.

Thank you very much.

Signature · 1 line

Chen Gang

Chen Gang

author

2013-07-24 03:34 UTC #3 lore raw

PATCH 1/1 drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled.

'irq_domain' depends on hard irqs, so for the architectures which have no hard irqs, but still need mfd (e.g. s390), need disable the related code, or can not pass compiling.

The related commit:

"c94bb23 mfd: Make MFD core code Device Tree and IRQ domain aware"

The related error: (with allmodconfig under s390)

ERROR: "irq_create_mapping" [drivers/mfd/mfd-core.ko] undefined!

Signed-off-by Chen Gang <[email protected]>

---
 drivers/mfd/mfd-core.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

drivers/mfd/mfd-core.c +4 -1

index 7604f4e..8e56a74 100644
@@ -129,13 +129,16 @@ static int mfd_add_device(struct device *parent, int id,
 			res[r].end = mem_base->start +
 				cell->resources[r].end;
 		} else if (cell->resources[r].flags & IORESOURCE_IRQ) {
+#ifdef HAVE_GENERIC_HARDIRQS
 			if (domain) {
 				/* Unable to create mappings for IRQ ranges. */
 				WARN_ON(cell->resources[r].start !=
 					cell->resources[r].end);
 				res[r].start = res[r].end = irq_create_mapping(
 					domain, cell->resources[r].start);
-			} else {
+			} else
+#endif
+			{
 				res[r].start = irq_base +
 					cell->resources[r].start;
 				res[r].end   = irq_base +

Signature · 1 line

1.7.7.6

Heiko Carstens

2013-07-24 05:03 UTC #4 lore raw

Re: [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled.

Quoted 6 lines · Chen Gang

'irq_domain' depends on hard irqs, so for the architectures which have no hard irqs, but still need mfd (e.g. s390), need disable the related code, or can not pass compiling.
The related commit:

Quoted 8 lines

"c94bb23 mfd: Make MFD core code Device Tree and IRQ domain aware"
The related error: (with allmodconfig under s390)
ERROR: "irq_create_mapping" [drivers/mfd/mfd-core.ko] undefined!
Signed-off-by Chen Gang <[email protected]>

s390 will have GENERIC_HARDIRQS soon (very likely next merge window), so lets not add more GENERIC_HARDIRQS ifdefs in the code.

Chen Gang

author

2013-07-24 05:32 UTC #5 lore raw

Re: [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled.

Quoted 9 lines · Heiko Carstens

Quoted 8 lines · Chen Gang
Quoted 8 lines
'irq_domain' depends on hard irqs, so for the architectures which have no hard irqs, but still need mfd (e.g. s390), need disable the related code, or can not pass compiling.
The related commit:
"c94bb23 mfd: Make MFD core code Device Tree and IRQ domain aware"

Quoted 9 lines

Quoted 6 lines
Quoted 6 lines
The related error: (with allmodconfig under s390)
ERROR: "irq_create_mapping" [drivers/mfd/mfd-core.ko] undefined!
Signed-off-by Chen Gang <[email protected]>
s390 will have GENERIC_HARDIRQS soon (very likely next merge window), so lets not add more GENERIC_HARDIRQS ifdefs in the code.

OK, thanks.

Signature · 1 line

Chen Gang