Skip to contentSkip to conversation

ARM: shmobile: r8a73a4: Remove ->init_machine() special case

PATCH In review Magnus Damm 2 participants 2 messages Jul 24, 2013

Subsystems (4)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 1/1 ARM: shmobile: r8a73a4: Remove ->init_machine() special case

From: Magnus Damm <[email protected]>

No need to special case r8a73a4 ->init_machine(), so get rid of undesired cpufreq platform device from the generic long term r8a73a4 DT support code.

For short term support on APE6EVM the DT reference implementation already adds a "cpufreq-cpu0" platform device so that can be used for development.

Regarding more long term cpufreq support, perhaps it makes sense to adjust the cpufreq driver to check for DT information directly instead of using a platform device for software configuration and DT for hardware parameters.

---

 arch/arm/mach-shmobile/setup-r8a73a4.c |    6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-shmobile/setup-r8a73a4.c +0 -6
@@ -215,11 +215,6 @@ void __init r8a73a4_init_delay(void)
 }
 
 #ifdef CONFIG_USE_OF
-void __init r8a73a4_add_standard_devices_dt(void)
-{
-	platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
-	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
-}
 
 static const char *r8a73a4_boards_compat_dt[] __initdata = {
 	"renesas,r8a73a4",
@@ -228,7 +223,6 @@ static const char *r8a73a4_boards_compat
 
 DT_MACHINE_START(R8A73A4_DT, "Generic R8A73A4 (Flattened Device Tree)")
 	.init_early	= r8a73a4_init_delay,
-	.init_machine	= r8a73a4_add_standard_devices_dt,
 	.init_time	= shmobile_timer_init,
 	.dt_compat	= r8a73a4_boards_compat_dt,
 MACHINE_END
#1 lore raw
Quoted 16 lines · Magnus Damm

From: Magnus Damm <[email protected]>

No need to special case r8a73a4 ->init_machine(), so get rid of undesired cpufreq platform device from the generic long term r8a73a4 DT support code.

For short term support on APE6EVM the DT reference implementation already adds a "cpufreq-cpu0" platform device so that can be used for development.

Regarding more long term cpufreq support, perhaps it makes sense to adjust the cpufreq driver to check for DT information directly instead of using a platform device for software configuration and DT for hardware parameters.

Quoted 5 lines

---

 arch/arm/mach-shmobile/setup-r8a73a4.c |    6 ------
 1 file changed, 6 deletions(-)

Thanks, I have queued this up for v3.12 in the cleanup2 branch.