Skip to contentSkip to conversation

Fix key release for Fn keys with Samsung series 5 ultra

PATCH In review Mauro Carvalho Chehab 2 participants 3 messages Jul 28, 2013 – Jul 29, 2013

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Mauro Carvalho Chehab

author
#0 lore raw

PATCH 1/1 Fix key release for Fn keys with Samsung series 5 ultra

Samsung series 5 ultra notebooks don't produce release events for certain keys (Fn+F1, Fn+F11, Fn+F12 and Fn Lock). Add those keys at the release fixup table.

Note: Fn Lock actually produces two scancodes: 0xa8 and 0xa9.

Signed-off-by Mauro Carvalho Chehab <[email protected]>
drivers/input/keyboard/atkbd.c +16 -0
index 2626773..90c3113 100644
@@ -943,6 +943,13 @@ static unsigned int atkbd_samsung_forced_release_keys[] = {
 };
 
 /*
+ * Samsung 530U3C/530U4C/532U3C/540U3C Fn release keys not working
+ */
+static unsigned int atkbd_samsung_ultra_forced_release_keys[] = {
+	0xa8, 0xa9, 0xb3, 0xce, 0xd5, -1U
+};
+
+/*
  * Amilo Pi 3525 key release for Fn+Volume keys not working
  */
 static unsigned int atkbd_amilo_pi3525_forced_release_keys[] = {

@@ -1732,6 +1739,15 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
 		.driver_data = atkbd_samsung_forced_release_keys,
 	},
 	{
+		/* Samsung series 5 Ultra (530U3C/530U4C/532U3C/540U3C) */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "530U3C"),
+		},
+		.callback = atkbd_setup_forced_release,
+		.driver_data = atkbd_samsung_ultra_forced_release_keys,
+	},
+	{
 		/* Fujitsu Amilo PA 1510 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),

Cheers,
Mauro

maintainer
#1 lore raw

Hi Mauro,

Quoted 5 lines · Mauro Carvalho Chehab

Samsung series 5 ultra notebooks don't produce release events for certain keys (Fn+F1, Fn+F11, Fn+F12 and Fn Lock). Add those keys at the release fixup table.

Note: Fn Lock actually produces two scancodes: 0xa8 and 0xa9.

Please add a quirk to udev to handle this please.

Thanks.

Signature · 1 line
Dmitry
author
#2 lore raw

Em Sun, 28 Jul 2013 19:14:56 -0700
Dmitry Torokhov <[email protected]> escreveu:

Quoted 10 lines

Hi Mauro,

Quoted 5 lines · Mauro Carvalho Chehab

Samsung series 5 ultra notebooks don't produce release events for certain keys (Fn+F1, Fn+F11, Fn+F12 and Fn Lock). Add those keys at the release fixup table.

Note: Fn Lock actually produces two scancodes: 0xa8 and 0xa9.

Please add a quirk to udev to handle this please.

Ok. I actually opened already a BZ# adding it to udev at Fedora:

	https://bugzilla.redhat.com/show_bug.cgi?id=989103

Btw, please don't apply the patch I sent you yet. I'm finishing to test a new patchset that includes also another Samsung series 5 notebook, and adds the switch for FN LOCK.

Thanks!
Mauro