Skip to contentSkip to conversation

mwifiex: handle driver initialization error paths

DISCUSSION Dan Carpenter 2 participants 2 messages Jul 29, 2013 – Jul 30, 2013

lore
Share & tools
lore
#0 lore raw

Hello Amitkumar Karwar,

The patch 6b41f941d7cd: "mwifiex: handle driver initialization error paths" from Jul 22, 2013, leads to the following warning:
"drivers/net/wireless/mwifiex/main.c:533 mwifiex_fw_dpc()
warn: 'adapter' was already freed."

drivers/net/wireless/mwifiex/main.c

   529          adapter->surprise_removed = true;
   530          mwifiex_terminate_workqueue(adapter);
   531          mwifiex_free_adapter(adapter);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Free.
   532  done:
   533          if (adapter->cal_data) {
                    ^^^^^^^^^^^^^^^^^

Dereference.
534 release_firmware(adapter->cal_data);
535 adapter->cal_data = NULL;
536 }

regards,
dan carpenter

#1 lore raw

Hi Dan,

Quoted 6 lines

Hello Amitkumar Karwar,

The patch 6b41f941d7cd: "mwifiex: handle driver initialization error paths" from Jul 22, 2013, leads to the following warning:
"drivers/net/wireless/mwifiex/main.c:533 mwifiex_fw_dpc()
warn: 'adapter' was already freed."

Thanks for pointing this out. We will fix this regression issue.

Regards,
Amitkumar Karwar