Skip to contentSkip to conversation

gpio/mxc: add chained_irq_enter/exit() to mx2_gpio_irq_handler

PATCH New Uwe Kleine-König 3 participants 5 messages Jul 18, 2013 – Aug 16, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio/mxc: add chained_irq_enter/exit() to mx2_gpio_irq_handler

Similar to commit

	0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler())

. It doesn't seem to be critical to make the irqs work, but still it is more correct.

---
Hello,

note this is completely untested.

Uwe

 drivers/gpio/gpio-mxc.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpio/gpio-mxc.c +4 -0
index 7176743..832881c 100644
@@ -291,6 +291,9 @@ static void mx2_gpio_irq_handler(u32 irq, struct irq_desc *desc)
 {
 	u32 irq_msk, irq_stat;
 	struct mxc_gpio_port *port;
+	struct irq_chip *chip = irq_get_chip(irq);
+
+	chained_irq_enter(chip, desc);
 
 	/* walk through all interrupt status registers */
 	list_for_each_entry(port, &mxc_gpio_ports, node) {
@@ -302,6 +305,7 @@ static void mx2_gpio_irq_handler(u32 irq, struct irq_desc *desc)
 		if (irq_stat)
 			mxc_gpio_irq_handler(port, irq_stat);
 	}
+	chained_irq_exit(chip, desc);
 }
 
 /*
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 gpio/mxc: add chained_irq_enter/exit() to mx2_gpio_irq_handler

Quoted 8 lines · Uwe Kleine-K?nig

Similar to commit

	0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler())

. It doesn't seem to be critical to make the irqs work, but still it is more correct.

You may need to send the patch to Linus Walleij <[email protected]>, who seems to be collecting GPIO drive changes recently.

Shawn

#2 lore raw

PATCH 1/1 gpio/mxc: add chained_irq_enter/exit() to mx2_gpio_irq_handler

In reply to Uwe Kleine-König
Quoted 8 lines · Uwe Kleine-K?nig

Similar to commit

        0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler())

. It doesn't seem to be critical to make the irqs work, but still it is more correct.

Patch is fine, but looks like this to me:

Content-Transfer-Encoding: base64

Sender: "linux-arm-kernel" <[email protected]>
Errors-To: linux-arm-kernel-bounces+linus.walleij=linaro.org at lists.infradead.org

U2ltaWxhciB0byBjb21taXQKCgkwZTQ0YjZlIChncGlvL214YzogYWRkIGNoYWluZWRfaXJxX2Vu dGVyL2V4aXQoKSB0byBteDNfZ3Bpb19pcnFfaGFuZGxlcigpKQoKLiBJdCBkb2Vzbid0IHNlZW0g dG8gYmUgY3JpdGljYWwgdG8gbWFrZSB0aGUgaXJxcyB3b3JrLCBidXQgc3RpbGwgaXQgaXMKbW9y ZSBjb3JyZWN0LgoKU2lnbmVkLW9mZi1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtv ZW5pZ0BwZW5ndXRyb25peC5kZT4KLS0tCkhlbGxvLAoKbm90ZSB0aGlzIGlzIGNvbXBsZXRlbHkg dW50ZXN0ZWQuCgpVd2UKCiBkcml2ZXJzL2dwaW8vZ3Bpby1teGMuYyB8IDQgKysrKwogMSBmaWxl

The encoding is what screw things up.

Can you see if you can resend this without using base64?

Yours,
Linus Walleij

#3 lore raw

PATCH 1/1 gpio/mxc: add chained_irq_enter/exit() to mx2_gpio_irq_handler

Hi Linus,

Quoted 19 lines · Linus Walleij
Quoted 8 lines · Uwe Kleine-K?nig

Similar to commit

        0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler())

. It doesn't seem to be critical to make the irqs work, but still it is more correct.

Patch is fine, but looks like this to me:

Content-Transfer-Encoding: base64

Sender: "linux-arm-kernel" <[email protected]>
Errors-To: linux-arm-kernel-bounces+linus.walleij=linaro.org at lists.infradead.org

Quoted 8 lines

U2ltaWxhciB0byBjb21taXQKCgkwZTQ0YjZlIChncGlvL214YzogYWRkIGNoYWluZWRfaXJxX2Vu dGVyL2V4aXQoKSB0byBteDNfZ3Bpb19pcnFfaGFuZGxlcigpKQoKLiBJdCBkb2Vzbid0IHNlZW0g dG8gYmUgY3JpdGljYWwgdG8gbWFrZSB0aGUgaXJxcyB3b3JrLCBidXQgc3RpbGwgaXQgaXMKbW9y ZSBjb3JyZWN0LgoKU2lnbmVkLW9mZi1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtv ZW5pZ0BwZW5ndXRyb25peC5kZT4KLS0tCkhlbGxvLAoKbm90ZSB0aGlzIGlzIGNvbXBsZXRlbHkg dW50ZXN0ZWQuCgpVd2UKCiBkcml2ZXJzL2dwaW8vZ3Bpby1teGMuYyB8IDQgKysrKwogMSBmaWxl

The encoding is what screw things up.

That means git is unable to apply base64 encoded mail? Hmm, testing with git 1.8.3.2 (from Debian) I can apply the base64 encoded patch. Does your git have 87ab799234639c26ea10de74782fa511cb3ca606 (i.e. is older than 1.5.1)?

Quoted 1 line

Can you see if you can resend this without using base64?

The version I got back via the kernel at pengutronix.de address has:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

and the content is readable just fine in an editor. My copy I got via the linux-arm-kernel subscription is base64 encoded, too. So a mail server on the way to you reencodes my mail. At gmane
(http://article.gmane.org/gmane.linux.ports.arm.kernel/252948/raw) it's already base64. According to the Received: headers it can only be casper.infradead.org or merlin.infradead.org.

I found

	http://mail.python.org/pipermail/mailman-users/2008-September/063286.html

which is really annoying. I'll bounce you the original.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#4 lore raw

PATCH 1/1 gpio/mxc: add chained_irq_enter/exit() to mx2_gpio_irq_handler

Quoted 6 lines · Uwe Kleine-K?nig
Quoted 1 line

The encoding is what screw things up.

That means git is unable to apply base64 encoded mail? Hmm, testing with git 1.8.3.2 (from Debian) I can apply the base64 encoded patch. Does your git have 87ab799234639c26ea10de74782fa511cb3ca606 (i.e. is older than 1.5.1)?

Hm it works, I just never tried it ... nevermind.

Patch applied with Shawn's ACK.

Yours,
Linus Walleij