net_sched: info leak in atm_tc_dump_class()

PATCH In review Dan Carpenter 3 participants 3 messages Jul 30, 2013 – Jul 31, 2013

Subsystems (4)

Networking Network drivers Kernel janitors Traffic control (tc)

lore

Share & tools

lore

Dan Carpenter

author

2013-07-30 10:23 UTC #0 lore raw

PATCH 1/1 net_sched: info leak in atm_tc_dump_class()

The "pvc" struct has a hole after pvc.sap_family which is not cleared.

Signed-off-by Dan Carpenter <[email protected]>

net/sched/sch_atm.c +1 -0

index ca8e0a5..1f9c314 100644
@@ -605,6 +605,7 @@ static int atm_tc_dump_class(struct Qdisc *sch, unsigned long cl,
 		struct sockaddr_atmpvc pvc;
 		int state;
 
+		memset(&pvc, 0, sizeof(pvc));
 		pvc.sap_family = AF_ATMPVC;
 		pvc.sap_addr.itf = flow->vcc->dev ? flow->vcc->dev->number : -1;
 		pvc.sap_addr.vpi = flow->vcc->vpi;

Jiri Pirko

maintainer Reviewed-by on v1 1/1

2013-07-30 11:18 UTC #1 lore raw

Quoted 3 lines · Tue, Jul 30, 2013 at 12:23:39PM CEST, [email protected] wrote:

The "pvc" struct has a hole after pvc.sap_family which is not cleared.
Signed-off-by Dan Carpenter <[email protected]>

Reviewed-by Jiri Pirko <[email protected]>

David Miller

maintainer

2013-07-31 22:04 UTC #2 lore raw

From: Jiri Pirko <[email protected]>
Date: Tue, 30 Jul 2013 13:18:20 +0200

Quoted 5 lines

Quoted 3 lines · Tue, Jul 30, 2013 at 12:23:39PM CEST, [email protected] wrote:
The "pvc" struct has a hole after pvc.sap_family which is not cleared.
Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Jiri Pirko <[email protected]>

Applied and queued up for -stable, thanks.