Skip to contentSkip to conversation

clk: export __clk_get_flags for modular clock providers

PATCH RESEND In review Sebastian Hesselbarth 3 participants 3 messages Apr 15, 2013 – Jul 30, 2013 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 clk: export __clk_get_flags for modular clock providers

The common clock api provides some helpers for clk-providers but does not export these helpers. This hinders clk-providers to be built as modules. This patch adds __clk_get_flags() to the list of exported symbols.

---
Cc: Mike Turquette <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org

---
 drivers/clk/clk.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/clk.c +1 -0
index ed87b24..3e478b8 100644
@@ -450,6 +450,7 @@ unsigned long __clk_get_flags(struct clk *clk)
 {
 	return !clk ? 0 : clk->flags;
 }
+EXPORT_SYMBOL_GPL(__clk_get_flags);
 
 bool __clk_is_enabled(struct clk *clk)
 {
Signature · 1 line
1.7.10.4
#1 lore raw

Hi,

Quoted 19 lines · Sebastian Hesselbarth

The common clock api provides some helpers for clk-providers but does not export these helpers. This hinders clk-providers to be built as modules. This patch adds __clk_get_flags() to the list of exported symbols.

---
Cc: Mike Turquette <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org

---
  drivers/clk/clk.c |    1 +
  1 file changed, 1 insertion(+)
drivers/clk/clk.c +0 -0
index ed87b24..3e478b8 100644

drivers/clk/clk.c unsigned long __clk_get_flags(struct clk *clk) · line 456

Quoted 7 lines
drivers/clk/clk.c +1 -0
@@ -450,6 +450,7 @@ unsigned long __clk_get_flags(struct clk *clk)
  {
  	return !clk ? 0 : clk->flags;
  }
+EXPORT_SYMBOL_GPL(__clk_get_flags);
 
  bool __clk_is_enabled(struct clk *clk)
  {

I think this got merged slightly wrong. The EXPORT_SYMBOL_GPL macro came under clk_unprepare_unused_subtree() instead of under __clk_get_flags():

Of course this is not that important, but it's a bit confusing when you look at the code.

--
Cheers,
Luca.

#2 lore raw

PATCH RESEND 1/1 clk: export __clk_get_flags for modular clock providers

Quoting Luciano Coelho (2013-07-04 13:45:27)

Quoted 35 lines

Hi,

Quoted 19 lines · Sebastian Hesselbarth

The common clock api provides some helpers for clk-providers but does not export these helpers. This hinders clk-providers to be built as modules. This patch adds __clk_get_flags() to the list of exported symbols.

---
Cc: Mike Turquette <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org

---
  drivers/clk/clk.c |    1 +
  1 file changed, 1 insertion(+)
drivers/clk/clk.c +0 -0
index ed87b24..3e478b8 100644

drivers/clk/clk.c unsigned long __clk_get_flags(struct clk *clk) · line 456

Quoted 7 lines
drivers/clk/clk.c +1 -0
@@ -450,6 +450,7 @@ unsigned long __clk_get_flags(struct clk *clk)
  {
      return !clk ? 0 : clk->flags;
  }
+EXPORT_SYMBOL_GPL(__clk_get_flags);
 
  bool __clk_is_enabled(struct clk *clk)
  {

I think this got merged slightly wrong. The EXPORT_SYMBOL_GPL macro came under clk_unprepare_unused_subtree() instead of under __clk_get_flags():

Quoted 2 lines

Of course this is not that important, but it's a bit confusing when you look at the code.

Thanks for pointing this out. I've fixed it up.

Regards,
Mike

Quoted 4 lines

--
Cheers,
Luca.