Skip to contentSkip to conversation

of/documentation: Update G2D documentation

PATCH RESEND New Sachin Kamat 3 participants 3 messages Jul 9, 2013 – Jul 31, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 2/3 of/documentation: Update G2D documentation

Exynos5250 G2D IP requires only the gate clock. Update the binding documentation accordingly.

---
Updated the description of clock-names as suggested by Tomasz Figa.

---
 .../devicetree/bindings/gpu/samsung-g2d.txt        |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/gpu/samsung-g2d.txt +5 -2
index 3f454ff..c4f358d 100644
@@ -11,8 +11,11 @@ Required properties:
 
   - interrupts : G2D interrupt number to the CPU.
   - clocks : from common clock binding: handle to G2D clocks.
-  - clock-names : from common clock binding: must contain "sclk_fimg2d" and
-		  "fimg2d", corresponding to entries in the clocks property.
+  - clock-names : names of clocks listed in clocks property, in the same
+		  order, depending on SoC type:
+		  - for S5PV210 and Exynos4 based SoCs: "fimg2d" and
+		    "sclk_fimg2d"
+		  - for Exynos5250 SoC: "fimg2d".
 
 Example:
 	g2d at 12800000 {
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH RESEND v2 2/3 of/documentation: Update G2D documentation

Hi Sachin,

Quoted 17 lines · On Tuesday 09 of July 2013 11:59:15 Sachin Kamat wrote:

Exynos5250 G2D IP requires only the gate clock. Update the binding documentation accordingly.

---
Updated the description of clock-names as suggested by Tomasz Figa.

---
 .../devicetree/bindings/gpu/samsung-g2d.txt        |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt index 3f454ff..c4f358d 100644

Documentation/devicetree/bindings/gpu/samsung-g2d.txt Required properties: · line 18

Quoted 10 lines
Documentation/devicetree/bindings/gpu/samsung-g2d.txt +5 -2
@@ -11,8 +11,11 @@ Required properties:
 
   - interrupts : G2D interrupt number to the CPU.
   - clocks : from common clock binding: handle to G2D clocks.
-  - clock-names : from common clock binding: must contain "sclk_fimg2d" and
-		  "fimg2d", corresponding to entries in the clocks property.
+  - clock-names : names of clocks listed in clocks property, in the same
+		  order, depending on SoC type:
+		  - for S5PV210 and Exynos4 based SoCs: "fimg2d" and
+		    "sclk_fimg2d"
+		  - for Exynos5250 SoC: "fimg2d".

This looks fine for me now.

Best regards,
Tomasz

#2 lore raw

PATCH RESEND v2 2/3 of/documentation: Update G2D documentation

In reply to Sachin Kamat

Quoting Sachin Kamat (2013-07-08 23:29:15)

Quoted 5 lines

Exynos5250 G2D IP requires only the gate clock. Update the binding documentation accordingly.

Taken into clk-next.

Thanks,
Mike

Quoted 26 lines

---
Updated the description of clock-names as suggested by Tomasz Figa.

---
 .../devicetree/bindings/gpu/samsung-g2d.txt        |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/gpu/samsung-g2d.txt +5 -2
index 3f454ff..c4f358d 100644
@@ -11,8 +11,11 @@ Required properties:
 
   - interrupts : G2D interrupt number to the CPU.
   - clocks : from common clock binding: handle to G2D clocks.
-  - clock-names : from common clock binding: must contain "sclk_fimg2d" and
-                 "fimg2d", corresponding to entries in the clocks property.
+  - clock-names : names of clocks listed in clocks property, in the same
+                 order, depending on SoC type:
+                 - for S5PV210 and Exynos4 based SoCs: "fimg2d" and
+                   "sclk_fimg2d"
+                 - for Exynos5250 SoC: "fimg2d".
 
 Example:
        g2d at 12800000 {
Signature · 1 line
1.7.9.5