Skip to contentSkip to conversation

vga16fb: remove an unused variable

PATCH In review Dan Carpenter 2 participants 2 messages Jul 31, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vga16fb: remove an unused variable

Commit e21d2170f3 "video: remove unnecessary platform_set_drvdata()" introduces an unused variable compile warning.

drivers/video/vga16fb.c +0 -1
index 830ded4..2827333 100644
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */
#1 lore raw
Quoted 5 lines · Dan Carpenter

Commit e21d2170f3 "video: remove unnecessary platform_set_drvdata()" introduces an unused variable compile warning.

Hi Dan Carpenter,

The same patch was submitted by Luis Henriques 2 weeks ago. :) Also, the patch was already applied by Tomi Valkeinen. It will be merged to 3.11-rc4.
Thank you for caring it.

Best regards,
Jingoo Han

Quoted 13 lines
drivers/video/vga16fb.c +0 -1
index 830ded4..2827333 100644
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */