Skip to contentSkip to conversation

mfd: stmpe: Staticise stmpe_of_probe()

PATCH Applied Mark Brown 2 participants 2 messages Jul 28, 2013 – Jul 31, 2013

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 mfd: stmpe: Staticise stmpe_of_probe()

From: Mark Brown <[email protected]>

It is only called from this file so there is no need for it to be in the global namespace and cause sparse to warn.

---
 drivers/mfd/stmpe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mfd/stmpe.c +2 -1
index 5d5e6f9..fff63a4 100644
@@ -1106,7 +1106,8 @@ static int stmpe_devices_init(struct stmpe *stmpe)
 	return ret;
 }
 
-void stmpe_of_probe(struct stmpe_platform_data *pdata, struct device_node *np)
+static void stmpe_of_probe(struct stmpe_platform_data *pdata,
+			   struct device_node *np)
 {
 	struct device_node *child;
 
Signature · 1 line
1.8.3.2
Applied
#1 lore raw

drivers/mfd/stmpe.c

Quoted 11 lines · Mark Brown

From: Mark Brown <[email protected]>

It is only called from this file so there is no need for it to be in the global namespace and cause sparse to warn.

---
 drivers/mfd/stmpe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mfd/stmpe.c +0 -0

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog