pacakge : add trace-cmd package

PATCH New p.floury at gmail.com 3 participants 4 messages Jul 30, 2013 – Jul 31, 2013

lore

Share & tools

lore

p.floury at gmail.com

author

2013-07-30 14:03 UTC #0 lore raw

PATCH 1/1 pacakge : add trace-cmd package

From: pierre <[email protected]>

---
 package/Config.in            |    1 +
 package/tracecmd/Config.in   |    9 +++++++++
 package/tracecmd/tracecmd.mk |   24 ++++++++++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 package/tracecmd/Config.in
 create mode 100644 package/tracecmd/tracecmd.mk

package/Config.in +1 -0

index d980871..4a7bc5d 100644
@@ -39,6 +39,7 @@ source "package/memstat/Config.in"
 source "package/netperf/Config.in"
 source "package/oprofile/Config.in"
 source "package/perf/Config.in"
+source "package/tracecmd/Config.in"
 source "package/ramspeed/Config.in"
 source "package/rt-tests/Config.in"
 source "package/strace/Config.in"

package/tracecmd/Config.in new file +9 -0

new file mode 100644
index 0000000..cb24816
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_TRACECMD
+	bool "trace-cmd"
+	help
+	  trace-cmd - command line reader for ftrace 
+	  need to have ftrace enable into your kernel:
+
+	  http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
+
+comment "trace-cmd - command line reader for ftrace"

package/tracecmd/tracecmd.mk new file +24 -0

new file mode 100644
index 0000000..3ddff28
@@ -0,0 +1,24 @@
+#############################################################
+#
+# tracecmd
+#
+#############################################################
+
+TRACECMD_VERSION = 8c10a774f1f8586cd8b0e
+TRACECMD_SITE = http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
+TRACECMD_SITE_METHOD = git
+TRACECMD_INSTALL_STAGING = YES
+TRACECMD_LICENSE = GPL
+# No license file, the license is in the installed header
+TRACECMD_LICENSE_FILES = COPYING
+define TRACECMD_BUILD_CMDS
+     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define TRACECMD_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/trace-cmd $(TARGET_DIR)/usr/bin
+	$(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/lib/trace-cmd/plugins
+	$(INSTALL) -D -m 0755 $(@D)/plugin_*.so $(TARGET_DIR)/usr/lib/trace-cmd/plugins
+endef
+
+$(eval $(generic-package))

Signature · 1 line

1.7.10.4

Thomas De Schampheleire

2013-07-30 16:59 UTC #1 lore raw

PATCH 1/1 pacakge : add trace-cmd package

Hi Pierre,

Thanks for your contribution! Below are some comments...

Quoted 28 lines · On Tue, Jul 30, 2013 at 4:03 PM, <[email protected]> wrote:

From: pierre <[email protected]>

---
 package/Config.in            |    1 +
 package/tracecmd/Config.in   |    9 +++++++++
 package/tracecmd/tracecmd.mk |   24 ++++++++++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 package/tracecmd/Config.in
 create mode 100644 package/tracecmd/tracecmd.mk

package/Config.in +1 -0

index d980871..4a7bc5d 100644
@@ -39,6 +39,7 @@ source "package/memstat/Config.in"
 source "package/netperf/Config.in"
 source "package/oprofile/Config.in"
 source "package/perf/Config.in"
+source "package/tracecmd/Config.in"
 source "package/ramspeed/Config.in"
 source "package/rt-tests/Config.in"
 source "package/strace/Config.in"

package/tracecmd/Config.in new file +0 -0

new file mode 100644
index 0000000..cb24816

package/tracecmd/Config.in line 7

Quoted 7 lines

package/tracecmd/Config.in new file +7 -0

@@ -0,0 +1,9 @@
+config BR2_PACKAGE_TRACECMD
+       bool "trace-cmd"
+       help
+         trace-cmd - command line reader for ftrace
+         need to have ftrace enable into your kernel:
+
+         http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git

The help text should not repeat the name of the command. Also, please remove the colon (:) and make the second line a real sentence, for example:
"To do anything useful with this, you should enable ftrace in your kernel configuration"

package/tracecmd/Config.in line 9

Quoted 2 lines

package/tracecmd/Config.in new file +2 -0
+
+comment "trace-cmd - command line reader for ftrace"

This comment should not be there. We only put comments when packages are hidden due to missing dependencies.

Quoted 6 lines

package/tracecmd/tracecmd.mk new file +0 -0
new file mode 100644
index 0000000..3ddff28

package/tracecmd/tracecmd.mk line 8

Quoted 8 lines

package/tracecmd/tracecmd.mk new file +8 -0

@@ -0,0 +1,24 @@
+#############################################################
+#
+# tracecmd
+#
+#############################################################
+
+TRACECMD_VERSION = 8c10a774f1f8586cd8b0e
+TRACECMD_SITE = http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git

This version is tagged, so you'd preferable use that for the version:
trace-cmd-v2.2.1

package/tracecmd/tracecmd.mk line 13

Quoted 5 lines

package/tracecmd/tracecmd.mk new file +5 -0

+TRACECMD_SITE_METHOD = git
+TRACECMD_INSTALL_STAGING = YES
+TRACECMD_LICENSE = GPL
+# No license file, the license is in the installed header
+TRACECMD_LICENSE_FILES = COPYING

What do you mean with this comment 'No license file'? There is a COPYING file, so I don't see the point.

Also, the license should be as specific as possible, so GPLv2, GPLv2+
etc. See http://buildroot.uclibc.org/downloads/manual/manual.html#legal-info-list-licenses
for the list of known abbreviations.

In the case of tracecmd, there both are GPLv2 as LGPLv2.1 files, so both licenses should be specified, as well as the license files COPYING and COPYING.LIB.

package/tracecmd/tracecmd.mk line 24

Quoted 11 lines

package/tracecmd/tracecmd.mk new file +11 -0

+define TRACECMD_BUILD_CMDS
+     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define TRACECMD_INSTALL_TARGET_CMDS
+       $(INSTALL) -D -m 0755 $(@D)/trace-cmd $(TARGET_DIR)/usr/bin
+       $(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/lib/trace-cmd/plugins
+       $(INSTALL) -D -m 0755 $(@D)/plugin_*.so $(TARGET_DIR)/usr/lib/trace-cmd/plugins
+endef
+
+$(eval $(generic-package))

If you send an updated version, please also fix the typo in the title:
pacakge -> package.

Best regards,
Thomas

pierre

author

2013-07-31 08:56 UTC #2 lore raw

PATCH 1/1 pacakge : add trace-cmd package

Hi Thomas,

Thank you for your reply and your comments.

Here is a new version of the package.

Concerning the work flow, I sent the first patch via "git send-email", which was a bit laconic.. Is it ok if I just attach the patch file to a "regular" email ?

Best regards,

Pierre

Quoted 107 lines · Thomas De Schampheleire

Hi Pierre,
Thanks for your contribution! Below are some comments...
Quoted 28 lines · On Tue, Jul 30, 2013 at 4:03 PM, <[email protected]> wrote:
From: pierre <[email protected]>
---
 package/Config.in            |    1 +
 package/tracecmd/Config.in   |    9 +++++++++
 package/tracecmd/tracecmd.mk |   24 ++++++++++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 package/tracecmd/Config.in
 create mode 100644 package/tracecmd/tracecmd.mk
package/Config.in +1 -0
index d980871..4a7bc5d 100644
@@ -39,6 +39,7 @@ source "package/memstat/Config.in"
 source "package/netperf/Config.in"
 source "package/oprofile/Config.in"
 source "package/perf/Config.in"
+source "package/tracecmd/Config.in"
 source "package/ramspeed/Config.in"
 source "package/rt-tests/Config.in"
 source "package/strace/Config.in"
package/tracecmd/Config.in new file +0 -0
new file mode 100644
index 0000000..cb24816
package/tracecmd/Config.in line 7
Quoted 7 lines
package/tracecmd/Config.in new file +7 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_TRACECMD
+       bool "trace-cmd"
+       help
+         trace-cmd - command line reader for ftrace
+         need to have ftrace enable into your kernel:
+
+
http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
The help text should not repeat the name of the command. Also, please remove the colon (:) and make the second line a real sentence, for example:
"To do anything useful with this, you should enable ftrace in your kernel configuration"
package/tracecmd/Config.in line 9
Quoted 2 lines
package/tracecmd/Config.in new file +2 -0
+
+comment "trace-cmd - command line reader for ftrace"
This comment should not be there. We only put comments when packages are hidden due to missing dependencies.
Quoted 6 lines
package/tracecmd/tracecmd.mk new file +0 -0
new file mode 100644
index 0000000..3ddff28
package/tracecmd/tracecmd.mk line 8
Quoted 8 lines
package/tracecmd/tracecmd.mk new file +8 -0
@@ -0,0 +1,24 @@
+#############################################################
+#
+# tracecmd
+#
+#############################################################
+
+TRACECMD_VERSION = 8c10a774f1f8586cd8b0e
+TRACECMD_SITE =
http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
This version is tagged, so you'd preferable use that for the version:
trace-cmd-v2.2.1
package/tracecmd/tracecmd.mk line 13
Quoted 5 lines
package/tracecmd/tracecmd.mk new file +5 -0
+TRACECMD_SITE_METHOD = git
+TRACECMD_INSTALL_STAGING = YES
+TRACECMD_LICENSE = GPL
+# No license file, the license is in the installed header
+TRACECMD_LICENSE_FILES = COPYING
What do you mean with this comment 'No license file'? There is a COPYING file, so I don't see the point.
Also, the license should be as specific as possible, so GPLv2, GPLv2+ etc. See
http://buildroot.uclibc.org/downloads/manual/manual.html#legal-info-list-licenses
for the list of known abbreviations.
In the case of tracecmd, there both are GPLv2 as LGPLv2.1 files, so both licenses should be specified, as well as the license files COPYING and COPYING.LIB.
package/tracecmd/tracecmd.mk
Quoted 8 lines
package/tracecmd/tracecmd.mk new file +8 -0
+define TRACECMD_BUILD_CMDS
+     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define TRACECMD_INSTALL_TARGET_CMDS
+       $(INSTALL) -D -m 0755 $(@D)/trace-cmd $(TARGET_DIR)/usr/bin
+       $(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/lib/trace-cmd/plugins
+       $(INSTALL) -D -m 0755 $(@D)/plugin_*.so
$(TARGET_DIR)/usr/lib/trace-cmd/plugins
package/tracecmd/tracecmd.mk line 24
Quoted 3 lines
package/tracecmd/tracecmd.mk new file +3 -0
+endef
+
+$(eval $(generic-package))
If you send an updated version, please also fix the typo in the title:
pacakge -> package.

Quoted 3 lines

Best regards,
Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130731/5065470b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-package-add-trace-cmd-profiling-tool.patch
Type: application/octet-stream
Size: 2514 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130731/5065470b/attachment.obj>

Thomas Petazzoni

2013-07-31 09:10 UTC #3 lore raw

PATCH 1/1 pacakge : add trace-cmd package

Dear pierre,

Quoted 3 lines · pierre

Concerning the work flow, I sent the first patch via "git send-email", which was a bit laconic.. Is it ok if I just attach the patch file to a "regular" email ?

No, the new version should again been sent with git send-email, with a different subject name, such as '[PATCH v2] trace-cmd: new package', and a changelog of the differences between v1 and v2, like:

trace-cmd: new package

This commit adds a new package for the trace-cmd tool, which does... blabla blabla.

Signed-off-by ....

---
Changes since v1:
- this
- that

Best regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com