Skip to contentSkip to conversation

+ fs-binfmts-add-a-name-field-to-the-binfmt-struct.patch added to -mm tree

DISCUSSION Oleg Nesterov 1 participant 1 message Jul 31, 2013

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines

From: Zach Levis <[email protected]>
Subject: fs/binfmts: add a name field to the binfmt struct

Adding the name field helps when printing error messages referring to specific binfmts.

OK, but...

fs/binfmt_elf_fdpic.c static int elf_fdpic_core_dump(struct co · line 84

Quoted 13 lines

static struct linux_binfmt elf_format = {

(quoted diff) +1 -0
+	.name		= "elf",
 	.module		= THIS_MODULE,
 	.load_binary	= load_elf_binary,
 	.load_shlib	= load_elf_library,

diff -puN fs/binfmt_elf_fdpic.c~fs-binfmts-add-a-name-field-to-the-binfmt-struct fs/binfmt_elf_fdpic.c

fs/binfmt_elf_fdpic.c renamed from fs/binfmt_elf_fdpic.c~fs-binfmts-add-a-name-field-to-the-binfmt-struct +1 -0
@@ -81,6 +81,7 @@ static int elf_fdpic_core_dump(struct co
 #endif
 
 static struct linux_binfmt elf_fdpic_format = {
+	.name		= "FDPIC ELF",

The naming doesn't look consistent, but this is minor.

I think this is not compat-friendly. If we add .name then I think compat_elf_format should have another name != "elf".

Not that I think this is really wrong, but still.

Oleg.