Skip to contentSkip to conversation

libedit: really needs wchar support

PATCH Superseded Gustavo Zacarias 2 participants 2 messages Jul 31, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libedit: really needs wchar support

wctype.h is always included, even in configure tests. Fixes:
http://autobuild.buildroot.net/results/ed8/ed85b9d688ad8389895e3ecd7a6a18151efc328d/

---
 package/libedit/Config.in  | 4 ++++
 package/libedit/libedit.mk | 7 -------
 2 files changed, 4 insertions(+), 7 deletions(-)
package/libedit/Config.in +4 -0
index 4747a38..c8fcf40 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBEDIT
 	bool "libedit"
 	select BR2_PACKAGE_NCURSES
+	depends on BR2_USE_WCHAR
 	help
 	  The editline library (from BSD) provides generic line editing
 	  and history functions. It slightly resembles GNU readline.
@@ -12,3 +13,6 @@ config BR2_PACKAGE_LIBEDIT
 	  in Buildroot as it makes it much simpler than using the upstream
 	  sources which require pmake:
 	  http://www.thrysoee.dk/editline/
+
+comment "libedit requires a toolchain with WCHAR support"
+	depends on !BR2_USE_WCHAR
package/libedit/libedit.mk +0 -7
index 6769fdc..c1e8cc7 100644
@@ -19,11 +19,4 @@ ifeq ($(BR2_PACKAGE_LIBBSD),y)
 LIBEDIT_DEPENDENCIES   += libbsd
 endif
 
-# Wide-char support is not autodetected by configure, we have to help a bit.
-ifeq ($(BR2_TOOLCHAIN_EXTERNAL_WCHAR),y)
-LIBEDIT_CONF_OPT       += --enable-widec
-else
-LIBEDIT_CONF_OPT       += --disable-widec
-endif
-
 $(eval $(autotools-package))
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 libedit: really needs wchar support

Dear Gustavo Zacarias,

Quoted 9 lines · Gustavo Zacarias

wctype.h is always included, even in configure tests. Fixes:
http://autobuild.buildroot.net/results/ed8/ed85b9d688ad8389895e3ecd7a6a18151efc328d/

---
 package/libedit/Config.in  | 4 ++++
 package/libedit/libedit.mk | 7 -------
 2 files changed, 4 insertions(+), 7 deletions(-)

As suggested by Yann on IRC, I'll wait for a version that adds a --enable-widec to LIBEDIT_CONF_OPT.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com