ARM: shmobile: lager: enable Ether

PATCH Superseded Simon Horman 3 participants 20 messages Jul 30, 2013 – Aug 6, 2013

Subsystems (5)

Device tree bindings Arm (32-bit) Arm sub-architectures SuperH +1 more subsystems

lore

Share & tools

lore

Simon Horman

author

2013-07-30 09:09 UTC #0 lore raw

v6 cover ARM: shmobile: lager: enable Ether

this short series enables the on-board ethernet
of the r8a7790 SoC for on lager board.

It has a run-time dependency on
"sh_eth: add support for r8a7790 SoC"

It has been built on top of renesas-next-20130726.

Changes noted in changelogs of individual patches.

Simon Horman (3):
ARM: shmobile: r8a7790: clocks for Ether support
ARM: shmobile: lager: enable Ether
ARM: shmobile: lager: enable nfsroot in DTS

 arch/arm/boot/dts/r8a7790-lager.dts    |  2 +-
 arch/arm/mach-shmobile/board-lager.c   | 30 ++++++++++++++++++++++++++++++
 arch/arm/mach-shmobile/clock-r8a7790.c |  4 ++++
 3 files changed, 35 insertions(+), 1 deletion(-)

Signature · 1 line

1.8.3.2

Simon Horman

author

2013-07-30 09:09 UTC #1 lore raw

PATCH v6 1/3 ARM: shmobile: r8a7790: clocks for Ether support

Signed-off-by Simon Horman <[email protected]>

---

v5
* Split out from "ARM: shmobile: r8a7790: add Ether support"

---
 arch/arm/mach-shmobile/clock-r8a7790.c | 4 ++++
 1 file changed, 4 insertions(+)

arch/arm/mach-shmobile/clock-r8a7790.c +4 -0

index 50d96f9..fc36d3d 100644
@@ -51,6 +51,7 @@
 #define SMSTPCR3 0xe615013c
 #define SMSTPCR5 0xe6150144
 #define SMSTPCR7 0xe615014c
+#define SMSTPCR8 0xe6150990
 
 #define SDCKCR		0xE6150074
 #define SD2CKCR		0xE6150078

@@ -180,6 +181,7 @@ static struct clk div6_clks[DIV6_NR] = {
 
 /* MSTP */
 enum {
+	MSTP813,
 	MSTP721, MSTP720,
 	MSTP717, MSTP716,
 	MSTP522,

@@ -190,6 +192,7 @@ enum {
 };
 
 static struct clk mstp_clks[MSTP_NR] = {
+	[MSTP813] = SH_CLK_MSTP32(&p_clk, SMSTPCR8, 13, 0), /* Ether */
 	[MSTP721] = SH_CLK_MSTP32(&p_clk, SMSTPCR7, 21, 0), /* SCIF0 */
 	[MSTP720] = SH_CLK_MSTP32(&p_clk, SMSTPCR7, 20, 0), /* SCIF1 */
 	[MSTP717] = SH_CLK_MSTP32(&zs_clk, SMSTPCR7, 17, 0), /* HSCIF0 */

@@ -258,6 +261,7 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("sh-sci.7", &mstp_clks[MSTP720]),
 	CLKDEV_DEV_ID("sh-sci.8", &mstp_clks[MSTP717]),
 	CLKDEV_DEV_ID("sh-sci.9", &mstp_clks[MSTP716]),
+	CLKDEV_DEV_ID("r8a7790-ether", &mstp_clks[MSTP813]),
 	CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
 	CLKDEV_DEV_ID("ee200000.mmcif", &mstp_clks[MSTP315]),
 	CLKDEV_DEV_ID("sh_mmcif.0", &mstp_clks[MSTP315]),

Signature · 1 line

1.8.3.2

Simon Horman

author

2013-07-30 09:09 UTC #2 lore raw

PATCH v6 2/3 ARM: shmobile: lager: enable Ether

In reply to Simon Horman

Signed-off-by Simon Horman <[email protected]>

---

This patch has a run-time dependency on "sh_eth: add support for r8a7790 SoC".

v6
* Correct first argument of PIN_MAP_MUX_GROUP_DEFAULT() to use "r8a7790-ether" instead of "sh-eth".
* Remove bogus "IRQ0" comment in ether_resources[]

v5
* As suggested by Laurent Pinchart
- Do not use eth_magic pinmux group, that pin is not used on Lager
* As suggested by Morimoto-san and Magnus Damm
- Refactor moving all setup code into boards-lager.c

v4
* Remove needs_gpio_reset and reset_gpio from ether_platdata as the patch that adds that feature and those fields has been dropped.
* Annotate ether_platdata as __initdata

v3
* Use newly added "r8a7790-ether" instead of "sh-eth"

v2
* Do not add MSTP812, EtherAVB. It is not used.
* As suggested by Sergei Shtylyov <[email protected]>
- Move Ethernet element of MSTP enum to a separate line
- Move declaration of r8a7790_add_ether_device() to immediately after that of r8a7790_add_standard_devices()
- Add __initdata annotation to ether_resource.
* As suggested by Laurent Pinchart
- Do not manipilate sh_eth reset GPIO directly,
rather, do so through newly proposed support for this in the sh_eth driver.
* A suggested by Sergei Shtylyov
- Move DTS portion into a separate patch

---
 arch/arm/mach-shmobile/board-lager.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

arch/arm/mach-shmobile/board-lager.c +30 -0

index 3c67b2a..ac4be4a 100644
@@ -31,6 +31,7 @@
 #include <linux/platform_device.h>
 #include <linux/regulator/fixed.h>
 #include <linux/regulator/machine.h>
+#include <linux/sh_eth.h>
 #include <mach/common.h>
 #include <mach/irqs.h>
 #include <mach/r8a7790.h>

@@ -91,6 +92,20 @@ static struct resource mmcif1_resources[] = {
 	DEFINE_RES_IRQ(gic_spi(170)),
 };
 
+/* Ether */
+static struct sh_eth_plat_data ether_pdata __initdata = {
+	.phy			= 0x1,
+	.edmac_endian		= EDMAC_LITTLE_ENDIAN,
+	.register_type		= SH_ETH_REG_FAST_RCAR,
+	.phy_interface		= PHY_INTERFACE_MODE_RMII,
+	.ether_link_active_low	= 1,
+};
+
+static struct resource ether_resources[] __initdata = {
+	DEFINE_RES_MEM(0xee700000, 0x400),
+	DEFINE_RES_IRQ(gic_spi(162)),
+};
+
 static const struct pinctrl_map lager_pinctrl_map[] = {
 	/* SCIF0 (CN19: DEBUG SERIAL0) */
 	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.6", "pfc-r8a7790",

@@ -103,6 +118,15 @@ static const struct pinctrl_map lager_pinctrl_map[] = {
 				  "mmc1_data8", "mmc1"),
 	PIN_MAP_MUX_GROUP_DEFAULT("sh_mmcif.1", "pfc-r8a7790",
 				  "mmc1_ctrl", "mmc1"),
+	/* Ether */
+	PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7790",
+				  "eth_link", "eth"),
+	PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7790",
+				  "eth_mdio", "eth"),
+	PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7790",
+				  "eth_rmii", "eth"),
+	PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7790",
+				  "intc_irq0", "intc"),
 };
 
 static void __init lager_add_standard_devices(void)

@@ -114,6 +138,7 @@ static void __init lager_add_standard_devices(void)
 	r8a7790_pinmux_init();
 
 	r8a7790_add_standard_devices();
+
 	platform_device_register_data(&platform_bus, "leds-gpio", -1,
 				      &lager_leds_pdata,
 				      sizeof(lager_leds_pdata));

@@ -125,6 +150,11 @@ static void __init lager_add_standard_devices(void)
 	platform_device_register_resndata(&platform_bus, "sh_mmcif", 1,
 					  mmcif1_resources, ARRAY_SIZE(mmcif1_resources),
 					  &mmcif1_pdata, sizeof(mmcif1_pdata));
+
+	platform_device_register_resndata(&platform_bus, "r8a7790-ether", -1,
+					  ether_resources,
+					  ARRAY_SIZE(ether_resources),
+					  &ether_pdata, sizeof(ether_pdata));
 }
 
 static const char *lager_boards_compat_dt[] __initdata = {

Signature · 1 line

1.8.3.2

Kuninori Morimoto

2013-08-01 07:40 UTC #3 lore raw

PATCH v6 2/3 ARM: shmobile: lager: enable Ether

Hi Simon

arch/arm/mach-shmobile/board-lager.c static void __init lager_add_standard_devices(void)

Quoted 9 lines

arch/arm/mach-shmobile/board-lager.c +1 -0

@@ -114,6 +138,7 @@ static void __init lager_add_standard_devices(void)
 	r8a7790_pinmux_init();
 
 	r8a7790_add_standard_devices();
+
 	platform_device_register_data(&platform_bus, "leds-gpio", -1,
 				      &lager_leds_pdata,
 				      sizeof(lager_leds_pdata));

@@ -125,6 +150,11 @@ static void __init lager_add_standard_devices(void)

I guess above is not needed :)

Except above

Acked-by Kuninori Morimoto <[email protected]>

Best regards
---
Kuninori Morimoto

Simon Horman

2013-08-01 08:02 UTC #4 lore raw

PATCH v6 2/3 ARM: shmobile: lager: enable Ether

Quoted 6 lines · Kuninori Morimoto

Hi Simon
Quoted 3 lines
arch/arm/mach-shmobile/board-lager.c +0 -0
@@ -114,6 +138,7 @@ static void __init lager_add_standard_devices(void)
 	r8a7790_pinmux_init();
 

Quoted 8 lines

arch/arm/mach-shmobile/board-lager.c static void __init lager_add_standard_devices(void)
Quoted 6 lines
arch/arm/mach-shmobile/board-lager.c +1 -0
 	r8a7790_add_standard_devices();
+
 	platform_device_register_data(&platform_bus, "leds-gpio", -1,
 				      &lager_leds_pdata,
 				      sizeof(lager_leds_pdata));
@@ -125,6 +150,11 @@ static void __init lager_add_standard_devices(void)
I guess above is not needed :)

Thanks, I will fix that.

Quoted 3 lines

Except above
Acked-by Kuninori Morimoto <[email protected]>

Thanks.

Simon Horman

author

2013-07-30 09:09 UTC #5 lore raw

PATCH v6 3/3 ARM: shmobile: lager: enable nfsroot in DTS

In reply to Simon Horman

Now that Ether support has been added to the lager board it is possible to use nfsroot. This configuration is in line with that of other shmobile boards.

Cc Sergei Shtylyov <[email protected]>

Signed-off-by Simon Horman <[email protected]>

---

This patch has a run-time dependency on "ARM: shmobile: lager: enable Ether"

v2
* Split out as a new patch from "ARM: shmobile: lager: enable Ether"

---
 arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/r8a7790-lager.dts +1 -1

index 09a84fc..b2f61f0 100644
@@ -16,7 +16,7 @@
 	compatible = "renesas,lager", "renesas,r8a7790";
 
 	chosen {
-		bootargs = "console=ttySC6,115200 ignore_loglevel";
+		bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";
 	};
 
 	memory at 40000000 {

Signature · 1 line

1.8.3.2

Kuninori Morimoto

2013-08-01 07:46 UTC #6 lore raw

PATCH v6 3/3 ARM: shmobile: lager: enable nfsroot in DTS

Hi Simon

Quoted 6 lines

Now that Ether support has been added to the lager board it is possible to use nfsroot. This configuration is in line with that of other shmobile boards.
Cc Sergei Shtylyov <[email protected]>
Signed-off-by Simon Horman <[email protected]>

(snip)

arch/arm/boot/dts/r8a7790-lager.dts line 19

Quoted 3 lines

arch/arm/boot/dts/r8a7790-lager.dts +1 -1

 	chosen {
-		bootargs = "console=ttySC6,115200 ignore_loglevel";
+		bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";

Could you please add why this "rsize/wsize" settings are needed on bootargs ?
(other shmobile board's dts file doesn't have these)

And, I guess r8a7790-lager.dts/r8a7790.dts doesn't have "sh-eth" driver DT settings, (or I'm missing ?) but you added network/nfsroot settings on bootargs. It is OK for me, but for what ?

Best regards
---
Kuninori Morimoto

Simon Horman

2013-08-01 08:02 UTC #7 lore raw

PATCH v6 3/3 ARM: shmobile: lager: enable nfsroot in DTS

Quoted 18 lines · Kuninori Morimoto

Hi Simon
Quoted 6 lines
Now that Ether support has been added to the lager board it is possible to use nfsroot. This configuration is in line with that of other shmobile boards.
Cc Sergei Shtylyov <[email protected]>
Signed-off-by Simon Horman <[email protected]>
(snip)
arch/arm/boot/dts/r8a7790-lager.dts line 19
Quoted 3 lines
arch/arm/boot/dts/r8a7790-lager.dts +1 -1
 	chosen {
-		bootargs = "console=ttySC6,115200 ignore_loglevel";
+		bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";
Could you please add why this "rsize/wsize" settings are needed on bootargs ?
(other shmobile board's dts file doesn't have these)

Quoted 4 lines

And, I guess r8a7790-lager.dts/r8a7790.dts doesn't have "sh-eth" driver DT settings, (or I'm missing ?) but you added network/nfsroot settings on bootargs. It is OK for me, but for what ?

I think it is copy-paste noise.
I'll remove them.

Simon Horman

2013-08-06 01:07 UTC #8 lore raw

PATCH v6 3/3 ARM: shmobile: lager: enable nfsroot in DTS

Quoted 19 lines · Simon Horman

Quoted 18 lines · Kuninori Morimoto
Hi Simon
Quoted 6 lines
Now that Ether support has been added to the lager board it is possible to use nfsroot. This configuration is in line with that of other shmobile boards.
Cc Sergei Shtylyov <[email protected]>
Signed-off-by Simon Horman <[email protected]>
(snip)
arch/arm/boot/dts/r8a7790-lager.dts line 19
Quoted 3 lines
arch/arm/boot/dts/r8a7790-lager.dts +1 -1
 	chosen {
-		bootargs = "console=ttySC6,115200 ignore_loglevel";
+		bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";
Could you please add why this "rsize/wsize" settings are needed on bootargs ?
(other shmobile board's dts file doesn't have these)

Quoted 7 lines

Quoted 4 lines
And, I guess r8a7790-lager.dts/r8a7790.dts doesn't have "sh-eth" driver DT settings, (or I'm missing ?) but you added network/nfsroot settings on bootargs. It is OK for me, but for what ?
I think it is copy-paste noise.
I'll remove them.

To clarify:

The purpose of adding NFS information to bootargs in r8a7790-lager.dts is to cause the lager board to use NFS root when booting from using the C version of the board code which lives in board-lager.c. This is in contrast to the DT reverence version of the board code, which uses DT more heavily, does not initialise sh-eth because DT bindings are not available (as far as I know) and is not effected by r8a7790-lager.dts.

Historically this kind of NFS information was added to the command line in the defconfig. However, as part of the long journey to consolidate (reduce the number of) shmobile defconfigs it now goes in DT instead.

With regards to the "rsize/wsize" settings, I will remove them. However, I do see them present in the following files and I believe historically they were present in some of the shmobile defconfigs.

emev2-kzm9d-reference.dts
emev2-kzm9d.dts
r8a7740-armadillo800eva-reference.dts
r8a7740-armadillo800eva.dts

Kuninori Morimoto

2013-08-06 02:18 UTC #9 lore raw

PATCH v6 3/3 ARM: shmobile: lager: enable nfsroot in DTS

Hi Simon

Quoted 4 lines

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
arch/arm/boot/dts/r8a7790-lager.dts +1 -1
 	chosen {
-		bootargs = "console=ttySC6,115200 ignore_loglevel";
+		bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";

(snip)

Quoted 10 lines

The purpose of adding NFS information to bootargs in r8a7790-lager.dts is to cause the lager board to use NFS root when booting from using the C version of the board code which lives in board-lager.c. This is in contrast to the DT reverence version of the board code, which uses DT more heavily, does not initialise sh-eth because DT bindings are not available (as far as I know) and is not effected by r8a7790-lager.dts.
Historically this kind of NFS information was added to the command line in the defconfig. However, as part of the long journey to consolidate (reduce the number of) shmobile defconfigs it now goes in DT instead.

Thank you.
I don't have any objection to bootargs having NFS information. My question was only for "rsize/wsize".
Sorry for my confusion English.

Quoted 8 lines

With regards to the "rsize/wsize" settings, I will remove them. However, I do see them present in the following files and I believe historically they were present in some of the shmobile defconfigs.
emev2-kzm9d-reference.dts
emev2-kzm9d.dts
r8a7740-armadillo800eva-reference.dts
r8a7740-armadillo800eva.dts

I see.
I don't know why these defconfigs have "rsize/wsize".
But, this information was needed on old kernel version somehow (I forgot when, which version), and (I guess) there is no such issue now.
We can remove it ?

Best regards
---
Kuninori Morimoto

Simon Horman

2013-08-06 02:29 UTC #10 lore raw

PATCH v6 3/3 ARM: shmobile: lager: enable nfsroot in DTS

Quoted 33 lines · Kuninori Morimoto

Hi Simon
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
arch/arm/boot/dts/r8a7790-lager.dts +1 -1
 	chosen {
-		bootargs = "console=ttySC6,115200 ignore_loglevel";
+		bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";
(snip)
Quoted 10 lines
The purpose of adding NFS information to bootargs in r8a7790-lager.dts is to cause the lager board to use NFS root when booting from using the C version of the board code which lives in board-lager.c. This is in contrast to the DT reverence version of the board code, which uses DT more heavily, does not initialise sh-eth because DT bindings are not available (as far as I know) and is not effected by r8a7790-lager.dts.
Historically this kind of NFS information was added to the command line in the defconfig. However, as part of the long journey to consolidate (reduce the number of) shmobile defconfigs it now goes in DT instead.
Thank you.
I don't have any objection to bootargs having NFS information. My question was only for "rsize/wsize".
Sorry for my confusion English.
Quoted 8 lines
With regards to the "rsize/wsize" settings, I will remove them. However, I do see them present in the following files and I believe historically they were present in some of the shmobile defconfigs.
emev2-kzm9d-reference.dts
emev2-kzm9d.dts
r8a7740-armadillo800eva-reference.dts
r8a7740-armadillo800eva.dts

Quoted 5 lines

I see.
I don't know why these defconfigs have "rsize/wsize".
But, this information was needed on old kernel version somehow (I forgot when, which version), and (I guess) there is no such issue now.
We can remove it ?

Yes, I think we can remove it.
Would you like to make some patches?

Kuninori Morimoto

2013-08-06 02:58 UTC #11 lore raw

PATCH v6 3/3 ARM: shmobile: lager: enable nfsroot in DTS

Hi Simon

Quoted 2 lines

Yes, I think we can remove it.
Would you like to make some patches?

Yes, I can send patches.
But, I can't test emev2-kzm9d board.
Do you have it ?

Best regards
---
Kuninori Morimoto

Kuninori Morimoto

2013-08-06 03:15 UTC #12 lore raw

cover ARM: shmobile: remove nfsroot settings

Hi Simon

Quoted 3 lines

Yes, I can send patches.
But, I can't test emev2-kzm9d board.
Do you have it ?

These patches remove nfsroot settings from kzm9d/armadillo dts file. I tested #1 patch on Armadillo board, but I don't have kzm9d board.

Kuninori Morimoto (2):
ARM: shmobile: armadillo800eva: remove nfsroot settings from bootargs
ARM: shmobile: kzm9d: remove nfsroot settings from bootargs

 arch/arm/boot/dts/emev2-kzm9d-reference.dts        |    2 +-
 arch/arm/boot/dts/emev2-kzm9d.dts                  |    2 +-
 .../boot/dts/r8a7740-armadillo800eva-reference.dts |    2 +-
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts      |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Kuninori Morimoto

2013-08-06 03:17 UTC #13 lore raw

PATCH 1/2 ARM: shmobile: armadillo800eva: remove nfsroot settings from bootargs

NFS detail settings like "nfsroot=,rsize=4096,wsize=4096" are no longer needed

Signed-off-by Kuninori Morimoto <[email protected]>

---
 .../boot/dts/r8a7740-armadillo800eva-reference.dts |    2 +-
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts +1 -1

index 366f729..c638e4a 100644
@@ -17,7 +17,7 @@
 	compatible = "renesas,armadillo800eva-reference", "renesas,r8a7740";
 
 	chosen {
-		bootargs = "console=tty0 console=ttySC1,115200 earlyprintk=sh-sci.1,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";
+		bootargs = "console=tty0 console=ttySC1,115200 earlyprintk=sh-sci.1,115200 ignore_loglevel root=/dev/nfs ip=dhcp rw";
 	};
 
 	memory {

arch/arm/boot/dts/r8a7740-armadillo800eva.dts +1 -1

index 93da655..426cd9c 100644
@@ -16,7 +16,7 @@
 	compatible = "renesas,armadillo800eva";
 
 	chosen {
-		bootargs = "console=tty0 console=ttySC1,115200 earlyprintk=sh-sci.1,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096 rw";
+		bootargs = "console=tty0 console=ttySC1,115200 earlyprintk=sh-sci.1,115200 ignore_loglevel root=/dev/nfs ip=dhcp rw";
 	};
 
 	memory {

Signature · 1 line

1.7.9.5

Kuninori Morimoto

2013-08-06 03:17 UTC #14 lore raw

PATCH 2/2 ARM: shmobile: kzm9d: remove nfsroot settings from bootargs

In reply to Kuninori Morimoto

NFS detail settings like "nfsroot=,rsize=4096,wsize=4096" are no longer needed

Signed-off-by Kuninori Morimoto <[email protected]>

---
 arch/arm/boot/dts/emev2-kzm9d-reference.dts |    2 +-
 arch/arm/boot/dts/emev2-kzm9d.dts           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/emev2-kzm9d-reference.dts +1 -1

index bed676b..cceefda 100644
@@ -21,7 +21,7 @@
 	};
 
 	chosen {
-		bootargs = "console=ttyS1,115200n81 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096";
+		bootargs = "console=ttyS1,115200n81 ignore_loglevel root=/dev/nfs ip=dhcp";
 	};
 
 	reg_1p8v: regulator at 0 {

arch/arm/boot/dts/emev2-kzm9d.dts +1 -1

index dda13bc..f92e812 100644
@@ -21,6 +21,6 @@
 	};
 
 	chosen {
-		bootargs = "console=ttyS1,115200n81 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096";
+		bootargs = "console=ttyS1,115200n81 ignore_loglevel root=/dev/nfs ip=dhcp";
 	};
 };

Signature · 1 line

1.7.9.5

Kuninori Morimoto

2013-08-06 06:11 UTC #15 lore raw

cover ARM: shmobile: remove nfsroot settings

In reply to Kuninori Morimoto

Hi Simon again

Quoted 6 lines

Quoted 3 lines
Yes, I can send patches.
But, I can't test emev2-kzm9d board.
Do you have it ?
These patches remove nfsroot settings from kzm9d/armadillo dts file. I tested #1 patch on Armadillo board, but I don't have kzm9d board.

I could test kzm9d board on Magnus's environment.
It works well without "rsize/wsize"

Best regards
---
Kuninori Morimoto

Simon Horman

2013-08-06 08:23 UTC #16 lore raw

cover ARM: shmobile: remove nfsroot settings

Quoted 7 lines · Kuninori Morimoto

Hi Simon again
Quoted 4 lines
Quoted 3 lines
Yes, I can send patches.
But, I can't test emev2-kzm9d board.
Do you have it ?

Quoted 5 lines

Quoted 2 lines
These patches remove nfsroot settings from kzm9d/armadillo dts file. I tested #1 patch on Armadillo board, but I don't have kzm9d board.
I could test kzm9d board on Magnus's environment.
It works well without "rsize/wsize"

Thanks, I will test Armadillo.

Kuninori Morimoto

2013-08-06 08:26 UTC #17 lore raw

cover ARM: shmobile: remove nfsroot settings

Hi Simon

Quoted 11 lines

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Yes, I can send patches.
But, I can't test emev2-kzm9d board.
Do you have it ?
These patches remove nfsroot settings from kzm9d/armadillo dts file. I tested #1 patch on Armadillo board, but I don't have kzm9d board.
I could test kzm9d board on Magnus's environment.
It works well without "rsize/wsize"
Thanks, I will test Armadillo.

Thank you.
But I already tested it on Armadillo :)
It works well

Simon Horman

2013-08-06 08:37 UTC #18 lore raw

cover ARM: shmobile: remove nfsroot settings

Quoted 10 lines · Kuninori Morimoto

Hi Simon
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Yes, I can send patches.
But, I can't test emev2-kzm9d board.
Do you have it ?
These patches remove nfsroot settings from kzm9d/armadillo dts file. I tested #1 patch on Armadillo board, but I don't have kzm9d board.

Quoted 8 lines

Quoted 4 lines
Quoted 2 lines
I could test kzm9d board on Magnus's environment.
It works well without "rsize/wsize"
Thanks, I will test Armadillo.
Thank you.
But I already tested it on Armadillo :)
It works well

Great!

I will queue these changes up for v3.12 in the cleanup3 branch.

Simon Horman

2013-08-01 07:23 UTC #19 lore raw

v6 cover ARM: shmobile: lager: enable Ether

In reply to Simon Horman

Quoted 15 lines · Simon Horman

this short series enables the on-board ethernet
of the r8a7790 SoC for on lager board.
It has a run-time dependency on
"sh_eth: add support for r8a7790 SoC"
It has been built on top of renesas-next-20130726.
Changes noted in changelogs of individual patches.
Simon Horman (3):
ARM: shmobile: r8a7790: clocks for Ether support
ARM: shmobile: lager: enable Ether
ARM: shmobile: lager: enable nfsroot in DTS

Quoted 4 lines

 arch/arm/boot/dts/r8a7790-lager.dts    |  2 +-
 arch/arm/mach-shmobile/board-lager.c   | 30 ++++++++++++++++++++++++++++++
 arch/arm/mach-shmobile/clock-r8a7790.c |  4 ++++
 3 files changed, 35 insertions(+), 1 deletion(-)

Hi Magnus, Hi all,

I would appreciate some review of this, and if appropriate an Ack.