Skip to contentSkip to conversation

video: add L5F31188 TFT-LCD panel driver

PATCH New Hyungwon Hwang 3 participants 5 messages Jul 31, 2013 – Aug 1, 2013 Framebuffer layer

lore
Share & tools
lore

Hyungwon Hwang

author
#0 lore raw

PATCH 1/1 video: add L5F31188 TFT-LCD panel driver

This is u-boot driver for L5F31188 panel.

I've tested it in the board based on MIPI DSI with EXYNOS4 series, and it worked well.

Thanks,
Hyungwon Hwang

Signed-off-by Hyungwon Hwang <[email protected]>
Signed-off-by Donghwa Lee <[email protected]>
---
 drivers/video/Makefile   |    1 +
 drivers/video/l5f31188.c |  201 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 202 insertions(+)
 create mode 100644 drivers/video/l5f31188.c
drivers/video/Makefile +1 -0
index 68ff34b..997d041 100644
@@ -38,6 +38,7 @@ COBJS-$(CONFIG_FSL_DIU_FB) += fsl_diu_fb.o videomodes.o
 COBJS-$(CONFIG_MPC8XX_LCD) += mpc8xx_lcd.o
 COBJS-$(CONFIG_PXA_LCD) += pxa_lcd.o
 COBJS-$(CONFIG_S6E8AX0) += s6e8ax0.o
+COBJS-$(CONFIG_L5F31188) += l5f31188.o
 COBJS-$(CONFIG_S6E63D6) += s6e63d6.o
 COBJS-$(CONFIG_LD9040) += ld9040.o
 COBJS-$(CONFIG_SED156X) += sed156x.o
drivers/video/l5f31188.c new file +201 -0

201 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 video: add L5F31188 TFT-LCD panel driver

Hello Hyungwon

Am 31.07.2013 03:38, schrieb Hyungwon Hwang:

Quoted 36 lines

This is u-boot driver for L5F31188 panel.

I've tested it in the board based on MIPI DSI with EXYNOS4 series, and it worked well.

Thanks,
Hyungwon Hwang

Signed-off-by Hyungwon Hwang<[email protected]>
Signed-off-by Donghwa Lee<[email protected]>
---
  drivers/video/Makefile   |    1 +
  drivers/video/l5f31188.c |  201 ++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 202 insertions(+)

create mode 100644 drivers/video/l5f31188.c

drivers/video/Makefile +1 -0
index 68ff34b..997d041 100644
@@ -38,6 +38,7 @@ COBJS-$(CONFIG_FSL_DIU_FB) += fsl_diu_fb.o videomodes.o
  COBJS-$(CONFIG_MPC8XX_LCD) += mpc8xx_lcd.o
  COBJS-$(CONFIG_PXA_LCD) += pxa_lcd.o
  COBJS-$(CONFIG_S6E8AX0) += s6e8ax0.o
+COBJS-$(CONFIG_L5F31188) += l5f31188.o
  COBJS-$(CONFIG_S6E63D6) += s6e63d6.o
  COBJS-$(CONFIG_LD9040) += ld9040.o
  COBJS-$(CONFIG_SED156X) += sed156x.o
drivers/video/l5f31188.c new file +3 -0
new file mode 100644
index 0000000..a13be0b
@@ -0,0 +1,201 @@
+/*
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd. All rights reserved.
+ * Hyungwon Hwang<[email protected]>

drivers/video/l5f31188.c line 13

Quoted 10 lines
drivers/video/l5f31188.c new file +10 -0
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.

Please use for new files SPDX-License-Identifier, thanks.

Quoted 10 lines
drivers/video/l5f31188.c new file +10 -0
+ *
+ */
+
+#include<common.h>
+#include<asm/arch/mipi_dsim.h>
+
+#define SCAN_FROM_LEFT_TO_RIGHT 0
+#define SCAN_FROM_RIGHT_TO_LEFT 1
+#define SCAN_FROM_TOP_TO_BOTTOM 0
+#define SCAN_FROM_BOTTOM_TO_TOP 1

[...]

drivers/video/l5f31188.c line 188

Quoted 5 lines
drivers/video/l5f31188.c new file +5 -0
+static void l5f31188_display_enable(struct mipi_dsim_device *dev)
+{
+	struct mipi_dsim_master_ops *ops = dev->master_ops;
+	l5f31188_display_on(dev, ops);
+}

empty function?

drivers/video/l5f31188.c line 201

Quoted 13 lines
drivers/video/l5f31188.c new file +13 -0
+
+static struct mipi_dsim_lcd_driver l5f31188_dsim_ddi_driver = {
+	.name = "l5f31188",
+	.id = -1,
+
+	.mipi_panel_init = l5f31188_panel_init,
+	.mipi_display_on = l5f31188_display_enable,
+};
+
+void l5f31188_init(void)
+{
+	exynos_mipi_dsi_register_lcd_driver(&l5f31188_dsim_ddi_driver);
+}

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
author
#2 lore raw

PATCH 1/1 video: add L5F31188 TFT-LCD panel driver

Hello, Heiko.

I think that function l5f31188_display_enable() is needed to wrap up function l5f31188_display_on().

Function l5f31188_display_enable() is used as an interface to external side, especially to MIPI DSI driver. But function l5f31188_display_on() is used as an internal function in this driver.

Moreover, because they have different input argument types, it cannot be simply replacable.

Thank you for your reply.

Best regards,
Hyungwon Hwang

Quoted 89 lines · On Wed, 31 Jul 2013 08:03:28 +0200 Heiko Schocher <[email protected]> wrote:

Hello Hyungwon

Am 31.07.2013 03:38, schrieb Hyungwon Hwang:

Quoted 40 lines

This is u-boot driver for L5F31188 panel.

I've tested it in the board based on MIPI DSI with EXYNOS4 series, and it worked well.

Thanks,
Hyungwon Hwang

Signed-off-by Hyungwon Hwang<[email protected]>
Signed-off-by Donghwa Lee<[email protected]>
---
  drivers/video/Makefile   |    1 +
  drivers/video/l5f31188.c |  201

++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 202 insertions(+) create mode 100644 drivers/video/l5f31188.c

drivers/video/Makefile +0 -0
index 68ff34b..997d041 100644
@@ -38,6 +38,7 @@ COBJS-$(CONFIG_FSL_DIU_FB) += fsl_diu_fb.o

videomodes.o COBJS-$(CONFIG_MPC8XX_LCD) += mpc8xx_lcd.o
COBJS-$(CONFIG_PXA_LCD) += pxa_lcd.o COBJS-$(CONFIG_S6E8AX0) += s6e8ax0.o

drivers/video/Makefile +1 -0
+COBJS-$(CONFIG_L5F31188) += l5f31188.o
  COBJS-$(CONFIG_S6E63D6) += s6e63d6.o
  COBJS-$(CONFIG_LD9040) += ld9040.o
  COBJS-$(CONFIG_SED156X) += sed156x.o
drivers/video/l5f31188.c new file +2 -0
new file mode 100644
index 0000000..a13be0b
@@ -0,0 +1,201 @@
+/*
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd. All rights

reserved.
+ * Hyungwon Hwang<[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or

Quoted 8 lines

+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.

Please use for new files SPDX-License-Identifier, thanks.

Quoted 10 lines

+ *
+ */

drivers/video/l5f31188.c new file +8 -0
+
+#include<common.h>
+#include<asm/arch/mipi_dsim.h>
+
+#define SCAN_FROM_LEFT_TO_RIGHT 0
+#define SCAN_FROM_RIGHT_TO_LEFT 1
+#define SCAN_FROM_TOP_TO_BOTTOM 0
+#define SCAN_FROM_BOTTOM_TO_TOP 1

[...]

drivers/video/l5f31188.c line 188

Quoted 5 lines
drivers/video/l5f31188.c new file +5 -0
+static void l5f31188_display_enable(struct mipi_dsim_device *dev)
+{
+	struct mipi_dsim_master_ops *ops = dev->master_ops;
+	l5f31188_display_on(dev, ops);
+}

empty function?

Quoted 12 lines
drivers/video/l5f31188.c new file +12 -0
+
+static struct mipi_dsim_lcd_driver l5f31188_dsim_ddi_driver = {
+	.name = "l5f31188",
+	.id = -1,
+
+	.mipi_panel_init = l5f31188_panel_init,
+	.mipi_display_on = l5f31188_display_enable,
+};
+
+void l5f31188_init(void)
+{
+
Quoted 1 line

exynos_mipi_dsi_register_lcd_driver(&l5f31188_dsim_ddi_driver); +}

bye,
Heiko

#3 lore raw

PATCH 1/1 video: add L5F31188 TFT-LCD panel driver

Dear Hyungwon Hwang.

Quoted 9 lines · Hyungwon Hwang

Hello, Heiko.

I think that function l5f31188_display_enable() is needed to wrap up function l5f31188_display_on().

Function l5f31188_display_enable() is used as an interface to external side, especially to MIPI DSI driver. But function l5f31188_display_on() is used as an internal function in this driver.

Moreover, because they have different input argument types, it cannot be simply replacable.

Thank you for your reply.

please don't top posting.
I think you need this link.
(http://www.denx.de/wiki/U-Boot/Patches)
please read it carefully.

welcome to join us.

Thanks,
Minkyu Kang.

author
#4 lore raw

PATCH 1/1 video: add L5F31188 TFT-LCD panel driver

To heiko and minkyu,

I'm very sorry. It was my first time to contribute my code to open-source community, and it was my mistake not to be familiar with the convention in this community. I read the article in the link which minkyu sent me. It was very helpful. Thank you.

I'll be more careful next time. I wanna say thank you for our replies from all of you, again.

Sincerely,
Hyungwon Hwang

Quoted 28 lines · On Wed, 31 Jul 2013 19:26:04 +0900 Minkyu Kang <[email protected]> wrote:

Dear Hyungwon Hwang.

Quoted 10 lines · Hyungwon Hwang

Hello, Heiko.

I think that function l5f31188_display_enable() is needed to wrap up function l5f31188_display_on().

Function l5f31188_display_enable() is used as an interface to external side, especially to MIPI DSI driver. But function l5f31188_display_on() is used as an internal function in this driver.

Quoted 4 lines

Moreover, because they have different input argument types, it cannot be simply replacable.

Thank you for your reply.

please don't top posting.
I think you need this link.
(http://www.denx.de/wiki/U-Boot/Patches)
please read it carefully.

welcome to join us.

Thanks,
Minkyu Kang.