Skip to contentSkip to conversation

Install DTB as part of images install command

PATCH New Reuben Dowle 4 participants 6 messages Mar 27, 2013 – Aug 1, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Install DTB as part of images install command

From: Reuben Dowle <[email protected]>

When installing DTB to the images directory, do this as part of the image install commands rather than the target install commands.

---
 linux/linux.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/linux.mk +1 -1
index 8a73767..f0d793b 100644
@@ -261,11 +261,11 @@ endef
 
 define LINUX_INSTALL_IMAGES_CMDS
        cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+       $(LINUX_INSTALL_DTB)
 endef
 
 define LINUX_INSTALL_TARGET_CMDS
        $(LINUX_INSTALL_KERNEL_IMAGE_TO_TARGET)
-       $(LINUX_INSTALL_DTB)
        # Install modules and remove symbolic links pointing to build
        # directories, not relevant on the target
        @if grep -q "CONFIG_MODULES=y" $(@D)/.config; then      \

--
1.7.10.4

The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).

#1 lore raw

PATCH 1/1 Install DTB as part of images install command

Quoted 6 lines · Reuben Dowle

From: Reuben Dowle <[email protected]>

When installing DTB to the images directory, do this as part of the image install commands rather than the target install commands.

(untested)

linux/linux.mk endef · line 264

Quoted 13 lines
---
  linux/linux.mk |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
linux/linux.mk +1 -0
index 8a73767..f0d793b 100644
@@ -261,11 +261,11 @@ endef
 
  define LINUX_INSTALL_IMAGES_CMDS
         cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+       $(LINUX_INSTALL_DTB)

I prefer the indentation to be with a tab, but since the original has
spaces it's OK.

Regards,
Arnout

Quoted 17 lines
linux/linux.mk +0 -2
  endef
 
  define LINUX_INSTALL_TARGET_CMDS
         $(LINUX_INSTALL_KERNEL_IMAGE_TO_TARGET)
-       $(LINUX_INSTALL_DTB)
         # Install modules and remove symbolic links pointing to build
         # directories, not relevant on the target
         @if grep -q "CONFIG_MODULES=y" $(@D)/.config; then      \
--

1.7.10.4

The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 Install DTB as part of images install command

Quoted 7 lines · Arnout Vandecappelle
Quoted 4 lines

define LINUX_INSTALL_IMAGES_CMDS

         cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)

+ $(LINUX_INSTALL_DTB)

I prefer the indentation to be with a tab, but since the original has
spaces it's OK.

Scratch that, the patch is whitespace-modified and doesn't apply (the
original _does_ have tabs). Could you resend with git send-email?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 Install DTB as part of images install command

Sorry about that. It looks like my corporate mail server has replaced the tabs with spaces when it inserted the corporate warning. The email in my sent items definitely had the tabs. I will try and figure a better way to send it.

Reuben

Quoted 24 lines

-----Original Message-----
From: Arnout Vandecappelle [mailto:arnout at mind.be]
Sent: Friday, 5 April 2013 12:38 a.m.
To: Arnout Vandecappelle
Cc: Reuben Dowle; buildroot at busybox.net
Subject: Re: [Buildroot] [PATCH] Install DTB as part of images install command

Quoted 6 lines · Arnout Vandecappelle
Quoted 4 lines

define LINUX_INSTALL_IMAGES_CMDS

         cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)

+ $(LINUX_INSTALL_DTB)

I prefer the indentation to be with a tab, but since the original

has

Quoted 1 line

spaces it's OK.

Scratch that, the patch is whitespace-modified and doesn't apply (the
original _does_ have tabs). Could you resend with git send-email?

Regards,
Arnout

Quoted 7 lines

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).

#4 lore raw

PATCH 1/1 Install DTB as part of images install command

In reply to Reuben Dowle

Hi,

Quoted 4 lines · Reuben Dowle

From: Reuben Dowle <[email protected]>

When installing DTB to the images directory, do this as part of the image install commands rather than the target install commands.

Peter, could you apply this patch?

Maxime

Signature · 3 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 Install DTB as part of images install command

In reply to Reuben Dowle

Dear Reuben Dowle,

Quoted 9 lines · Reuben Dowle

From: Reuben Dowle <[email protected]>

When installing DTB to the images directory, do this as part of the image install commands rather than the target install commands.

---
 linux/linux.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com