MFD: ucb1x00-core: add CONFIG_PM_SLEEP to suspend/resume
PATCH 1/1 MFD: ucb1x00-core: add CONFIG_PM_SLEEP to suspend/resume
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the build warnings when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled.
drivers/mfd/ucb1x00-core.c:672:12: warning: 'ucb1x00_suspend' defined but not used [-Wunused-function] drivers/mfd/ucb1x00-core.c:704:12: warning: 'ucb1x00_resume' defined but not used [-Wunused-function]
--- drivers/mfd/ucb1x00-core.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/mfd/ucb1x00-core.c +2 -0
@@ -669,6 +669,7 @@ void ucb1x00_unregister_driver(struct ucb1x00_driver *drv)mutex_unlock (&ucb1x00_mutex); } +#ifdef CONFIG_PM_SLEEP static int ucb1x00_suspend (struct device *dev) {struct ucb1x00_plat_data *pdata = dev->platform_data;
@@ -736,6 +737,7 @@ static int ucb1x00_resume(struct device *dev)mutex_unlock (&ucb1x00_mutex);return 0 ; } +#endif static const struct dev_pm_ops ucb1x00_pm_ops = {SET_SYSTEM_SLEEP_PM_OPS (ucb1x00_suspend, ucb1x00_resume)
Signature · 1 line
1.7.10.4
Quoted 5 lines · Jingoo Han
Add
CONFIG_PM_SLEEPto suspend/resume functions to fix the build warnings whenCONFIG_PM_SLEEPis not selected. This is because sleep PM callbacks defined bySET_SYSTEM_SLEEP_PM_OPSare only used when theCONFIG_PM_SLEEPis enabled.
Quoted 7 lines
drivers/mfd/ucb1x00-core.c:672:12: warning: 'ucb1x00_suspend' defined but not used [-Wunused-function]drivers/mfd/ucb1x00-core.c:704:12: warning: 'ucb1x00_resume' defined but not used [-Wunused-function]Signed-off-by Jingoo Han <[email protected]>--- drivers/mfd/ucb1x00-core.c | 2 ++ 1 file changed, 2 insertions(+)
Looks fine to me. Applied, thanks.
Signature · 4 lines
Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog