Skip to contentSkip to conversation

radeon: si_dpm.c: avoid a signed 64-bit divide

PATCH In review Kyle McMartin 2 participants 3 messages Aug 2, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 radeon: si_dpm.c: avoid a signed 64-bit divide

Hit a compile failure here referencing divdi3 on i686.

drivers/gpu/drm/radeon/si_dpm.c +1 -1
@@ -1767,7 +1767,7 @@ static void si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe
 	s64 temperature, t_slope, t_intercept, av, bv, t_ref;
 	s64 tmp;
 
-	i_leakage = drm_int2fixp(ileakage) / 100;
+	i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
 	vddc = div64_s64(drm_int2fixp(v), 1000);
 	temperature = div64_s64(drm_int2fixp(t), 1000);
#1 lore raw

The fix is already queued in my tree:
http://lists.freedesktop.org/archives/dri-devel/2013-August/042668.html

Quoted 24 lines

-----Original Message-----
From: Kyle McMartin [mailto:[email protected]]
Sent: Friday, August 02, 2013 1:13 PM
To: [email protected]
Cc: Deucher, Alexander; [email protected]; dri- [email protected]; [email protected]
Subject: [PATCH] radeon: si_dpm.c: avoid a signed 64-bit divide

Hit a compile failure here referencing divdi3 on i686.

drivers/gpu/drm/radeon/si_dpm.c +0 -0
@@ -1767,7 +1767,7 @@ static void

si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe

drivers/gpu/drm/radeon/si_dpm.c +1 -1
 	s64 temperature, t_slope, t_intercept, av, bv, t_ref;
 	s64 tmp;
 
-	i_leakage = drm_int2fixp(ileakage) / 100;
+	i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
 	vddc = div64_s64(drm_int2fixp(v), 1000);
 	temperature = div64_s64(drm_int2fixp(t), 1000);