Skip to contentSkip to conversation

bridge: fix rcu check warning in multicast port group

PATCH Applied Stephen Hemminger 2 participants 2 messages Aug 5, 2013

Subsystems (3)
Networking Network drivers Ethernet bridge
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 bridge: fix rcu check warning in multicast port group

Use of RCU here with out marked pointer and function doesn't match prototype with sparse.

Signed-off-by Stephen Hemminger <[email protected]>
net/bridge/br_mdb.c +2 -1
@@ -61,7 +61,8 @@ static int br_mdb_fill_info(struct sk_bu
 
 	for (i = 0; i < mdb->max; i++) {
 		struct net_bridge_mdb_entry *mp;
-		struct net_bridge_port_group *p, **pp;
+		struct net_bridge_port_group *p;
+		struct net_bridge_port_group __rcu **pp;
 		struct net_bridge_port *port;
 
 		hlist_for_each_entry_rcu(mp, &mdb->mhash[i], hlist[mdb->ver]) {
net/bridge/br_private.h +1 -1
@@ -466,7 +466,7 @@ extern void br_multicast_free_pg(struct
 extern struct net_bridge_port_group *br_multicast_new_port_group(
 				struct net_bridge_port *port,
 				struct br_ip *group,
-				struct net_bridge_port_group *next,
+				struct net_bridge_port_group __rcu *next,
 				unsigned char state);
 extern void br_mdb_init(void);
 extern void br_mdb_uninit(void);