Skip to contentSkip to conversation

ARM: STi: SMP related fixes.

PATCH New Srinivas KANDAGATLA 2 participants 4 messages Aug 1, 2013 – Aug 4, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover ARM: STi: SMP related fixes.

From: Srinivas Kandagatla <[email protected]>

Hi Anrd/Olof,
These two patches fix a critical SMP issue with STi SOCs. Without this patches STi SoCs will boot only single core and crashes after freeing the init.

Can you please consider these patches.

Thanks,
srini

Srinivas Kandagatla (2):
ARM: STi: Fix cpu nodes with correct device_type.
ARM: STi: remove sti_secondary_start from INIT section.

 arch/arm/boot/dts/stih41x.dtsi |    2 ++
 arch/arm/mach-sti/headsmp.S    |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.6.5
#1 lore raw

PATCH 1/2 ARM: STi: Fix cpu nodes with correct device_type.

From: Srinivas Kandagatla <[email protected]>

This patch fixes cpu nodes with device_type = "cpu". This change was not necessary before 3.10-rc7.
Without this patch STi SOCs does not boot as SMP.

---
 arch/arm/boot/dts/stih41x.dtsi |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/boot/dts/stih41x.dtsi +2 -0
index 7321403..f5b9898 100644
@@ -6,10 +6,12 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		cpu at 0 {
+			device_type = "cpu";
 			compatible = "arm,cortex-a9";
 			reg = <0>;
 		};
 		cpu at 1 {
+			device_type = "cpu";
 			compatible = "arm,cortex-a9";
 			reg = <1>;
 		};
Signature · 1 line
1.7.6.5
#2 lore raw

PATCH 2/2 ARM: STi: remove sti_secondary_start from INIT section.

In reply to Srinivas KANDAGATLA

From: Srinivas Kandagatla <[email protected]>

This patch removes sti_secondary_start from _INIT section, there are 2 reason for this removal.
1. discarding such a small code does not save much, given the RAM
sizes.
2. Having this code discarded, creates corruption issue when we boot
smp-kernel with nrcpus=1 or with single cpu node in DT.

---
 arch/arm/mach-sti/headsmp.S |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mach-sti/headsmp.S +0 -2
index 78ebc75..4c09bae 100644
@@ -16,8 +16,6 @@
 #include <linux/linkage.h>
 #include <linux/init.h>
 
-	__INIT
-
 /*
  * ST specific entry point for secondary CPUs.  This provides
  * a "holding pen" into which all secondary cores are held until we're
Signature · 1 line
1.7.6.5
#3 lore raw

cover ARM: STi: SMP related fixes.

In reply to Srinivas KANDAGATLA
Quoted 5 lines · Srinivas KANDAGATLA

From: Srinivas Kandagatla <[email protected]>

Hi Anrd/Olof,
These two patches fix a critical SMP issue with STi SOCs. Without this patches STi SoCs will boot only single core and crashes after freeing the init.

Applied both for 3.11-rc. Thanks.

-Olof