Skip to contentSkip to conversation

leds-lp5523: Broken commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0

DISCUSSION Pali Rohár 3 participants 4 messages Aug 5, 2013

lore
Share & tools
lore
#0 lore raw

Hello,

git commit "leds-lp5523: use generic firmware interface" db6eaf8388a413a5ee1b4547ce78506b9c6456b0 introduced in kernel 3.10 changed user space API for modifing lp5523 led patterns via /sys.

Before this commit there were sysfs attributes engineX_mode, engineX_load and engineX_leds (for every engine X).

Now (after commit) there are sysfs attributes: select_engine, loading and data (see: 10c06d178df11b0b2b746321a80ea14241997127 for description). Old sysfs attributes were removed.

So commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 totally broke all existing userspace applications which use lp5523 leds.

This also broke application MCE which is used on Nokia N900 phone for changing LED patterns in lp5523 led.

I think that kernel api which is used by userspace applications (like attributes in /sys) should not be changed in way that totally broke existing applications.

Can you fix this api problem? (maybe adding old sysfs attributes which would call new api function...)

Signature · 2 lines
Pali Rohár
[email protected]
#1 lore raw
Quoted 13 lines

Hello,

git commit "leds-lp5523: use generic firmware interface" db6eaf8388a413a5ee1b4547ce78506b9c6456b0 introduced in kernel 3.10 changed user space API for modifing lp5523 led patterns via /sys.

Before this commit there were sysfs attributes engineX_mode, engineX_load and engineX_leds (for every engine X).

Now (after commit) there are sysfs attributes: select_engine, loading and data (see: 10c06d178df11b0b2b746321a80ea14241997127
for description). Old sysfs attributes were removed.

Quoted 5 lines

So commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 totally broke all existing userspace applications which use lp5523 leds.

This also broke application MCE which is used on Nokia N900 phone for changing LED patterns in lp5523 led.

First of all, I'm really sorry for this conflict.

Quoted 7 lines

I think that kernel api which is used by userspace applications (like attributes in /sys) should not be changed in way that totally broke existing applications.

Can you fix this api problem? (maybe adding old sysfs attributes which would call new api function...)

I'll recover old sysfs attributes and implement them by using new functions. Additionally, I'll do same works in LP5521 driver also.

Best Regards,
Milo ���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�

#2 lore raw
Quoted 31 lines · Milo
Quoted 15 lines

Hello,

git commit "leds-lp5523: use generic firmware interface" db6eaf8388a413a5ee1b4547ce78506b9c6456b0 introduced in kernel 3.10 changed user space API for modifing lp5523 led patterns via /sys.

Before this commit there were sysfs attributes engineX_mode, engineX_load and engineX_leds (for every engine X).

Now (after commit) there are sysfs attributes:
select_engine, loading and data (see:
10c06d178df11b0b2b746321a80ea14241997127 for description). Old sysfs attributes were removed.

Quoted 6 lines

So commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 totally broke all existing userspace applications which use lp5523 leds.

This also broke application MCE which is used on Nokia N900 phone for changing LED patterns in lp5523 led.

First of all, I'm really sorry for this conflict.

Quoted 6 lines

I think that kernel api which is used by userspace applications (like attributes in /sys) should not be changed in way that totally broke existing applications.

Can you fix this api problem? (maybe adding old sysfs attributes which would call new api function...)

Quoted 6 lines

I'll recover old sysfs attributes and implement them by using new functions. Additionally, I'll do same works in LP5521 driver also.

Best Regards,
Milo

Hi, thank you very much!

Signature · 2 lines
Pali Rohár
[email protected]
#3 lore raw
Quoted 32 lines · Pali Rohár
Quoted 31 lines · Milo
Quoted 15 lines

Hello,

git commit "leds-lp5523: use generic firmware interface" db6eaf8388a413a5ee1b4547ce78506b9c6456b0 introduced in kernel 3.10 changed user space API for modifing lp5523 led patterns via /sys.

Before this commit there were sysfs attributes engineX_mode, engineX_load and engineX_leds (for every engine X).

Now (after commit) there are sysfs attributes:
select_engine, loading and data (see:
10c06d178df11b0b2b746321a80ea14241997127 for description). Old sysfs attributes were removed.

Quoted 6 lines

So commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0 totally broke all existing userspace applications which use lp5523 leds.

This also broke application MCE which is used on Nokia N900 phone for changing LED patterns in lp5523 led.

First of all, I'm really sorry for this conflict.

Quoted 6 lines

I think that kernel api which is used by userspace applications (like attributes in /sys) should not be changed in way that totally broke existing applications.

Can you fix this api problem? (maybe adding old sysfs attributes which would call new api function...)

Quoted 9 lines
Quoted 6 lines

I'll recover old sysfs attributes and implement them by using new functions. Additionally, I'll do same works in LP5521 driver also.

Best Regards,
Milo

Hi, thank you very much!

Also my bad, I should noticed that and keep those old APIs at that moment. Thanks for reporting this. I think Milo is going to fix it and I probably pull this fix into 3.11 cycle instead of next merge window.

-Bryan