Skip to contentSkip to conversation

ARM: ux500: Remove '0x's from HREF v60+ DTS file

PATCH Applied Lee Jones 15 participants 70 messages Jul 22, 2013 – Sep 19, 2013

Subsystems (4)
lore
Share & tools
lore

Lee Jones

author
#0 lore raw

PATCH 1/22 ARM: ux500: Remove '0x's from HREF v60+ DTS file

---
 arch/arm/boot/dts/hrefv60plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/hrefv60plus.dts +1 -1
index 3d580d6..46fd8af 100644
@@ -26,7 +26,7 @@
 
 	soc {
 		i2c at 80110000 {
-			bu21013_tp at 0x5c {
+			bu21013_tp at 5c {
 				reset-gpio = <&gpio4 15 0x4>;
 			};
 		};
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 2/22 ARM: nomadik: Remove '0x's from nomadik stn8815 DTS file

---
 arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/ste-nomadik-stn8815.dtsi +2 -2
index a3acfa7..c2ee51e 100644
@@ -742,14 +742,14 @@
 		#size-cells = <1>;
 		ranges;
 
-		vica: intc at 0x10140000 {
+		vica: intc at 10140000 {
 			compatible = "arm,versatile-vic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
 			reg = <0x10140000 0x20>;
 		};
 
-		vicb: intc at 0x10140020 {
+		vicb: intc at 10140020 {
 			compatible = "arm,versatile-vic";
 			interrupt-controller;
 			#interrupt-cells = <1>;
Signature · 1 line
1.8.1.2
author
#3 lore raw

PATCH 3/22 ARM: u300: Remove '0x's from U300 DTS file

In reply to Lee Jones
---
 arch/arm/boot/dts/ste-u300.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/ste-u300.dts +3 -3
index 8a1032c..a9da480 100644
@@ -307,7 +307,7 @@
 		clocks = <&i2c0_clk>;
 		#address-cells = <1>;
 		#size-cells = <0>;
-		ab3100: ab3100 at 0x48 {
+		ab3100: ab3100 at 48 {
 			compatible = "stericsson,ab3100";
 			reg = <0x48>;
 			interrupt-parent = <&vica>;
@@ -385,10 +385,10 @@
 		clocks = <&i2c1_clk>;
 		#address-cells = <1>;
 		#size-cells = <0>;
-		fwcam0: fwcam at 0x10 {
+		fwcam0: fwcam at 10 {
 			reg = <0x10>;
 		};
-		fwcam1: fwcam at 0x5d {
+		fwcam1: fwcam at 5d {
 			reg = <0x5d>;
 		};
 	};
Signature · 1 line
1.8.1.2
author
#5 lore raw

PATCH 4/22 ARM: at91: dt: Remove '0x's from Animeo IP DTS file

In reply to Lee Jones
Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Nicolas Ferre <[email protected]>
---
 arch/arm/boot/dts/animeo_ip.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/animeo_ip.dts +1 -1
index 3a1de9e..4cb0342 100644
@@ -105,7 +105,7 @@
 				reg = <0x48000 0x8000>;
 			};
 
-			user_block at 0x50000 {
+			user_block at 50000 {
 				label = "user_block";
 				reg = <0x50000 0xb0000>;
 			};
Signature · 1 line
1.8.1.2
#6 lore raw

Re: [PATCH 04/22] ARM: at91: dt: Remove '0x's from Animeo IP DTS file

Quoted 2 lines · Lee Jones
Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Nicolas Ferre <[email protected]>
Quoted 21 lines
---
 arch/arm/boot/dts/animeo_ip.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/animeo_ip.dts +1 -1
index 3a1de9e..4cb0342 100644
@@ -105,7 +105,7 @@
 				reg = <0x48000 0x8000>;
 			};
 
-			user_block@0x50000 {
+			user_block@50000 {
 				label = "user_block";
 				reg = <0x50000 0xb0000>;
 			};
Signature · 1 line
1.8.1.2
author
#7 lore raw

Re: [PATCH 04/22] ARM: at91: dt: Remove '0x's from Animeo IP DTS file

Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 2 lines · Lee Jones
Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Cc Nicolas Ferre <[email protected]>

Thanks Jean-Christophe.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#8 lore raw

PATCH 5/22 ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

In reply to Lee Jones
Cc Christian Daudt <[email protected]>
---
 arch/arm/boot/dts/bcm11351-brt.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/bcm11351-brt.dts +3 -3
index 67ec524..fdace5d 100644
@@ -27,18 +27,18 @@
 		status = "okay";
 	};
 
-	sdio0: sdio at 0x3f180000 {
+	sdio0: sdio at 3f180000 {
 		max-frequency = <48000000>;
 		status = "okay";
 	};
 
-	sdio1: sdio at 0x3f190000 {
+	sdio1: sdio at 3f190000 {
 		non-removable;
 		max-frequency = <48000000>;
 		status = "okay";
 	};
 
-	sdio3: sdio at 0x3f1b0000 {
+	sdio3: sdio at 3f1b0000 {
 		max-frequency = <48000000>;
 		status = "okay";
 	};
Signature · 1 line
1.8.1.2
#9 lore raw

Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

Quoted 22 lines · Lee Jones
Cc Christian Daudt <[email protected]>
---
  arch/arm/boot/dts/bcm11351-brt.dts | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/bcm11351-brt.dts +2 -2
index 67ec524..fdace5d 100644
@@ -27,18 +27,18 @@
  		status = "okay";
  	};
 
-	sdio0: sdio at 0x3f180000 {
+	sdio0: sdio at 3f180000 {
  		max-frequency = <48000000>;
  		status = "okay";
  	};
 
-	sdio1: sdio at 0x3f190000 {
+	sdio1: sdio at 3f190000 {

arch/arm/boot/dts/bcm11351-brt.dts line 44

Quoted 10 lines
arch/arm/boot/dts/bcm11351-brt.dts +1 -1
  		non-removable;
  		max-frequency = <48000000>;
  		status = "okay";
  	};
 
-	sdio3: sdio at 0x3f1b0000 {
+	sdio3: sdio at 3f1b0000 {
  		max-frequency = <48000000>;
  		status = "okay";
  	};

Hi Lee,
Is this convention documented ? Someone called my attention to the
fact that this dts files was inconsistent in its use of 0x in names, but I was not aware of a coding guideline for this.

Thanks,
csd

author
#10 lore raw

Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

Quoted 26 lines · Christian Daudt
Quoted 25 lines · Lee Jones
Cc Christian Daudt <[email protected]>
---
 arch/arm/boot/dts/bcm11351-brt.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/bcm11351-brt.dts +2 -3
index 67ec524..fdace5d 100644
@@ -27,18 +27,18 @@
 		status = "okay";
 	};
-	sdio0: sdio at 0x3f180000 {
+	sdio0: sdio at 3f180000 {
 		max-frequency = <48000000>;
 		status = "okay";
 	};
-	sdio1: sdio at 0x3f190000 {
+	sdio1: sdio at 3f190000 {
 		non-removable;
 		max-frequency = <48000000>;
 		status = "okay";
 	};
-	sdio3: sdio at 0x3f1b0000 {
Quoted 8 lines

arch/arm/boot/dts/bcm11351-brt.dts line 44

Quoted 4 lines
arch/arm/boot/dts/bcm11351-brt.dts +1 -0
+	sdio3: sdio at 3f1b0000 {
 		max-frequency = <48000000>;
 		status = "okay";
 	};

Hi Lee,
Is this convention documented ? Someone called my attention to the
fact that this dts files was inconsistent in its use of 0x in names, but I was not aware of a coding guideline for this.

The best two places I can think of are:

Documentation/devicetree/usage-model.txt
and
http://www.devicetree.org/Device_Tree_Usage

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#11 lore raw

Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

Quoted 37 lines · Lee Jones
Quoted 26 lines · Christian Daudt
Quoted 25 lines · Lee Jones
Cc Christian Daudt <[email protected]>
---
  arch/arm/boot/dts/bcm11351-brt.dts | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/bcm11351-brt.dts +2 -3
index 67ec524..fdace5d 100644
@@ -27,18 +27,18 @@
  		status = "okay";
  	};
-	sdio0: sdio at 0x3f180000 {
+	sdio0: sdio at 3f180000 {
  		max-frequency = <48000000>;
  		status = "okay";
  	};
-	sdio1: sdio at 0x3f190000 {
+	sdio1: sdio at 3f190000 {
  		non-removable;
  		max-frequency = <48000000>;
  		status = "okay";
  	};
-	sdio3: sdio at 0x3f1b0000 {
Quoted 8 lines

arch/arm/boot/dts/bcm11351-brt.dts line 44

Quoted 4 lines
arch/arm/boot/dts/bcm11351-brt.dts +1 -0
+	sdio3: sdio at 3f1b0000 {
  		max-frequency = <48000000>;
  		status = "okay";
  	};

Hi Lee,
Is this convention documented ? Someone called my attention to the
fact that this dts files was inconsistent in its use of 0x in names, but I was not aware of a coding guideline for this.

Quoted 5 lines

The best two places I can think of are:

Documentation/devicetree/usage-model.txt
and
http://www.devicetree.org/Device_Tree_Usage

And even those do not stick to a single convention, but that is what can be expected of a twiki page :-p

Regards,
Arend

#12 lore raw

Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

Quoted 39 lines · Arend van Spriel
Quoted 38 lines · Lee Jones
Quoted 35 lines · Christian Daudt
Quoted 20 lines · Lee Jones
Cc Christian Daudt <[email protected]>
---
  arch/arm/boot/dts/bcm11351-brt.dts | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/bcm11351-brt.dts +1 -2
index 67ec524..fdace5d 100644
@@ -27,18 +27,18 @@
          status = "okay";
      };
-    sdio0: sdio at 0x3f180000 {
+    sdio0: sdio at 3f180000 {
          max-frequency = <48000000>;
          status = "okay";
      };
-    sdio1: sdio at 0x3f190000 {

arch/arm/boot/dts/bcm11351-brt.dts line 41

Quoted 10 lines
arch/arm/boot/dts/bcm11351-brt.dts +2 -1
+    sdio1: sdio at 3f190000 {
          non-removable;
          max-frequency = <48000000>;
          status = "okay";
      };
-    sdio3: sdio at 0x3f1b0000 {
+    sdio3: sdio at 3f1b0000 {
          max-frequency = <48000000>;
          status = "okay";
      };

Hi Lee,
Is this convention documented ? Someone called my attention to the
fact that this dts files was inconsistent in its use of 0x in names, but I was not aware of a coding guideline for this.

Quoted 8 lines
Quoted 5 lines

The best two places I can think of are:

Documentation/devicetree/usage-model.txt
and
http://www.devicetree.org/Device_Tree_Usage

And even those do not stick to a single convention, but that is what can be expected of a twiki page :-p

[take 2 with in plain text]

Agreed. Quick search shows the following example on that page:

         pci at 0x10180000 {
             compatible = "arm,versatile-pci-hostbridge", "pci";
             reg = <0x10180000 0x1000>;
             interrupts = <8 0>;
             bus-ranges = <0 0>;
         };

though it is the minority in the examples, ultimately having more examples following one convention than the other does not a standard make :) While I like this just for the consistency, it'd be nice to have something to point people to as this being the best practice for kernel dev. It would be good to have a DeviceTreeGuidelines along the lines of the CodingGuidelines file in the kernel tree itself, to get some consistency on this.

Thanks,
csd

#14 lore raw

Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

Quoted 9 lines · Tim Kryger
Quoted 2 lines · Christian Daudt

it'd be nice to have something to point
people to as this being the best practice for kernel dev.

Power.org's ePAPR exclusively omits the 0x in the unit-address of node names.

https://www.power.org/wp-content/uploads/2012/06/Power_ePAPR_APPROVED_v1.1.pdf

Thanks for the link. While browsing on power.org I got the impression that I needed to have a membership to get it.

Regards,
Arend

Acked-by on v1 5/22
#15 lore raw

Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

In reply to Lee Jones
Quoted 22 lines · Lee Jones
Cc Christian Daudt <[email protected]>
---
  arch/arm/boot/dts/bcm11351-brt.dts | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/bcm11351-brt.dts +2 -2
index 67ec524..fdace5d 100644
@@ -27,18 +27,18 @@
  		status = "okay";
  	};
 
-	sdio0: sdio at 0x3f180000 {
+	sdio0: sdio at 3f180000 {
  		max-frequency = <48000000>;
  		status = "okay";
  	};
 
-	sdio1: sdio at 0x3f190000 {
+	sdio1: sdio at 3f190000 {

arch/arm/boot/dts/bcm11351-brt.dts line 44

Quoted 10 lines
arch/arm/boot/dts/bcm11351-brt.dts +1 -1
  		non-removable;
  		max-frequency = <48000000>;
  		status = "okay";
  	};
 
-	sdio3: sdio at 0x3f1b0000 {
+	sdio3: sdio at 3f1b0000 {
  		max-frequency = <48000000>;
  		status = "okay";
  	};

Thanks,
csd

author
#16 lore raw

PATCH 6/22 ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

In reply to Lee Jones
Cc Christian Daudt <[email protected]>
---
 arch/arm/boot/dts/bcm11351.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/bcm11351.dtsi +5 -5
index c0cdf66..db5873a 100644
@@ -34,7 +34,7 @@
 		      <0x3ff00100 0x100>;
 	};
 
-	smc at 0x3404c000 {
+	smc at 3404c000 {
 		compatible = "bcm,bcm11351-smc", "bcm,kona-smc";
 		reg = <0x3404c000 0x400>; /* 1 KiB in SRAM */
 	};
@@ -63,28 +63,28 @@
 		clock-frequency = <32768>;
 	};
 
-	sdio0: sdio at 0x3f180000 {
+	sdio0: sdio at 3f180000 {
 		compatible = "bcm,kona-sdhci";
 		reg = <0x3f180000 0x10000>;
 		interrupts = <0x0 77 0x4>;
 		status = "disabled";
 	};
 
-	sdio1: sdio at 0x3f190000 {
+	sdio1: sdio at 3f190000 {
 		compatible = "bcm,kona-sdhci";
 		reg = <0x3f190000 0x10000>;
 		interrupts = <0x0 76 0x4>;
 		status = "disabled";
 	};
 
-	sdio2: sdio at 0x3f1a0000 {
+	sdio2: sdio at 3f1a0000 {
 		compatible = "bcm,kona-sdhci";
 		reg = <0x3f1a0000 0x10000>;
 		interrupts = <0x0 74 0x4>;
 		status = "disabled";
 	};
 
-	sdio3: sdio at 0x3f1b0000 {
+	sdio3: sdio at 3f1b0000 {
 		compatible = "bcm,kona-sdhci";
 		reg = <0x3f1b0000 0x10000>;
 		interrupts = <0x0 73 0x4>;
Signature · 1 line
1.8.1.2
Acked-by on v1 6/22
#17 lore raw

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

Quoted 42 lines · Lee Jones
Cc Christian Daudt <[email protected]>
---
  arch/arm/boot/dts/bcm11351.dtsi | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/bcm11351.dtsi +4 -4
index c0cdf66..db5873a 100644
@@ -34,7 +34,7 @@
  		      <0x3ff00100 0x100>;
  	};
 
-	smc at 0x3404c000 {
+	smc at 3404c000 {
  		compatible = "bcm,bcm11351-smc", "bcm,kona-smc";
  		reg = <0x3404c000 0x400>; /* 1 KiB in SRAM */
  	};
@@ -63,28 +63,28 @@
  		clock-frequency = <32768>;
  	};
 
-	sdio0: sdio at 0x3f180000 {
+	sdio0: sdio at 3f180000 {
  		compatible = "bcm,kona-sdhci";
  		reg = <0x3f180000 0x10000>;
  		interrupts = <0x0 77 0x4>;
  		status = "disabled";
  	};
 
-	sdio1: sdio at 0x3f190000 {
+	sdio1: sdio at 3f190000 {
  		compatible = "bcm,kona-sdhci";
  		reg = <0x3f190000 0x10000>;
  		interrupts = <0x0 76 0x4>;
  		status = "disabled";
  	};
 
-	sdio2: sdio at 0x3f1a0000 {
+	sdio2: sdio at 3f1a0000 {
  		compatible = "bcm,kona-sdhci";

arch/arm/boot/dts/bcm11351.dtsi line 90

Quoted 10 lines
arch/arm/boot/dts/bcm11351.dtsi +1 -1
  		reg = <0x3f1a0000 0x10000>;
  		interrupts = <0x0 74 0x4>;
  		status = "disabled";
  	};
 
-	sdio3: sdio at 0x3f1b0000 {
+	sdio3: sdio at 3f1b0000 {
  		compatible = "bcm,kona-sdhci";
  		reg = <0x3f1b0000 0x10000>;
  		interrupts = <0x0 73 0x4>;

Thanks,
csd

author
#18 lore raw

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

Quoted 1 line

Thanks Christian, for both.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#19 lore raw

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

Hi Lee,
I had to change some of the lines in the dts files you modified, so
I've added your mods. This patch:
https://lkml.org/lkml/2013/8/8/477

includes your changes to bcm11351.dtsi and bcm11351-brt.dts. Not sure where your patch is at this point, but I just wanted to point that out.

Thanks,
csd

author
#20 lore raw

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

Quoted 8 lines · Christian Daudt

Hi Lee,
I had to change some of the lines in the dts files you modified, so
I've added your mods. This patch:
https://lkml.org/lkml/2013/8/8/477

includes your changes to bcm11351.dtsi and bcm11351-brt.dts. Not sure where your patch is at this point, but I just wanted to point that out.

I haven't done anything with that patch yet, but I'd prefer they stayed separate to be honest. If you make your changes and ensure they're in an upstream tree (and let me know which one), I'll rebase my patches on top of that tree.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#21 lore raw

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

Quoted 7 lines · Lee Jones
Quoted 5 lines · Christian Daudt

Hi Lee,
I had to change some of the lines in the dts files you modified, so
I've added your mods. This patch:
https://lkml.org/lkml/2013/8/8/477

Quoted 7 lines
Quoted 3 lines

includes your changes to bcm11351.dtsi and bcm11351-brt.dts. Not sure where your patch is at this point, but I just wanted to point that out.

I haven't done anything with that patch yet, but I'd prefer they stayed separate to be honest. If you make your changes and ensure they're in an upstream tree (and let me know which one), I'll rebase my patches on top of that tree.

These changes are in 3.12-rc1 now:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d7358f845645c588aff84ac6b476a17d3eec75fa

thanks,
csd

author
#22 lore raw

Re: [PATCH 06/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 DTS file

Quoted 11 lines · Christian Daudt
Quoted 10 lines · Lee Jones
Quoted 8 lines · Christian Daudt

Hi Lee,
I had to change some of the lines in the dts files you modified, so
I've added your mods. This patch:
https://lkml.org/lkml/2013/8/8/477

includes your changes to bcm11351.dtsi and bcm11351-brt.dts. Not sure where your patch is at this point, but I just wanted to point that out.

Quoted 7 lines
Quoted 4 lines

I haven't done anything with that patch yet, but I'd prefer they stayed separate to be honest. If you make your changes and ensure they're in an upstream tree (and let me know which one), I'll rebase my patches on top of that tree.

These changes are in 3.12-rc1 now:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d7358f845645c588aff84ac6b476a17d3eec75fa

Not even so much as a Reviewed-by:, nice!

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#23 lore raw

PATCH 7/22 ARM: exynos: Remove '0x's from Exynos4110 DTSI file

In reply to Lee Jones
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
---
 arch/arm/boot/dts/exynos4210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210.dtsi +1 -1
index b7f358a..53e2527 100644
@@ -72,7 +72,7 @@
 		};
 	};
 
-	clock: clock-controller at 0x10030000 {
+	clock: clock-controller at 10030000 {
 		compatible = "samsung,exynos4210-clock";
 		reg = <0x10030000 0x20000>;
 		#clock-cells = <1>;
Signature · 1 line
1.8.1.2
#24 lore raw

Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file

Hi Lee,

Quoted 12 lines · On Monday 22 of July 2013 11:52:26 Lee Jones wrote:
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
---
 arch/arm/boot/dts/exynos4210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi line 78

Quoted 8 lines
arch/arm/boot/dts/exynos4210.dtsi +1 -1
@@ -72,7 +72,7 @@
 		};
 	};
 
-	clock: clock-controller at 0x10030000 {
+	clock: clock-controller at 10030000 {
 		compatible = "samsung,exynos4210-clock";
 		reg = <0x10030000 0x20000>;
 		#clock-cells = <1>;

This looks fine, but please fix commit message - it should be Exynos4210. Also some explanation why this change is needed would be good, even if it's obvious.

Best regards,
Tomasz

author
#25 lore raw

Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file

Quoted 18 lines · Tomasz Figa

Hi Lee,

Quoted 15 lines · On Monday 22 of July 2013 11:52:26 Lee Jones wrote:
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
---
 arch/arm/boot/dts/exynos4210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi +0 -0
@@ -72,7 +72,7 @@
 		};
 	};
 
Quoted 9 lines

arch/arm/boot/dts/exynos4210.dtsi line 78

Quoted 5 lines
arch/arm/boot/dts/exynos4210.dtsi +1 -1
-	clock: clock-controller at 0x10030000 {
+	clock: clock-controller at 10030000 {
 		compatible = "samsung,exynos4210-clock";
 		reg = <0x10030000 0x20000>;
 		#clock-cells = <1>;

This looks fine, but please fix commit message - it should be Exynos4210. Also some explanation why this change is needed would be good, even if it's obvious.

Hi Tomasz,

I'm happy to fixup the $SUBJECT line, but do we really have to enter an explanation if it's obvious? Seems a little belt and braces.

Kind regards,
Lee

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#26 lore raw

Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file

Quoted 33 lines · On Tuesday 23 of July 2013 09:55:52 Lee Jones wrote:
Quoted 24 lines · Tomasz Figa

Hi Lee,

Quoted 21 lines · On Monday 22 of July 2013 11:52:26 Lee Jones wrote:
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org

---

 arch/arm/boot/dts/exynos4210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi +1 -1
@@ -72,7 +72,7 @@
 
 		};
 
 	};
 
-	clock: clock-controller at 0x10030000 {
+	clock: clock-controller at 10030000 {
 
Quoted 7 lines

arch/arm/boot/dts/exynos4210.dtsi line 78

Quoted 3 lines
arch/arm/boot/dts/exynos4210.dtsi +0 -0
 		compatible = "samsung,exynos4210-clock";
 		reg = <0x10030000 0x20000>;
 		#clock-cells = <1>;

This looks fine, but please fix commit message - it should be Exynos4210. Also some explanation why this change is needed would be good, even if it's obvious.

Quoted 4 lines

Hi Tomasz,

I'm happy to fixup the $SUBJECT line, but do we really have to enter an explanation if it's obvious? Seems a little belt and braces.

It's obvious for us, people working with device tree, but for people that usually don't it might not be.

Something among following lines would be fine:

This patch removes "0x" prefix from addresses in DT nodes for the sake of consistency with other nodes and assumed convention.

Best regards,
Tomasz

author
#27 lore raw

PATCH v2 7/22 ARM: Exynos4210: Remove '0x's from Exynos4110 DTSI file

In reply to Lee Jones

... for the sake of consistency and assumed convention.

Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
arch/arm/boot/dts/exynos4210.dtsi +1 -1
index b7f358a..53e2527 100644
@@ -72,7 +72,7 @@
                };
        };
 
-       clock: clock-controller at 0x10030000 {
+       clock: clock-controller at 10030000 {
                compatible = "samsung,exynos4210-clock";
                reg = <0x10030000 0x20000>;
                #clock-cells = <1>;
#28 lore raw

Re: [PATCH v2 07/22] ARM: Exynos4210: Remove '0x's from Exynos4110 DTSI file

Quoted 11 lines · On Wednesday 24 of July 2013 13:39:31 Lee Jones wrote:

... for the sake of consistency and assumed convention.

Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi line 78

Quoted 8 lines
arch/arm/boot/dts/exynos4210.dtsi +1 -1
@@ -72,7 +72,7 @@
                };
        };
 
-       clock: clock-controller at 0x10030000 {
+       clock: clock-controller at 10030000 {
                compatible = "samsung,exynos4210-clock";
                reg = <0x10030000 0x20000>;
                #clock-cells = <1>;

Looks good to me, except the subject which is still wrong - s/Exynos4110/Exynos4210/.

I guess it might be fixed when applying, though.

Best regards,
Tomasz

author
#29 lore raw

Re: [PATCH v2 07/22] ARM: Exynos4210: Remove '0x's from Exynos4110 DTSI file

Quoted 15 lines · Tomasz Figa
Quoted 14 lines · On Wednesday 24 of July 2013 13:39:31 Lee Jones wrote:

... for the sake of consistency and assumed convention.

Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi +0 -0
@@ -72,7 +72,7 @@
                };
        };
 
Quoted 8 lines

arch/arm/boot/dts/exynos4210.dtsi line 78

Quoted 5 lines
arch/arm/boot/dts/exynos4210.dtsi +1 -1
-       clock: clock-controller at 0x10030000 {
+       clock: clock-controller at 10030000 {
                compatible = "samsung,exynos4210-clock";
                reg = <0x10030000 0x20000>;
                #clock-cells = <1>;

Looks good to me, except the subject which is still wrong - s/Exynos4110/Exynos4210/.

Ah, I get you know. My bad, will fix.

Quoted 1 line

I guess it might be fixed when applying, though.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#30 lore raw

PATCH v3 7/22 ARM: dts: Remove '0x's from Exynos4210 DTSI file

In reply to Lee Jones

... for the sake of consistency and assumed convention.

Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
arch/arm/boot/dts/exynos4210.dtsi +1 -1
index b7f358a..53e2527 100644
@@ -72,7 +72,7 @@
                };
        };
 
-       clock: clock-controller at 0x10030000 {
+       clock: clock-controller at 10030000 {
                compatible = "samsung,exynos4210-clock";
                reg = <0x10030000 0x20000>;
                #clock-cells = <1>;
Acked-by on v3 7/22
#31 lore raw

Re: [PATCH v3 07/22] ARM: dts: Remove '0x's from Exynos4210 DTSI file

Quoted 11 lines · On Wednesday 24 of July 2013 16:09:37 Lee Jones wrote:

... for the sake of consistency and assumed convention.

Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi line 78

Quoted 8 lines
arch/arm/boot/dts/exynos4210.dtsi +1 -1
@@ -72,7 +72,7 @@
                };
        };
 
-       clock: clock-controller at 0x10030000 {
+       clock: clock-controller at 10030000 {
                compatible = "samsung,exynos4210-clock";
                reg = <0x10030000 0x20000>;
                #clock-cells = <1>;

Best regards,
Tomasz

author
#32 lore raw

Re: [PATCH v3 07/22] ARM: dts: Remove '0x's from Exynos4210 DTSI file

Quoted 15 lines · Tomasz Figa
Quoted 14 lines · On Wednesday 24 of July 2013 16:09:37 Lee Jones wrote:

... for the sake of consistency and assumed convention.

Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi +0 -0
@@ -72,7 +72,7 @@
                };
        };
 
Quoted 7 lines

arch/arm/boot/dts/exynos4210.dtsi line 78

Quoted 5 lines
arch/arm/boot/dts/exynos4210.dtsi +1 -1
-       clock: clock-controller at 0x10030000 {
+       clock: clock-controller at 10030000 {
                compatible = "samsung,exynos4210-clock";
                reg = <0x10030000 0x20000>;
                #clock-cells = <1>;

Thanks Tomasz.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#33 lore raw

Re: [PATCH v3 07/22] ARM: dts: Remove '0x's from Exynos4210 DTSI file

Quoted 25 lines · Lee Jones
Quoted 15 lines · Tomasz Figa
Quoted 14 lines · On Wednesday 24 of July 2013 16:09:37 Lee Jones wrote:

... for the sake of consistency and assumed convention.

Cc Kukjin Kim<[email protected]>
Cc linux-samsung-soc at vger.kernel.org
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644

arch/arm/boot/dts/exynos4210.dtsi +0 -0
@@ -72,7 +72,7 @@
                 };
         };
 
Quoted 7 lines

arch/arm/boot/dts/exynos4210.dtsi

Quoted 5 lines
arch/arm/boot/dts/exynos4210.dtsi +1 -1
-       clock: clock-controller at 0x10030000 {
+       clock: clock-controller at 10030000 {
                 compatible = "samsung,exynos4210-clock";
                 reg =<0x10030000 0x20000>;
                 #clock-cells =<1>;
Quoted 2 lines

Thanks Tomasz.

Thanks, Lee Jones and Tomasz.

Applied #7 ~ #11 into the cleanup of samsung tree.

- Kukjin

#34 lore raw

Re: [PATCH v3 07/22] ARM: dts: Remove '0x's from Exynos4210 DTSI file

In reply to Lee Jones

arch/arm/boot/dts/exynos4210.dtsi line 72

Quoted 12 lines · Lee Jones

... for the sake of consistency and assumed convention.

Cc Kukjin Kim<[email protected]>
Cc linux-samsung-soc at vger.kernel.org
arch/arm/boot/dts/exynos4210.dtsi +0 -0
index b7f358a..53e2527 100644
@@ -72,7 +72,7 @@
                 };
    ^^^^^^^^^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
         };
    ^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 75

Quoted 2 lines
arch/arm/boot/dts/exynos4210.dtsi +0 -1
-       clock: clock-controller at 0x10030000 {
    ^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 75

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +1 -0
+       clock: clock-controller at 10030000 {
    ^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 76

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
                 compatible = "samsung,exynos4210-clock";
    ^^^^^^^^^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 76

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
                 reg =<0x10030000 0x20000>;
    ^^^^^^^^^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 77

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
                 #clock-cells =<1>;
    ^^^^^^^^^^^^^^^^

BTW, should be tab at the mark '^' not white space :(

- Kukjin

author
#35 lore raw

Re: [PATCH v3 07/22] ARM: dts: Remove '0x's from Exynos4210 DTSI file

Quoted 21 lines · Kukjin Kim

arch/arm/boot/dts/exynos4210.dtsi line 72

Quoted 12 lines · Lee Jones

... for the sake of consistency and assumed convention.

Cc Kukjin Kim<[email protected]>
Cc linux-samsung-soc at vger.kernel.org
arch/arm/boot/dts/exynos4210.dtsi +0 -0
index b7f358a..53e2527 100644
@@ -72,7 +72,7 @@
                };

^^^^^^^^^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 73

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
        };

^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 75

Quoted 2 lines
arch/arm/boot/dts/exynos4210.dtsi +0 -1
-       clock: clock-controller at 0x10030000 {

^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 75

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +1 -0
+       clock: clock-controller at 10030000 {

^^^^^^^^

Quoted 8 lines

arch/arm/boot/dts/exynos4210.dtsi line 76

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
                compatible = "samsung,exynos4210-clock";

^^^^^^^^^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 76

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
                reg =<0x10030000 0x20000>;

^^^^^^^^^^^^^^^^

arch/arm/boot/dts/exynos4210.dtsi line 77

Quoted 1 line
arch/arm/boot/dts/exynos4210.dtsi +0 -0
                #clock-cells =<1>;

^^^^^^^^^^^^^^^^

BTW, should be tab at the mark '^' not white space :(

Agreed, but this should be a separate patch.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#36 lore raw

PATCH 8/22 ARM: dts: Remove '0x's from Exynos4x12 DTSI file

In reply to Lee Jones
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
---
 arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4x12.dtsi +1 -1
index 01da194..3aa2f06 100644
@@ -28,7 +28,7 @@
 		pinctrl3 = &pinctrl_3;
 	};
 
-	clock: clock-controller at 0x10030000 {
+	clock: clock-controller at 10030000 {
 		compatible = "samsung,exynos4412-clock";
 		reg = <0x10030000 0x20000>;
 		#clock-cells = <1>;
Signature · 1 line
1.8.1.2
author
#37 lore raw

PATCH 9/22 ARM: dts: Remove '0x's from Exynos5250 DTS file

In reply to Lee Jones
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
---
 arch/arm/boot/dts/exynos5250.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/exynos5250.dtsi +7 -7
index ef57277..24c0888 100644
@@ -68,17 +68,17 @@
 		};
 	};
 
-	pd_gsc: gsc-power-domain at 0x10044000 {
+	pd_gsc: gsc-power-domain at 10044000 {
 		compatible = "samsung,exynos4210-pd";
 		reg = <0x10044000 0x20>;
 	};
 
-	pd_mfc: mfc-power-domain at 0x10044040 {
+	pd_mfc: mfc-power-domain at 10044040 {
 		compatible = "samsung,exynos4210-pd";
 		reg = <0x10044040 0x20>;
 	};
 
-	clock: clock-controller at 0x10010000 {
+	clock: clock-controller at 10010000 {
 		compatible = "samsung,exynos5250-clock";
 		reg = <0x10010000 0x30000>;
 		#clock-cells = <1>;
@@ -562,7 +562,7 @@
 		};
 	};
 
-	gsc_0:  gsc at 0x13e00000 {
+	gsc_0:  gsc at 13e00000 {
 		compatible = "samsung,exynos5-gsc";
 		reg = <0x13e00000 0x1000>;
 		interrupts = <0 85 0>;
@@ -571,7 +571,7 @@
 		clock-names = "gscl";
 	};
 
-	gsc_1:  gsc at 0x13e10000 {
+	gsc_1:  gsc at 13e10000 {
 		compatible = "samsung,exynos5-gsc";
 		reg = <0x13e10000 0x1000>;
 		interrupts = <0 86 0>;
@@ -580,7 +580,7 @@
 		clock-names = "gscl";
 	};
 
-	gsc_2:  gsc at 0x13e20000 {
+	gsc_2:  gsc at 13e20000 {
 		compatible = "samsung,exynos5-gsc";
 		reg = <0x13e20000 0x1000>;
 		interrupts = <0 87 0>;
@@ -589,7 +589,7 @@
 		clock-names = "gscl";
 	};
 
-	gsc_3:  gsc at 0x13e30000 {
+	gsc_3:  gsc at 13e30000 {
 		compatible = "samsung,exynos5-gsc";
 		reg = <0x13e30000 0x1000>;
 		interrupts = <0 88 0>;
Signature · 1 line
1.8.1.2
author
#38 lore raw

PATCH 10/22 ARM: dts: Remove '0x's from Exynos5420 DTS file

In reply to Lee Jones
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
---
 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +1 -1
index 8c54c4b..9e90d1e 100644
@@ -59,7 +59,7 @@
 		};
 	};
 
-	clock: clock-controller at 0x10010000 {
+	clock: clock-controller at 10010000 {
 		compatible = "samsung,exynos5420-clock";
 		reg = <0x10010000 0x30000>;
 		#clock-cells = <1>;
Signature · 1 line
1.8.1.2
author
#39 lore raw

PATCH 11/22 ARM: dts: Remove '0x's from Exynos5440 DTS file

In reply to Lee Jones
Cc Kukjin Kim <[email protected]>
Cc linux-samsung-soc at vger.kernel.org
---
 arch/arm/boot/dts/exynos5440.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5440.dtsi +1 -1
index ff7f5d8..0cedba4 100644
@@ -20,7 +20,7 @@
 		spi0 = &spi_0;
 	};
 
-	clock: clock-controller at 0x160000 {
+	clock: clock-controller at 160000 {
 		compatible = "samsung,exynos5440-clock";
 		reg = <0x160000 0x1000>;
 		#clock-cells = <1>;
Signature · 1 line
1.8.1.2
author
#40 lore raw

PATCH 12/22 ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

In reply to Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap2420-h4.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap2420-h4.dts +3 -3
index 224c08f..34cdecb 100644
@@ -50,15 +50,15 @@
 			label = "bootloader";
 			reg = <0 0x20000>;
 		};
-		partition at 0x20000 {
+		partition at 20000 {
 			label = "params";
 			reg = <0x20000 0x20000>;
 		};
-		partition at 0x40000 {
+		partition at 40000 {
 			label = "kernel";
 			reg = <0x40000 0x200000>;
 		};
-		partition at 0x240000 {
+		partition at 240000 {
 			label = "file-system";
 			reg = <0x240000 0x3dc0000>;
 		};
Signature · 1 line
1.8.1.2
author
#41 lore raw

Re: [PATCH 12/22] ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

Tony, Benoit,

Poke

Quoted 31 lines · Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap2420-h4.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap2420-h4.dts +3 -3
index 224c08f..34cdecb 100644
@@ -50,15 +50,15 @@
 			label = "bootloader";
 			reg = <0 0x20000>;
 		};
-		partition at 0x20000 {
+		partition at 20000 {
 			label = "params";
 			reg = <0x20000 0x20000>;
 		};
-		partition at 0x40000 {
+		partition at 40000 {
 			label = "kernel";
 			reg = <0x40000 0x200000>;
 		};
-		partition at 0x240000 {
+		partition at 240000 {
 			label = "file-system";
 			reg = <0x240000 0x3dc0000>;
 		};
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#42 lore raw

Re: [PATCH 12/22] ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

Quoted 3 lines · Lee Jones

Tony, Benoit,

Poke

Looks like Benoit's new email address is bcousson at baylibre.com. Probably best for Benoit to pick these to avoid merge conflicts.

Regards,

Tony

Quoted 39 lines · Lee Jones
Quoted 32 lines
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap2420-h4.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap2420-h4.dts +3 -3
index 224c08f..34cdecb 100644
@@ -50,15 +50,15 @@
 			label = "bootloader";
 			reg = <0 0x20000>;
 		};
-		partition at 0x20000 {
+		partition at 20000 {
 			label = "params";
 			reg = <0x20000 0x20000>;
 		};
-		partition at 0x40000 {
+		partition at 40000 {
 			label = "kernel";
 			reg = <0x40000 0x200000>;
 		};
-		partition at 0x240000 {
+		partition at 240000 {
 			label = "file-system";
 			reg = <0x240000 0x3dc0000>;
 		};
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#43 lore raw

Re: [PATCH 12/22] ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

Hi Lee,

Thanks for that cleanup.

Quoted 7 lines · Tony Lindgren
Quoted 3 lines · Lee Jones

Tony, Benoit,

Poke

Looks like Benoit's new email address is bcousson at baylibre.com. Probably best for Benoit to pick these to avoid merge conflicts.

I've just applied the 7 following patches. Let me know if I missed something.

6b9fa1b ARM: dts: Remove '0x's from OMAP5 DTS file 79390b8 ARM: dts: Remove '0x's from OMAP4 DTS file dd60fef ARM: dts: Remove '0x's from OMAP3430 SDP DTS file bfef1cb ARM: dts: Remove '0x's from OMAP3 DTS file 5f547ac ARM: dts: Remove '0x's from OMAP3 IGEP0030 DTS file 27939fc ARM: dts: Remove '0x's from OMAP3 IGEP0020 DTS file 62eb4d1 ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

Regards,
Benoit

Quoted 49 lines

Regards,

Tony

Quoted 31 lines · Lee Jones
Quoted 30 lines
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
  arch/arm/boot/dts/omap2420-h4.dts | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap2420-h4.dts +3 -3
index 224c08f..34cdecb 100644
@@ -50,15 +50,15 @@
  			label = "bootloader";
  			reg = <0 0x20000>;
  		};
-		partition at 0x20000 {
+		partition at 20000 {
  			label = "params";
  			reg = <0x20000 0x20000>;
  		};
-		partition at 0x40000 {
+		partition at 40000 {
  			label = "kernel";
  			reg = <0x40000 0x200000>;
  		};
-		partition at 0x240000 {
+		partition at 240000 {
  			label = "file-system";
Quoted 8 lines

arch/arm/boot/dts/omap2420-h4.dts line 64

Quoted 2 lines
arch/arm/boot/dts/omap2420-h4.dts +0 -0
  			reg = <0x240000 0x3dc0000>;
  		};

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#44 lore raw

Re: [PATCH 12/22] ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

Quoted 2 lines
Quoted 2 lines

Looks like Benoit's new email address is bcousson at baylibre.com. Probably best for Benoit to pick these to avoid merge conflicts.

Ah nice, thanks Tony.

Quoted 10 lines

I've just applied the 7 following patches. Let me know if I missed something.

6b9fa1b ARM: dts: Remove '0x's from OMAP5 DTS file 79390b8 ARM: dts: Remove '0x's from OMAP4 DTS file dd60fef ARM: dts: Remove '0x's from OMAP3430 SDP DTS file bfef1cb ARM: dts: Remove '0x's from OMAP3 DTS file 5f547ac ARM: dts: Remove '0x's from OMAP3 IGEP0030 DTS file 27939fc ARM: dts: Remove '0x's from OMAP3 IGEP0020 DTS file 62eb4d1 ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

Nope, looks good. Thanks Benoit.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#45 lore raw

PATCH 13/22 ARM: dts: Remove '0x's from OMAP3 IGEP0020 DTS file

In reply to Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3-igep0020.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/omap3-igep0020.dts +4 -4
index e8c4828..f7a8122 100644
@@ -99,19 +99,19 @@
 			label = "SPL";
 			reg = <0 0x100000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "U-Boot";
 			reg = <0x100000 0x180000>;
 		};
-		partition at 0x1c0000 {
+		partition at 1c0000 {
 			label = "Environment";
 			reg = <0x280000 0x100000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "Kernel";
 			reg = <0x380000 0x300000>;
 		};
-		partition at 0x780000 {
+		partition at 780000 {
 			label = "Filesystem";
 			reg = <0x680000 0x1f980000>;
 		};
Signature · 1 line
1.8.1.2
author
#46 lore raw

Re: [PATCH 13/22] ARM: dts: Remove '0x's from OMAP3 IGEP0020 DTS file

Tony, Benoit,

Poke

Quoted 36 lines · Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3-igep0020.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/omap3-igep0020.dts +4 -4
index e8c4828..f7a8122 100644
@@ -99,19 +99,19 @@
 			label = "SPL";
 			reg = <0 0x100000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "U-Boot";
 			reg = <0x100000 0x180000>;
 		};
-		partition at 0x1c0000 {
+		partition at 1c0000 {
 			label = "Environment";
 			reg = <0x280000 0x100000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "Kernel";
 			reg = <0x380000 0x300000>;
 		};
-		partition at 0x780000 {
+		partition at 780000 {
 			label = "Filesystem";
 			reg = <0x680000 0x1f980000>;
 		};
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#47 lore raw

PATCH 14/22 ARM: dts: Remove '0x's from OMAP3 IGEP0030 DTS file

In reply to Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3-igep0030.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/omap3-igep0030.dts +4 -4
index 644d0538..f628200 100644
@@ -74,19 +74,19 @@
 			label = "SPL";
 			reg = <0 0x100000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "U-Boot";
 			reg = <0x100000 0x180000>;
 		};
-		partition at 0x1c0000 {
+		partition at 1c0000 {
 			label = "Environment";
 			reg = <0x280000 0x100000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "Kernel";
 			reg = <0x380000 0x300000>;
 		};
-		partition at 0x780000 {
+		partition at 780000 {
 			label = "Filesystem";
 			reg = <0x680000 0x1f980000>;
 		};
Signature · 1 line
1.8.1.2
author
#48 lore raw

Re: [PATCH 14/22] ARM: dts: Remove '0x's from OMAP3 IGEP0030 DTS file

Tony, Benoit,

Poke

Quoted 36 lines · Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3-igep0030.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/omap3-igep0030.dts +4 -4
index 644d0538..f628200 100644
@@ -74,19 +74,19 @@
 			label = "SPL";
 			reg = <0 0x100000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "U-Boot";
 			reg = <0x100000 0x180000>;
 		};
-		partition at 0x1c0000 {
+		partition at 1c0000 {
 			label = "Environment";
 			reg = <0x280000 0x100000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "Kernel";
 			reg = <0x380000 0x300000>;
 		};
-		partition at 0x780000 {
+		partition at 780000 {
 			label = "Filesystem";
 			reg = <0x680000 0x1f980000>;
 		};
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#49 lore raw

PATCH 15/22 ARM: dts: Remove '0x's from OMAP3 DTS file

In reply to Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3.dtsi +1 -1
index 7d95cda..16420ae 100644
@@ -111,7 +111,7 @@
 			pinctrl-single,function-mask = <0x7f1f>;
 		};
 
-		omap3_pmx_wkup: pinmux at 0x48002a00 {
+		omap3_pmx_wkup: pinmux at 48002a00 {
 			compatible = "ti,omap3-padconf", "pinctrl-single";
 			reg = <0x48002a00 0x5c>;
 			#address-cells = <1>;
Signature · 1 line
1.8.1.2
author
#50 lore raw

Re: [PATCH 15/22] ARM: dts: Remove '0x's from OMAP3 DTS file

Tony, Benoit,

Poke

Quoted 21 lines · Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3.dtsi +1 -1
index 7d95cda..16420ae 100644
@@ -111,7 +111,7 @@
 			pinctrl-single,function-mask = <0x7f1f>;
 		};
 
-		omap3_pmx_wkup: pinmux at 0x48002a00 {
+		omap3_pmx_wkup: pinmux at 48002a00 {
 			compatible = "ti,omap3-padconf", "pinctrl-single";
 			reg = <0x48002a00 0x5c>;
 			#address-cells = <1>;
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#51 lore raw

PATCH 16/22 ARM: dts: Remove '0x's from OMAP3430 SDP DTS file

In reply to Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3430-sdp.dts | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
arch/arm/boot/dts/omap3430-sdp.dts +11 -11
index e2249bc..281914e 100644
@@ -84,15 +84,15 @@
 			label = "bootloader-nor";
 			reg = <0 0x40000>;
 		};
-		partition at 0x40000 {
+		partition at 40000 {
 			label = "params-nor";
 			reg = <0x40000 0x40000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "kernel-nor";
 			reg = <0x80000 0x200000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "filesystem-nor";
 			reg = <0x240000 0x7d80000>;
 		};
@@ -125,19 +125,19 @@
 			label = "xloader-nand";
 			reg = <0 0x80000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "bootloader-nand";
 			reg = <0x80000 0x140000>;
 		};
-		partition at 0x1c0000 {
+		partition at 1c0000 {
 			label = "params-nand";
 			reg = <0x1c0000 0xc0000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "kernel-nand";
 			reg = <0x280000 0x500000>;
 		};
-		partition at 0x780000 {
+		partition at 780000 {
 			label = "filesystem-nand";
 			reg = <0x780000 0x7880000>;
 		};
@@ -170,19 +170,19 @@
 			label = "xloader-onenand";
 			reg = <0 0x80000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "bootloader-onenand";
 			reg = <0x80000 0x40000>;
 		};
-		partition at 0xc0000 {
+		partition at c0000 {
 			label = "params-onenand";
 			reg = <0xc0000 0x20000>;
 		};
-		partition at 0xe0000 {
+		partition at e0000 {
 			label = "kernel-onenand";
 			reg = <0xe0000 0x200000>;
 		};
-		partition at 0x2e0000 {
+		partition at 2e0000 {
 			label = "filesystem-onenand";
 			reg = <0x2e0000 0xfd20000>;
 		};
Signature · 1 line
1.8.1.2
author
#52 lore raw

Re: [PATCH 16/22] ARM: dts: Remove '0x's from OMAP3430 SDP DTS file

Tony, Benoit,

Poke

Quoted 79 lines · Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3430-sdp.dts | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
arch/arm/boot/dts/omap3430-sdp.dts +11 -11
index e2249bc..281914e 100644
@@ -84,15 +84,15 @@
 			label = "bootloader-nor";
 			reg = <0 0x40000>;
 		};
-		partition at 0x40000 {
+		partition at 40000 {
 			label = "params-nor";
 			reg = <0x40000 0x40000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "kernel-nor";
 			reg = <0x80000 0x200000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "filesystem-nor";
 			reg = <0x240000 0x7d80000>;
 		};
@@ -125,19 +125,19 @@
 			label = "xloader-nand";
 			reg = <0 0x80000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "bootloader-nand";
 			reg = <0x80000 0x140000>;
 		};
-		partition at 0x1c0000 {
+		partition at 1c0000 {
 			label = "params-nand";
 			reg = <0x1c0000 0xc0000>;
 		};
-		partition at 0x280000 {
+		partition at 280000 {
 			label = "kernel-nand";
 			reg = <0x280000 0x500000>;
 		};
-		partition at 0x780000 {
+		partition at 780000 {
 			label = "filesystem-nand";
 			reg = <0x780000 0x7880000>;
 		};
@@ -170,19 +170,19 @@
 			label = "xloader-onenand";
 			reg = <0 0x80000>;
 		};
-		partition at 0x80000 {
+		partition at 80000 {
 			label = "bootloader-onenand";
 			reg = <0x80000 0x40000>;
 		};
-		partition at 0xc0000 {
+		partition at c0000 {
 			label = "params-onenand";
 			reg = <0xc0000 0x20000>;
 		};
-		partition at 0xe0000 {
+		partition at e0000 {
 			label = "kernel-onenand";
 			reg = <0xe0000 0x200000>;
 		};
-		partition at 0x2e0000 {
+		partition at 2e0000 {
 			label = "filesystem-onenand";
 			reg = <0x2e0000 0xfd20000>;
 		};
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#53 lore raw

PATCH 17/22 ARM: dts: Remove '0x's from OMAP4 DTS file

In reply to Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap4.dtsi +1 -1
index 22d9f2b..45708e1 100644
@@ -56,7 +56,7 @@
 		cache-level = <2>;
 	};
 
-	local-timer at 0x48240600 {
+	local-timer at 48240600 {
 		compatible = "arm,cortex-a9-twd-timer";
 		reg = <0x48240600 0x20>;
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_HIGH)>;
Signature · 1 line
1.8.1.2
author
#54 lore raw

Re: [PATCH 17/22] ARM: dts: Remove '0x's from OMAP4 DTS file

Tony, Benoit,

Poke

Quoted 21 lines · Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap4.dtsi +1 -1
index 22d9f2b..45708e1 100644
@@ -56,7 +56,7 @@
 		cache-level = <2>;
 	};
 
-	local-timer at 0x48240600 {
+	local-timer at 48240600 {
 		compatible = "arm,cortex-a9-twd-timer";
 		reg = <0x48240600 0x20>;
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_HIGH)>;
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#55 lore raw

PATCH 18/22 ARM: dts: Remove '0x's from OMAP5 DTS file

In reply to Lee Jones
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap5.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5.dtsi +2 -2
index e643620..be58604 100644
@@ -604,7 +604,7 @@
 			ti,hwmods = "wd_timer2";
 		};
 
-		emif1: emif at 0x4c000000 {
+		emif1: emif at 4c000000 {
 			compatible	= "ti,emif-4d5";
 			ti,hwmods	= "emif1";
 			phy-type	= <2>; /* DDR PHY type: Intelli PHY */
@@ -615,7 +615,7 @@
 			hw-caps-temp-alert;
 		};
 
-		emif2: emif at 0x4d000000 {
+		emif2: emif at 4d000000 {
 			compatible	= "ti,emif-4d5";
 			ti,hwmods	= "emif2";
 			phy-type	= <2>; /* DDR PHY type: Intelli PHY */
Signature · 1 line
1.8.1.2
author
#56 lore raw

Re: [PATCH 18/22] ARM: dts: Remove '0x's from OMAP5 DTS file

Tony, Benoit,

Poke

Quoted 30 lines
Cc Beno?t Cousson <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap5.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5.dtsi +2 -2
index e643620..be58604 100644
@@ -604,7 +604,7 @@
 			ti,hwmods = "wd_timer2";
 		};
 
-		emif1: emif at 0x4c000000 {
+		emif1: emif at 4c000000 {
 			compatible	= "ti,emif-4d5";
 			ti,hwmods	= "emif1";
 			phy-type	= <2>; /* DDR PHY type: Intelli PHY */
@@ -615,7 +615,7 @@
 			hw-caps-temp-alert;
 		};
 
-		emif2: emif at 0x4d000000 {
+		emif2: emif at 4d000000 {
 			compatible	= "ti,emif-4d5";
 			ti,hwmods	= "emif2";
 			phy-type	= <2>; /* DDR PHY type: Intelli PHY */
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author
#57 lore raw

PATCH 19/22 ARM: shmobile: r8a7779: Remove '0x's from R8A7779 DTS file

In reply to Lee Jones
Cc Simon Horman <[email protected]>
---
 arch/arm/boot/dts/r8a7779.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/r8a7779.dtsi +4 -4
index 7f146c6..86bd487 100644
@@ -65,7 +65,7 @@
 		sense-bitfield-width = <2>;
 	};
 
-	i2c0: i2c at 0xffc70000 {
+	i2c0: i2c at ffc70000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -74,7 +74,7 @@
 		interrupts = <0 79 0x4>;
 	};
 
-	i2c1: i2c at 0xffc71000 {
+	i2c1: i2c at ffc71000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -83,7 +83,7 @@
 		interrupts = <0 82 0x4>;
 	};
 
-	i2c2: i2c at 0xffc72000 {
+	i2c2: i2c at ffc72000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -92,7 +92,7 @@
 		interrupts = <0 80 0x4>;
 	};
 
-	i2c3: i2c at 0xffc73000 {
+	i2c3: i2c at ffc73000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
Signature · 1 line
1.8.1.2
Acked-by on v1 19/22
#58 lore raw

Re: [PATCH 19/22] ARM: shmobile: r8a7779: Remove '0x's from R8A7779 DTS file

Quoted 2 lines · Lee Jones
Cc Simon Horman <[email protected]>

Let me know if you want me to take this through the renesas tree.

Quoted 47 lines
---
 arch/arm/boot/dts/r8a7779.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/r8a7779.dtsi +4 -4
index 7f146c6..86bd487 100644
@@ -65,7 +65,7 @@
 		sense-bitfield-width = <2>;
 	};
 
-	i2c0: i2c at 0xffc70000 {
+	i2c0: i2c at ffc70000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -74,7 +74,7 @@
 		interrupts = <0 79 0x4>;
 	};
 
-	i2c1: i2c at 0xffc71000 {
+	i2c1: i2c at ffc71000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -83,7 +83,7 @@
 		interrupts = <0 82 0x4>;
 	};
 
-	i2c2: i2c at 0xffc72000 {
+	i2c2: i2c at ffc72000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -92,7 +92,7 @@
 		interrupts = <0 80 0x4>;
 	};
 
-	i2c3: i2c at 0xffc73000 {
+	i2c3: i2c at ffc73000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
Signature · 1 line
1.8.1.2
author
#59 lore raw

Re: [PATCH 19/22] ARM: shmobile: r8a7779: Remove '0x's from R8A7779 DTS file

Quoted 7 lines · Simon Horman
Quoted 2 lines · Lee Jones
Cc Simon Horman <[email protected]>

Let me know if you want me to take this through the renesas tree.

Thanks Simon. To save on conflicts, I think that's best.

I will take all orphaned patches or ones without maintainers associated with them through ARM SoC, but if you can take it, please do.

Quoted 44 lines
Quoted 44 lines
---
 arch/arm/boot/dts/r8a7779.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/r8a7779.dtsi +4 -4
index 7f146c6..86bd487 100644
@@ -65,7 +65,7 @@
 		sense-bitfield-width = <2>;
 	};
 
-	i2c0: i2c at 0xffc70000 {
+	i2c0: i2c at ffc70000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -74,7 +74,7 @@
 		interrupts = <0 79 0x4>;
 	};
 
-	i2c1: i2c at 0xffc71000 {
+	i2c1: i2c at ffc71000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -83,7 +83,7 @@
 		interrupts = <0 82 0x4>;
 	};
 
-	i2c2: i2c at 0xffc72000 {
+	i2c2: i2c at ffc72000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
@@ -92,7 +92,7 @@
 		interrupts = <0 80 0x4>;
 	};
 
-	i2c3: i2c at 0xffc73000 {
+	i2c3: i2c at ffc73000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "renesas,rmobile-iic";
Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#60 lore raw

Re: [PATCH 19/22] ARM: shmobile: r8a7779: Remove '0x's from R8A7779 DTS file

Quoted 6 lines · Lee Jones
Quoted 4 lines · Simon Horman
Quoted 2 lines · Lee Jones
Cc Simon Horman <[email protected]>
Quoted 8 lines
Quoted 3 lines

Let me know if you want me to take this through the renesas tree.

Thanks Simon. To save on conflicts, I think that's best.

I will take all orphaned patches or ones without maintainers associated with them through ARM SoC, but if you can take it, please do.

Understood.

I have queued this up for v3.12 in the fixes2-for-v3.12 branch of my renesas tree on kernel.org.

author
#61 lore raw

PATCH 20/22 ARM: SPEAr3xx: DT: Remove '0x's from Spear 300 DTS file

In reply to Lee Jones
Cc Viresh Kumar <[email protected]>
---
 arch/arm/boot/dts/spear300.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/spear300.dtsi +1 -1
index f79b3df..8970a4a 100644
@@ -52,7 +52,7 @@
 			status = "disabled";
 		};
 
-		shirq: interrupt-controller at 0x50000000 {
+		shirq: interrupt-controller at 50000000 {
 			compatible = "st,spear300-shirq";
 			reg = <0x50000000 0x1000>;
 			interrupts = <28>;
Signature · 1 line
1.8.1.2
author
#63 lore raw

PATCH 21/22 ARM: SPEAr3xx: DT: Remove '0x's from Spear 310 DTS file

In reply to Lee Jones
Cc Viresh Kumar <[email protected]>
---
 arch/arm/boot/dts/spear310.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/spear310.dtsi +1 -1
index 9537208..dc263e4 100644
@@ -40,7 +40,7 @@
 			status = "disabled";
 		};
 
-		shirq: interrupt-controller at 0xb4000000 {
+		shirq: interrupt-controller at b4000000 {
 			compatible = "st,spear310-shirq";
 			reg = <0xb4000000 0x1000>;
 			interrupts = <28 29 30 1>;
Signature · 1 line
1.8.1.2
author
#64 lore raw

PATCH 22/22 ARM: SPEAr3xx: DT: Remove '0x's from Spear 320 DTS file

In reply to Lee Jones
Cc Viresh Kumar <[email protected]>
---
 arch/arm/boot/dts/spear320.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/spear320.dtsi +1 -1
index ffea342..a82d76e5 100644
@@ -55,7 +55,7 @@
 			status = "disabled";
 		};
 
-		shirq: interrupt-controller at 0xb3000000 {
+		shirq: interrupt-controller at b3000000 {
 			compatible = "st,spear320-shirq";
 			reg = <0xb3000000 0x1000>;
 			interrupts = <30 28 29 1>;
Signature · 1 line
1.8.1.2
#65 lore raw
In reply to Lee Jones
Quoted 10 lines · Lee Jones
---
 arch/arm/boot/dts/hrefv60plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/hrefv60plus.dts +0 -0
index 3d580d6..46fd8af 100644

arch/arm/boot/dts/hrefv60plus.dts line 29

Quoted 5 lines
arch/arm/boot/dts/hrefv60plus.dts +1 -1
@@ -26,7 +26,7 @@
 
 	soc {
 		i2c at 80110000 {
-			bu21013_tp at 0x5c {
+			bu21013_tp at 5c {

Just a query ... why this one .... ^^^ ...

arch/arm/boot/dts/hrefv60plus.dts line 30

Quoted 1 line
arch/arm/boot/dts/hrefv60plus.dts +0 -0
 				reset-gpio = <&gpio4 15 0x4>;

... and not this one .................................. ^^^ ?

arch/arm/boot/dts/hrefv60plus.dts line 32

Quoted 3 lines
arch/arm/boot/dts/hrefv60plus.dts +0 -0
 			};
 		};

The same for all the other patches in this series.

If this is by design, it might be worth mentioning why some are removed and not others.

Mark J.

author
#66 lore raw
Quoted 23 lines · Mark Jackson
Quoted 10 lines · Lee Jones
---
 arch/arm/boot/dts/hrefv60plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/hrefv60plus.dts +0 -0
index 3d580d6..46fd8af 100644

arch/arm/boot/dts/hrefv60plus.dts line 29

Quoted 5 lines
arch/arm/boot/dts/hrefv60plus.dts +1 -1
@@ -26,7 +26,7 @@
 
 	soc {
 		i2c at 80110000 {
-			bu21013_tp at 0x5c {
+			bu21013_tp at 5c {

Just a query ... why this one .... ^^^ ...

arch/arm/boot/dts/hrefv60plus.dts line 30

Quoted 1 line
arch/arm/boot/dts/hrefv60plus.dts +0 -0
 				reset-gpio = <&gpio4 15 0x4>;

... and not this one .................................. ^^^ ?

Quoted 8 lines

arch/arm/boot/dts/hrefv60plus.dts line 32

Quoted 3 lines
arch/arm/boot/dts/hrefv60plus.dts +0 -0
 			};
 		};

The same for all the other patches in this series.

If this is by design, it might be worth mentioning why some are removed and not others.

I can't explain why there seems to be inconsistencies between node names and the remaining properties. The best I can do is refer you to the documentation where you can see that this is the standard:

Documentation/devicetree/usage-model.txt
and
http://www.devicetree.org/Device_Tree_Usage

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#67 lore raw
Quoted 34 lines · Lee Jones
Quoted 23 lines · Mark Jackson
Quoted 10 lines · Lee Jones
---
 arch/arm/boot/dts/hrefv60plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/hrefv60plus.dts +0 -0
index 3d580d6..46fd8af 100644

arch/arm/boot/dts/hrefv60plus.dts line 29

Quoted 5 lines
arch/arm/boot/dts/hrefv60plus.dts +1 -1
@@ -26,7 +26,7 @@
 
 	soc {
 		i2c at 80110000 {
-			bu21013_tp at 0x5c {
+			bu21013_tp at 5c {

Just a query ... why this one .... ^^^ ...

arch/arm/boot/dts/hrefv60plus.dts line 30

Quoted 1 line
arch/arm/boot/dts/hrefv60plus.dts +0 -0
 				reset-gpio = <&gpio4 15 0x4>;

... and not this one .................................. ^^^ ?

Quoted 8 lines

arch/arm/boot/dts/hrefv60plus.dts line 32

Quoted 3 lines
arch/arm/boot/dts/hrefv60plus.dts +0 -0
 			};
 		};

The same for all the other patches in this series.

If this is by design, it might be worth mentioning why some are removed and not others.

Quoted 7 lines

I can't explain why there seems to be inconsistencies between node names and the remaining properties. The best I can do is refer you to the documentation where you can see that this is the standard:

Documentation/devicetree/usage-model.txt
and
http://www.devicetree.org/Device_Tree_Usage

Ho, ho ... don't you just love "standards" !!

#68 lore raw
In reply to Lee Jones
Quoted 1 line · Lee Jones

None of these patches apply since I applied your other patch series that rename all the files ... can you respin the ux500 "0x"-strip patches on top of the rename set? My ux500-devicetree branch can be used as a baseline.

Yours,
Linus Walleij

author
#69 lore raw
Quoted 8 lines · Linus Walleij
Quoted 1 line · Lee Jones

None of these patches apply since I applied your other patch series that rename all the files ... can you respin the ux500 "0x"-strip patches on top of the rename set? My ux500-devicetree branch can be used as a baseline.

I can do that. Although, would you prefer that I fixed-up my renaming patches, then applied the 0x patches on top instead?

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog