clk: exynos4: Make exynos4_plls static

'exynos4_plls' is used only in this file. Make it static.

Signed-off-by Sachin Kamat <[email protected]>

---
 drivers/clk/samsung/clk-exynos4.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/clk/samsung/clk-exynos4.c +1 -1

index 68f9a4a..fec319d 100644
@@ -984,7 +984,7 @@ static __initdata struct of_device_id ext_clk_match[] = {
        {},
 };
 
-struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {
+static struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {
        [apll] = PLL_A(pll_35xx, fout_apll, "fout_apll", "fin_pll", APLL_LOCK,
                APLL_CON0, "fout_apll", NULL),
        [mpll] = PLL_A(pll_35xx, fout_mpll, "fout_mpll", "fin_pll",

Signature · 1 line

1.7.9.5

Also note:

Review static __initdata struct of_device_id ext_clk_match[] = {

Quoted 1 line · Sachin Kamat

(quoted diff) +0 -0

@@ -984,7 +984,7 @@ static __initdata struct of_device_id ext_clk_match[] = {

For the declaration above...

drivers/clk/samsung/clk-exynos4.c static __initdata struct of_device_id ext_clk_match[] = { · line 987

Quoted 2 lines

drivers/clk/samsung/clk-exynos4.c +1 -1

-struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {
+static struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {

And this one... __initdata should come just before the '=', not at the start, not in the middle and not before the variable.

The reasoning is that with how you have it above, the attributes are applied to the structure. You want to apply the attributes to the declaration instead, so it should come after the variable name.

So, for example:

        struct foo *foo __attribute__((section(".foo"))) = (void *)1;

will place the "foo" variable into a section called ".foo", but:

        struct __attribute__((section(".foo"))) foo *foo = (void *)1;

will place "foo" into the normal .data section.

So, the rule with variable declarations is that the __ specifiers we have as macros in the kernel always come after the variable name being declared and nowhere else. We consider anywhere else buggy.

+CC Joe Perches

Quoted 23 lines · Russell King - ARM Linux

Also note:

Review static __initdata struct of_device_id ext_clk_match[] = {

Quoted 1 line · Sachin Kamat

(quoted diff) +0 -0

@@ -984,7 +984,7 @@ static __initdata struct of_device_id ext_clk_match[] = {

For the declaration above...

drivers/clk/samsung/clk-exynos4.c static __initdata struct of_device_id ext_clk_match[] = { · line 987

Quoted 2 lines

drivers/clk/samsung/clk-exynos4.c +1 -1

-struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {
+static struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {

And this one... __initdata should come just before the '=', not at the start, not in the middle and not before the variable.

The reasoning is that with how you have it above, the attributes are applied to the structure. You want to apply the attributes to the declaration instead, so it should come after the variable name.

So, for example:

        struct foo *foo __attribute__((section(".foo"))) = (void *)1;

will place the "foo" variable into a section called ".foo", but:

Quoted 7 lines

        struct __attribute__((section(".foo"))) foo *foo = (void *)1;

will place "foo" into the normal .data section.

So, the rule with variable declarations is that the __ specifiers we have as macros in the kernel always come after the variable name being declared and nowhere else. We consider anywhere else buggy.

Thanks for this useful tip, Russell. There are several instances in the kernel where these attributes are used at the beginning of the variable declaration.

Probably it would be useful to add this to checkpatch. Joe?

Quoted 34 lines · Sachin Kamat

+CC Joe Perches

Quoted 30 lines · Russell King - ARM Linux

Also note:

Review static __initdata struct of_device_id ext_clk_match[] = {

Quoted 1 line · Sachin Kamat

(quoted diff) +0 -0

@@ -984,7 +984,7 @@ static __initdata struct of_device_id ext_clk_match[] = {

For the declaration above...

drivers/clk/samsung/clk-exynos4.c static __initdata struct of_device_id ext_clk_match[] = { · line 987

Quoted 2 lines

drivers/clk/samsung/clk-exynos4.c +1 -1

-struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {
+static struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {

And this one... __initdata should come just before the '=', not at the start, not in the middle and not before the variable.

The reasoning is that with how you have it above, the attributes are applied to the structure. You want to apply the attributes to the declaration instead, so it should come after the variable name.

So, for example:

        struct foo *foo __attribute__((section(".foo"))) = (void *)1;

will place the "foo" variable into a section called ".foo", but:

        struct __attribute__((section(".foo"))) foo *foo = (void *)1;

will place "foo" into the normal .data section.

So, the rule with variable declarations is that the __ specifiers we have as macros in the kernel always come after the variable name being declared and nowhere else. We consider anywhere else buggy.

Quoted 5 lines

Thanks for this useful tip, Russell. There are several instances in the kernel where these attributes are used at the beginning of the variable declaration.

Probably it would be useful to add this to checkpatch. Joe?

I think Russell is using the royal "We".