Skip to contentSkip to conversation

pc: disable pci-info for 1.6

PATCH In review Michael S. Tsirkin 3 participants 3 messages Aug 8, 2013

lore
Share & tools
lore

Michael S. Tsirkin

author
#0 lore raw

PATCH v2 1/1 pc: disable pci-info for 1.6

The BIOS that we ship in 1.6 does not use pci info from host (yet). Several issues turned up
(e.g. around winXP boot crashes). So it's safest to disable that interface for 1.6 machine types for now, leave it on for 1.7 so we have enough time to figure out the right way
to fix issues if any.

Cc Richard Henderson <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>

---

Changes from v1:
fix reversed logic noted by Richard Henderson

 hw/i386/pc_piix.c | 9 +++++++--
 hw/i386/pc_q35.c  | 9 +++++++--
 2 files changed, 14 insertions(+), 4 deletions(-)
hw/i386/pc_piix.c +7 -2
index ab25458..95c45b8 100644
@@ -249,12 +249,17 @@ static void pc_init_pci(QEMUMachineInitArgs *args)
              initrd_filename, cpu_model, 1, 1);
 }
 
-static void pc_init_pci_1_5(QEMUMachineInitArgs *args)
+static void pc_init_pci_1_6(QEMUMachineInitArgs *args)
 {
     has_pci_info = false;
     pc_init_pci(args);
 }
 
+static void pc_init_pci_1_5(QEMUMachineInitArgs *args)
+{
+    pc_init_pci_1_6(args);
+}
+
 static void pc_init_pci_1_4(QEMUMachineInitArgs *args)
 {
     has_pvpanic = false;

@@ -340,7 +345,7 @@ static QEMUMachine pc_i440fx_machine_v1_6 = {
     .name = "pc-i440fx-1.6",
     .alias = "pc",
     .desc = "Standard PC (i440FX + PIIX, 1996)",
-    .init = pc_init_pci,
+    .init = pc_init_pci_1_6,
     .hot_add_cpu = pc_hot_add_cpu,
     .max_cpus = 255,
     .is_default = 1,
hw/i386/pc_q35.c +7 -2
index 2f35d12..6bfc2ca 100644
@@ -217,12 +217,17 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
     }
 }
 
-static void pc_q35_init_1_5(QEMUMachineInitArgs *args)
+static void pc_q35_init_1_6(QEMUMachineInitArgs *args)
 {
     has_pci_info = false;
     pc_q35_init(args);
 }
 
+static void pc_q35_init_1_5(QEMUMachineInitArgs *args)
+{
+    pc_q35_init_1_6(args);
+}
+
 static void pc_q35_init_1_4(QEMUMachineInitArgs *args)
 {
     has_pvpanic = false;

@@ -234,7 +239,7 @@ static QEMUMachine pc_q35_machine_v1_6 = {
     .name = "pc-q35-1.6",
     .alias = "q35",
     .desc = "Standard PC (Q35 + ICH9, 2009)",
-    .init = pc_q35_init,
+    .init = pc_q35_init_1_6,
     .hot_add_cpu = pc_hot_add_cpu,
     .max_cpus = 255,
     DEFAULT_MACHINE_OPTIONS,
Signature · 1 line
MST
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Michael S. Tsirkin

The BIOS that we ship in 1.6 does not use pci info from host (yet). Several issues turned up
(e.g. around winXP boot crashes). So it's safest to disable that interface for 1.6 machine types for now, leave it on for 1.7 so we have enough time to figure out the right way
to fix issues if any.

Cc Richard Henderson <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>
Reviewed-by Richard Henderson <[email protected]>

r~

Reviewed-by on v2 1/1
#2 lore raw
In reply to Michael S. Tsirkin

Am 08.08.2013 17:55, schrieb Michael S. Tsirkin:

Quoted 9 lines

The BIOS that we ship in 1.6 does not use pci info from host (yet). Several issues turned up
(e.g. around winXP boot crashes). So it's safest to disable that interface for 1.6 machine types for now, leave it on for 1.7 so we have enough time to figure out the right way
to fix issues if any.

Cc Richard Henderson <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>

Looks correct now,

Reviewed-by Andreas Färber <[email protected]>

Andreas

Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg