Skip to contentSkip to conversation

sound: oss/dmabuf: remove an unneeded temporary variable

PATCH Applied Dan Carpenter 2 participants 3 messages Aug 9, 2013

Subsystems (2)
Sound Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sound: oss/dmabuf: remove an unneeded temporary variable

We don't actually use the "go" variable so it can be removed.

Signed-off-by Dan Carpenter <[email protected]>
sound/oss/dmabuf.c +1 -2
index a59c888..461d94c 100644
@@ -557,7 +557,6 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
 	unsigned long flags;
 	int err = 0, n = 0;
 	struct dma_buffparms *dmap = adev->dmap_in;
-	int go;
 
 	if (!(adev->open_mode & OPEN_READ))
 		return -EIO;

@@ -584,7 +583,7 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
 			spin_unlock_irqrestore(&dmap->lock,flags);
 			return -EAGAIN;
 		}
-		if ((go = adev->go))
+		if (adev->go)
 			timeout = dmabuf_timeout(dmap);
 
 		spin_unlock_irqrestore(&dmap->lock,flags);
Applied
#1 lore raw

At Fri, 9 Aug 2013 12:57:06 +0300,

Quoted 4 lines · Dan Carpenter

We don't actually use the "go" variable so it can be removed.

Signed-off-by Dan Carpenter <[email protected]>

Thanks, applied.

Takashi

Quoted 27 lines
sound/oss/dmabuf.c +1 -2
index a59c888..461d94c 100644
@@ -557,7 +557,6 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
 	unsigned long flags;
 	int err = 0, n = 0;
 	struct dma_buffparms *dmap = adev->dmap_in;
-	int go;
 
 	if (!(adev->open_mode & OPEN_READ))
 		return -EIO;

@@ -584,7 +583,7 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
 			spin_unlock_irqrestore(&dmap->lock,flags);
 			return -EAGAIN;
 		}
-		if ((go = adev->go))
+		if (adev->go)
 			timeout = dmabuf_timeout(dmap);
 
 		spin_unlock_irqrestore(&dmap->lock,flags);

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Applied
#2 lore raw
In reply to Dan Carpenter

At Fri, 9 Aug 2013 12:57:06 +0300,

Quoted 4 lines · Dan Carpenter

We don't actually use the "go" variable so it can be removed.

Signed-off-by Dan Carpenter <[email protected]>

Thanks, applied.

Takashi

Quoted 23 lines
sound/oss/dmabuf.c +1 -2
index a59c888..461d94c 100644
@@ -557,7 +557,6 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
 	unsigned long flags;
 	int err = 0, n = 0;
 	struct dma_buffparms *dmap = adev->dmap_in;
-	int go;
 
 	if (!(adev->open_mode & OPEN_READ))
 		return -EIO;

@@ -584,7 +583,7 @@ int DMAbuf_getrdbuffer(int dev, char **buf, int *len, int dontblock)
 			spin_unlock_irqrestore(&dmap->lock,flags);
 			return -EAGAIN;
 		}
-		if ((go = adev->go))
+		if (adev->go)
 			timeout = dmabuf_timeout(dmap);
 
 		spin_unlock_irqrestore(&dmap->lock,flags);