Skip to contentSkip to conversation

iwlwifi: pcie: returning positive instead of negative

PATCH Applied Dan Carpenter 2 participants 2 messages Aug 10, 2013 – Aug 12, 2013

Subsystems (2)
Kernel janitors Networking drivers (wireless)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 iwlwifi: pcie: returning positive instead of negative

There is a missing '-' character here so we return positive 'ENOMEM' instead of negative. The caller doesn't care. All non-zero returns are translated to '-ENOMEM' in iwl_pcie_nic_init().

This is just a cleanup.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/iwlwifi/pcie/tx.c +1 -1
index 134f7a1..a81d227 100644
@@ -829,7 +829,7 @@ static int iwl_pcie_tx_alloc(struct iwl_trans *trans)
 				  sizeof(struct iwl_txq), GFP_KERNEL);
 	if (!trans_pcie->txq) {
 		IWL_ERR(trans, "Not enough memory for txq\n");
-		ret = ENOMEM;
+		ret = -ENOMEM;
 		goto error;
 	}
maintainer Applied
#1 lore raw
Quoted 5 lines · Dan Carpenter

There is a missing '-' character here so we return positive 'ENOMEM' instead of negative. The caller doesn't care. All non-zero returns are translated to '-ENOMEM' in iwl_pcie_nic_init().

This is just a cleanup.

Applied, thanks.

johannes