regulator: da9210: Remove redundant MODULE_ALIAS

PATCH Superseded Axel Lin 2 participants 5 messages Aug 9, 2013 – Aug 11, 2013

Subsystems (2)

Voltage and current regulator framework Dialog semiconductor drivers

lore

Share & tools

lore

Axel Lin

author

2013-08-09 16:26 UTC #0 lore raw

PATCH 1/1 regulator: da9210: Remove redundant MODULE_ALIAS

The modalias is set by the MODULE_DEVICE_TABLE, thus remove redundant MODULE_ALIAS. Also Fix trivial typo for the author name.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/regulator/da9210-regulator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/regulator/da9210-regulator.c +1 -2

index bf492bc..1597bf8 100644
@@ -191,7 +191,6 @@ static struct i2c_driver da9210_regulator_driver = {
 
 module_i2c_driver(da9210_regulator_driver);
 
-MODULE_AUTHOR("S Twiss <[email protected]>");
+MODULE_AUTHOR("Steve Twiss <[email protected]>");
 MODULE_DESCRIPTION("Regulator device driver for Dialog DA9210");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("i2c:da9210");

Signature · 1 line

1.8.1.2

Mark Brown

maintainer

2013-08-09 16:41 UTC #1 lore raw

drivers/regulator/da9210-regulator.c static struct i2c_driver da9210_regulator_driver = { · line 194

Quoted 2 lines · Axel Lin

drivers/regulator/da9210-regulator.c +1 -1

-MODULE_AUTHOR("S Twiss <[email protected]>");
+MODULE_AUTHOR("Steve Twiss <[email protected]>");

It's perfectly reasonable for someone to want to be referred to by their initial, or their full spelled out name, or a nickname, or...

Axel Lin

author

2013-08-10 02:13 UTC #2 lore raw

2013/8/10 Mark Brown <[email protected]>:

Quoted 7 lines · Axel Lin

drivers/regulator/da9210-regulator.c static struct i2c_driver da9210_regulator_driver = { · line 194
Quoted 3 lines
drivers/regulator/da9210-regulator.c +1 -1
-MODULE_AUTHOR("S Twiss <[email protected]>");
+MODULE_AUTHOR("Steve Twiss <[email protected]>");
It's perfectly reasonable for someone to want to be referred to by their initial, or their full spelled out name, or a nickname, or...

Oh, I didn't realize that naming could be intentional.... If Steve does not confirm this fix is good, I'll send a v2.

Mark Brown

maintainer

2013-08-11 14:42 UTC #3 lore raw

Quoted 11 lines · Axel Lin

2013/8/10 Mark Brown <[email protected]>:
Quoted 7 lines · Axel Lin
drivers/regulator/da9210-regulator.c static struct i2c_driver da9210_regulator_driver = { · line 194
Quoted 3 lines
drivers/regulator/da9210-regulator.c +1 -1
-MODULE_AUTHOR("S Twiss <[email protected]>");
+MODULE_AUTHOR("Steve Twiss <[email protected]>");
It's perfectly reasonable for someone to want to be referred to by their initial, or their full spelled out name, or a nickname, or...
Oh, I didn't realize that naming could be intentional.... If Steve does not confirm this fix is good, I'll send a v2.

Think JK Rowling or CS Lewis :)

Axel Lin

author

2013-08-11 15:04 UTC #4 lore raw

2013/8/11 Mark Brown <[email protected]>:

Quoted 10 lines · Axel Lin

Quoted 8 lines
2013/8/10 Mark Brown <[email protected]>:
Quoted 7 lines · Axel Lin
drivers/regulator/da9210-regulator.c static struct i2c_driver da9210_regulator_driver = { · line 194
Quoted 3 lines
drivers/regulator/da9210-regulator.c +1 -1
-MODULE_AUTHOR("S Twiss <[email protected]>");
+MODULE_AUTHOR("Steve Twiss <[email protected]>");
It's perfectly reasonable for someone to want to be referred to by their initial, or their full spelled out name, or a nickname, or...

Quoted 4 lines

Quoted 2 lines
Oh, I didn't realize that naming could be intentional.... If Steve does not confirm this fix is good, I'll send a v2.
Think JK Rowling or CS Lewis :)

Haha, Probably just because I speak Mandarin and I don't really understand the English naming rule. I'm sending v2 right now.

Axel