Skip to contentSkip to conversation

ARM: dma: default ZONE_DMA to y if ARM_LPAE

RFC PATCH New Will Deacon 3 participants 5 messages Jul 26, 2013 – Aug 11, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 ARM: dma: default ZONE_DMA to y if ARM_LPAE

On systems running with LPAE enabled, DMA masters capable only of 32-bit addressing require ZONE_DMA to be set. Given the proliferation of such masters, and the tendency to re-use existing system IP with newer processors, this patch defaults ZONE_DMA to y if ARM_LPAE, rather than force each SoC to select it individually.

Cc Olof Johansson <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +1 -0
index 82f06982..7fede35 100644
@@ -192,6 +192,7 @@ config ARCH_MAY_HAVE_PC_FDC
 
 config ZONE_DMA
 	bool
+	default y if ARM_LPAE
 
 config NEED_DMA_MAP_STATE
        def_bool y
Signature · 1 line
1.8.2.2
#1 lore raw

RFC PATCH 1/1 ARM: dma: default ZONE_DMA to y if ARM_LPAE

Quoted 17 lines · Will Deacon

On systems running with LPAE enabled, DMA masters capable only of 32-bit addressing require ZONE_DMA to be set. Given the proliferation of such masters, and the tendency to re-use existing system IP with newer processors, this patch defaults ZONE_DMA to y if ARM_LPAE, rather than force each SoC to select it individually.

Cc Olof Johansson <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index 82f06982..7fede35 100644

arch/arm/Kconfig config ARCH_MAY_HAVE_PC_FDC · line 195

Quoted 4 lines
arch/arm/Kconfig +1 -0
@@ -192,6 +192,7 @@ config ARCH_MAY_HAVE_PC_FDC
 
 config ZONE_DMA
 	bool
+	default y if ARM_LPAE

I guess you could bikeshed over this vs selecting it from ARM_LPAE, but either way gets the work done. I don't have a preference.

..for Russell's patch tracker?

-Olof

#2 lore raw

RFC PATCH 1/1 ARM: dma: default ZONE_DMA to y if ARM_LPAE

Quoted 26 lines · Olof Johansson
Quoted 17 lines · Will Deacon

On systems running with LPAE enabled, DMA masters capable only of 32-bit addressing require ZONE_DMA to be set. Given the proliferation of such masters, and the tendency to re-use existing system IP with newer processors, this patch defaults ZONE_DMA to y if ARM_LPAE, rather than force each SoC to select it individually.

Cc Olof Johansson <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index 82f06982..7fede35 100644

arch/arm/Kconfig config ARCH_MAY_HAVE_PC_FDC · line 195

Quoted 4 lines
arch/arm/Kconfig +1 -0
@@ -192,6 +192,7 @@ config ARCH_MAY_HAVE_PC_FDC
 
 config ZONE_DMA
 	bool
+	default y if ARM_LPAE

I guess you could bikeshed over this vs selecting it from ARM_LPAE, but either way gets the work done. I don't have a preference.

Quoted 3 lines

..for Russell's patch tracker?

No. As I keep telling people, go look at my dma-mask patches and stop papering over this problem.

#3 lore raw

RFC PATCH 1/1 ARM: dma: default ZONE_DMA to y if ARM_LPAE

Quoted 2 lines · Russell King - ARM Linux

No. As I keep telling people, go look at my dma-mask patches and stop papering over this problem.

Ah, yes, I'm going through email backlog. The DMA mask series will definitely cover this in a better way.

This is a minimal patch that could be suitable for -stable backport. If we care about that -- I'm sure people can just amend their configs where needed.

-Olof

#4 lore raw

RFC PATCH 1/1 ARM: dma: default ZONE_DMA to y if ARM_LPAE

Quoted 6 lines · Olof Johansson
Quoted 2 lines · Russell King - ARM Linux

No. As I keep telling people, go look at my dma-mask patches and stop papering over this problem.

Quoted 6 lines

Ah, yes, I'm going through email backlog. The DMA mask series will definitely cover this in a better way.

This is a minimal patch that could be suitable for -stable backport. If we care about that -- I'm sure people can just amend their configs where needed.

Well, it's not a regression, it's something which has never worked. In my mind, that isn't really -stable material - stable is for stuff that was either working and has been broken or for security stuff.

Having all your system memory above 4G _and_ having 32-bit DMA masks is something which never worked.