Skip to contentSkip to conversation

exynos: video: change mipi dsi write function parameters correctly

PATCH RESEND New Donghwa Lee 2 participants 2 messages Aug 5, 2013 – Aug 12, 2013

Subsystems (4)
Arm (32-bit) Framebuffer layer Arm Samsung Exynos Arm/actions semi architecture
lore
Share & tools
lore

Donghwa Lee

author
#0 lore raw

PATCH RESEND 1/1 exynos: video: change mipi dsi write function parameters correctly

This patch have changed mipi dsi write functions' parameters correctly so that type cast operations were removed. And mipi dsi payload is composed with array of panel commands to improve readability.

Signed-off-by Donghwa Lee <[email protected]>
---
 arch/arm/include/asm/arch-exynos/mipi_dsim.h |    2 +-
 drivers/video/exynos_mipi_dsi_common.c       |   62 ++++++++++++--------------
 drivers/video/exynos_mipi_dsi_common.h       |    2 +-
 drivers/video/exynos_mipi_dsi_lowlevel.c     |    2 +-
 drivers/video/exynos_mipi_dsi_lowlevel.h     |    2 +-
 drivers/video/s6e8ax0.c                      |   59 +++++++++++++-----------
 6 files changed, 66 insertions(+), 63 deletions(-)
arch/arm/include/asm/arch-exynos/mipi_dsim.h +1 -1
index b73263d..afe7c08 100644
@@ -304,7 +304,7 @@ struct exynos_platform_mipi_dsim {
  */
 struct mipi_dsim_master_ops {
 	int (*cmd_write)(struct mipi_dsim_device *dsim, unsigned int data_id,
-		unsigned int data0, unsigned int data1);
+		const unsigned char *data0, unsigned int data1);
 	int (*cmd_read)(struct mipi_dsim_device *dsim, unsigned int data_id,
 		unsigned int data0, unsigned int data1);
 	int (*get_dsim_frame_done)(struct mipi_dsim_device *dsim);
drivers/video/exynos_mipi_dsi_common.c +29 -33

121 lines not on this page · raw message

drivers/video/exynos_mipi_dsi_common.h +1 -1
index 4d80679..af0a695 100644
@@ -26,7 +26,7 @@
 #define _EXYNOS_MIPI_DSI_COMMON_H
 
 int exynos_mipi_dsi_wr_data(struct mipi_dsim_device *dsim, unsigned int data_id,
-	unsigned int data0, unsigned int data1);
+	const unsigned char *data0, unsigned int data1);
 int exynos_mipi_dsi_pll_on(struct mipi_dsim_device *dsim, unsigned int enable);
 unsigned long exynos_mipi_dsi_change_pll(struct mipi_dsim_device *dsim,
 	unsigned int pre_divider, unsigned int main_divider,
drivers/video/exynos_mipi_dsi_lowlevel.c +1 -1
index d61b773..00248f0 100644
@@ -613,7 +613,7 @@ unsigned int exynos_mipi_dsi_get_fifo_state(struct mipi_dsim_device *dsim)
 }
 
 void exynos_mipi_dsi_wr_tx_header(struct mipi_dsim_device *dsim,
-	unsigned int di, unsigned int data0, unsigned int data1)
+	unsigned int di, const unsigned char data0, const unsigned char data1)
 {
 	struct exynos_mipi_dsim *mipi_dsim =
 		(struct exynos_mipi_dsim *)samsung_get_base_mipi_dsim();
drivers/video/exynos_mipi_dsi_lowlevel.h +1 -1
index 4b8c441..1d62cc2 100644
@@ -104,7 +104,7 @@ unsigned int _exynos_mipi_dsi_get_frame_done_status(struct mipi_dsim_device
 						*dsim);
 void _exynos_mipi_dsi_clear_frame_done(struct mipi_dsim_device *dsim);
 void exynos_mipi_dsi_wr_tx_header(struct mipi_dsim_device *dsim,
-		unsigned int di, unsigned int data0, unsigned int data1);
+		unsigned int di, const unsigned char data0, const unsigned char data1);
 void exynos_mipi_dsi_wr_tx_data(struct mipi_dsim_device *dsim,
 		unsigned int tx_data);
drivers/video/s6e8ax0.c +33 -26

158 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH RESEND 1/1 exynos: video: change mipi dsi write function parameters correctly

Quoted 5 lines · On Mon, 05 Aug 2013 13:34:32 +0900 Donghwa Lee <[email protected]> wrote:

This patch have changed mipi dsi write functions' parameters correctly so that type cast operations were removed. And mipi dsi payload is composed with array of panel commands to improve readability.

Signed-off-by Donghwa Lee <[email protected]>
Quoted 8 lines
---
 arch/arm/include/asm/arch-exynos/mipi_dsim.h |    2 +-
 drivers/video/exynos_mipi_dsi_common.c       |   62 ++++++++++++--------------
 drivers/video/exynos_mipi_dsi_common.h       |    2 +-
 drivers/video/exynos_mipi_dsi_lowlevel.c     |    2 +-
 drivers/video/exynos_mipi_dsi_lowlevel.h     |    2 +-
 drivers/video/s6e8ax0.c                      |   59 +++++++++++++-----------
 6 files changed, 66 insertions(+), 63 deletions(-)

Applied to u-boot-video/master. Thanks!

Anatolij