Skip to contentSkip to conversation

edid: rename struct member to fix two EDID_* macros

PATCH New Christian Gmeiner 2 participants 3 messages Aug 7, 2013 – Aug 12, 2013

lore
Share & tools
lore

Christian Gmeiner

author
#0 lore raw

PATCH 1/1 edid: rename struct member to fix two EDID_* macros

Without this change EDID_DETAILED_TIMING_VSYNC_OFFSET and EDID_DETAILED_TIMING_VSYNC_PULSE_WIDTH macros can not be used (compile error).
The fix is quite trivial: rename struct member to the expected name.

Signed-off-by Christian Gmeiner <[email protected]>
---
 include/edid.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/edid.h +1 -1
index f153091..480a773 100644
@@ -54,7 +54,7 @@ struct edid_detailed_timing {
 	 (_x).vertical_blanking)
 	unsigned char hsync_offset;
 	unsigned char hsync_pulse_width;
-	unsigned char sync_offset_pulse_width;
+	unsigned char vsync_offset_pulse_width;
 	unsigned char hsync_vsync_offset_pulse_width_hi;
 #define EDID_DETAILED_TIMING_HSYNC_OFFSET(_x) \
 	((GET_BITS((_x).hsync_vsync_offset_pulse_width_hi, 7, 6) << 8) + \
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/1 edid: rename struct member to fix two EDID_* macros

2013/8/7 Christian Gmeiner <[email protected]>:

Quoted 25 lines

Without this change EDID_DETAILED_TIMING_VSYNC_OFFSET and EDID_DETAILED_TIMING_VSYNC_PULSE_WIDTH macros can not be used (compile error).
The fix is quite trivial: rename struct member to the expected name.

Signed-off-by Christian Gmeiner <[email protected]>
---
 include/edid.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/edid.h +1 -2
index f153091..480a773 100644
@@ -54,7 +54,7 @@ struct edid_detailed_timing {
         (_x).vertical_blanking)
        unsigned char hsync_offset;
        unsigned char hsync_pulse_width;
-       unsigned char sync_offset_pulse_width;
+       unsigned char vsync_offset_pulse_width;
        unsigned char hsync_vsync_offset_pulse_width_hi;
 #define EDID_DETAILED_TIMING_HSYNC_OFFSET(_x) \
        ((GET_BITS((_x).hsync_vsync_offset_pulse_width_hi, 7, 6) << 8) + \
--
Quoted 2 lines

1.7.10.4

ping
--
Christian Gmeiner, MSc

#2 lore raw

PATCH 1/1 edid: rename struct member to fix two EDID_* macros

In reply to Christian Gmeiner
Quoted 10 lines · On Wed, 7 Aug 2013 09:22:33 +0200 Christian Gmeiner…

Without this change EDID_DETAILED_TIMING_VSYNC_OFFSET and EDID_DETAILED_TIMING_VSYNC_PULSE_WIDTH macros can not be used (compile error).
The fix is quite trivial: rename struct member to the expected name.

Signed-off-by Christian Gmeiner <[email protected]>
---
 include/edid.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master. Thanks!

Anatolij