wistron_btns: drop bogus MODULE_VERSION macro
Subsystems (3)
PATCH 1/3 wistron_btns: drop bogus MODULE_VERSION macro
MODULE_VERSION is pointless for an in-kernel module and git log confirms that it has never been actually maintained as well (bumped a single time, despite quite major feature additions later on, which haven't been reflected in MODULE_VERSION).
--- drivers/input/misc/wistron_btns.c | 1 - 1 file changed, 1 deletion(-)
drivers/input/misc/wistron_btns.c +0 -1
@@ -46,7 +46,6 @@MODULE_AUTHOR ("Miloslav Trmac <[email protected]>" );MODULE_DESCRIPTION ("Wistron laptop button driver" );MODULE_LICENSE ("GPL v2" ); -MODULE_VERSION ("0.3" );static bool force;/* = 0; */ module_param (force, bool,0 );
PATCH 2/3 wistron_btns: mark the Medion MD96500 keymap as tested
DMI: MEDIONPC WIM 2040/WIM 2040, BIOS R01-A0O 11/04/2005wistron_btns: BIOS signature found at c00f6b00, entry point 000FDD50
input: Wistron laptop buttons as /devices/platform/wistron-bios/input/input5
--- drivers/input/misc/wistron_btns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/wistron_btns.c +1 -1
@@ -562,7 +562,7 @@ static struct key_entry keymap_wistron_m { KE_KEY, 0x36, {KEY_WWW} }, { KE_WIFI, 0x30 }, { KE_BLUETOOTH, 0x44 }, - { KE_END, FE_UNTESTED } + { KE_END, 0 } }; static struct key_entry keymap_wistron_generic[] __initdata = {
PATCH 3/3 wistron_btns: add MODULE_DEVICE_TABLE
In reply to Stefan Lippers-HollmannThis allows the wistron_btns module to be autoloaded on boot, its functionality is required to support the hardware rfkill switches on most of the supported notebooks, in order to unblock the hard blocked rfkill state for wireless and bluetooth devices.
Tested on a Medion MD96500:
alias: dmi*:svn*MEDIONPC*:pn*WIM2040*:
---
This patch may be considered RFC, while it is certainly the right thing to do, some of the DMI matches might be a bit wide, e.g.:
dmi*:svn*FUJITSUSIEMENS*:pn*AMILOD*:
dmi*:svn*FUJITSUSIEMENS*:pn*AmiloD*:
dmi*:svn*FUJITSUSIEMENS*:pn*AMILOM*:
all others are very targetted - and I haven't noticed any issues by forcing wistron_btns on system not requiring it so far.
drivers/input/misc/wistron_btns.c | 1 + 1 file changed, 1 insertion(+)
drivers/input/misc/wistron_btns.c +1 -0
@@ -971,6 +971,7 @@ static const struct dmi_system_id __init }, { NULL, } }; +MODULE_DEVICE_TABLE (dmi, dmi_ids);/* Copy the good keymap, as the original ones are free'd */ static int __init copy_keymap (void )