Skip to contentSkip to conversation

dma: mmp_pdma: Staticize mmp_pdma_alloc_descriptor()

PATCH Applied Jingoo Han 2 participants 2 messages Aug 6, 2013 – Aug 13, 2013 dmaengine

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/3 dma: mmp_pdma: Staticize mmp_pdma_alloc_descriptor()

mmp_pdma_alloc_descriptor() is used only in this file. Fix the following sparse warning:

drivers/dma/mmp_pdma.c:359:25: warning: symbol 'mmp_pdma_alloc_descriptor' was not declared. Should it be static?

---
 drivers/dma/mmp_pdma.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/mmp_pdma.c +2 -1
index 9a32f2d..3bf9c91 100644
@@ -356,7 +356,8 @@ static dma_cookie_t mmp_pdma_tx_submit(struct dma_async_tx_descriptor *tx)
 	return cookie;
 }
 
-struct mmp_pdma_desc_sw *mmp_pdma_alloc_descriptor(struct mmp_pdma_chan *chan)
+static struct mmp_pdma_desc_sw *
+mmp_pdma_alloc_descriptor(struct mmp_pdma_chan *chan)
 {
 	struct mmp_pdma_desc_sw *desc;
 	dma_addr_t pdesc;
Signature · 1 line
1.7.10.4
Applied
#1 lore raw
Quoted 6 lines · Jingoo Han

mmp_pdma_alloc_descriptor() is used only in this file. Fix the following sparse warning:

drivers/dma/mmp_pdma.c:359:25: warning: symbol 'mmp_pdma_alloc_descriptor' was not declared. Should it be static?

Applied all three, thanks

~Vinod