ARM: sunxi: dt: Add device tree for Mele A1000
Subsystems (3)
PATCH 1/1 ARM: sunxi: dt: Add device tree for Mele A1000
This adds a device tree usable on Mele A1000 (and A2000, as it apparently is the same device except for the case). This device features one UART port, Ethernet, an AXP209 PMU on i2c0 and two user configurable LEDs.
---
This has been tested by arokux on #linux-sunxi in Freenode and found to work correctly.
arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/sun4i-a10-a1000.dts | 106 ++++++++++++++++++++++++++++++++++ 2 files changed, 107 insertions(+) create mode 100644 arch/arm/boot/dts/sun4i-a10-a1000.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -206,6 +206,7 @@ dtb-$(CONFIG_ARCH_STI)+= stih415-b2000.dtb \ stih415-b2020.dtb \ stih416-b2020.dtb dtb-$(CONFIG_ARCH_SUNXI) += \ + sun4i-a10-a1000.dtb \ sun4i-a10-cubieboard.dtb \ sun4i-a10-mini-xplus.dtb \ sun4i-a10-hackberry.dtb \
arch/arm/boot/dts/sun4i-a10-a1000.dts new file +106 -0
106 lines not on this page · raw message
Signature · 1 line
1.8.3.4
PATCH 1/1 ARM: sunxi: dt: Add device tree for Mele A1000
Hi Emilio,
Quoted 51 lines · Emilio L?pez
This adds a device tree usable on Mele A1000 (and A2000, as it apparently is the same device except for the case). This device features one UART port, Ethernet, an AXP209 PMU on i2c0 and two user configurable LEDs.
Signed-off-by Emilio L?pez <[email protected]>---
This has been tested by arokux on #linux-sunxi in Freenode and found to work correctly.
arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/sun4i-a10-a1000.dts | 106 ++++++++++++++++++++++++++++++++++ 2 files changed, 107 insertions(+) create mode 100644 arch/arm/boot/dts/sun4i-a10-a1000.dtsarch/arm/boot/dts/Makefile +1
-0@@ -206,6 +206,7 @@ dtb-$(CONFIG_ARCH_STI)+= stih415-b2000.dtb \ stih415-b2020.dtb \ stih416-b2020.dtb dtb-$(CONFIG_ARCH_SUNXI) += \ + sun4i-a10-a1000.dtb \ sun4i-a10-cubieboard.dtb \ sun4i-a10-mini-xplus.dtb \ sun4i-a10-hackberry.dtb \arch/arm/boot/dts/sun4i-a10-a1000.dts new file +17
-0@@ -0,0 +1,106 @@ +/* + * Copyright 2013 Emilio L?pez + * + * Emilio L?pez <[email protected]> + * + * The code contained herein is licensed under the GNU General Public + * License. You may obtain a copy of the GNU General Public License + * Version 2 or later at the following locations: + * + * http://www.opensource.org/licenses/gpl-license.html + * http://www.gnu.org/copyleft/gpl.html + */ + +/dts-v1/; +/include/ "sun4i-a10.dtsi" + +/ {
arch/arm/boot/dts/sun4i-a10-a1000.dts line 27
Quoted 10 lines
arch/arm/boot/dts/sun4i-a10-a1000.dts new file +10
-0+ model = "Mele A1000"; + compatible = "mele,a1000", "allwinner,sun4i-a10"; + + aliases { + serial0 = &uart0; + }; + + chosen { + bootargs = "earlyprintk console=ttyS0,115200"; + };
That's not quite useful anymore now that we have a DT-aware bootloader, I'd remove it.
Quoted 18 lines
arch/arm/boot/dts/sun4i-a10-a1000.dts new file +18
-0+ + soc at 01c20000 { + emac: ethernet at 01c0b000 { + pinctrl-names = "default"; + pinctrl-0 = <&emac_pins_a>; + phy = <&phy1>; + status = "okay"; + }; + + mdio at 01c0b080 { + phy-supply = <®_emac_3v3>; + status = "okay"; + + phy1: ethernet-phy at 1 { + reg = <1>; + }; + }; +
arch/arm/boot/dts/sun4i-a10-a1000.dts line 55
Quoted 10 lines
arch/arm/boot/dts/sun4i-a10-a1000.dts new file +10
-0+ pinctrl at 01c20800 { + pinctrl-names = "default"; + pinctrl-0 = <&a1000_hogs>; + + a1000_hogs: hogs at 0 { + allwinner,pins = "PH15"; + allwinner,function = "gpio_out"; + allwinner,drive = <0>; + allwinner,pull = <0>; + };
Why using the hog pins here? I don't think you require it anymore, just grab the pinctrl node from the regulator, it should work, right?
arch/arm/boot/dts/sun4i-a10-a1000.dts line 60
Quoted 5 lines
arch/arm/boot/dts/sun4i-a10-a1000.dts new file +5
-0+ + led_pins_a1000: led_pins at 0 { + allwinner,pins = "PH10", "PH20"; + allwinner,function = "gpio_out"; + allwinner,drive = <1>;
Do you really need the extra 10 mA here?
Quoted 49 lines
arch/arm/boot/dts/sun4i-a10-a1000.dts new file +46
-0+ allwinner,pull = <0>; + }; + }; + + uart0: serial at 01c28000 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pins_a>; + status = "okay"; + }; + + i2c0: i2c at 01c2ac00 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins_a>; + status = "okay"; + }; + }; + + leds { + compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&led_pins_a1000>; + + red { + label = "a1000:red:usr"; + gpios = <&pio 7 10 0>; + }; + + blue { + label = "a1000:blue:usr"; + gpios = <&pio 7 20 0>; + }; + }; + + regulators { + compatible = "simple-bus"; + + reg_emac_3v3: emac-3v3 { + compatible = "regulator-fixed"; + regulator-name = "emac-3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + gpio = <&pio 7 15 0>; + }; + }; +};Signature · 1 line
1.8.3.4
Thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130813/eb6377c4/attachment.sig>
PATCH v2 1/1 ARM: sunxi: dt: Add device tree for Mele A1000
This adds a device tree usable on Mele A1000 (and A2000, as it apparently is the same device except for the case). This device features one UART port, Ethernet, an AXP209 PMU on i2c0 and two user configurable LEDs.
---
Maxime, this v2 should address all your comments.
Cheers,
Emilio
arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/sun4i-a10-a1000.dts | 101 ++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+) create mode 100644 arch/arm/boot/dts/sun4i-a10-a1000.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -206,6 +206,7 @@ dtb-$(CONFIG_ARCH_STI)+= stih415-b2000.dtb \ stih415-b2020.dtb \ stih416-b2020.dtb dtb-$(CONFIG_ARCH_SUNXI) += \ + sun4i-a10-a1000.dtb \ sun4i-a10-cubieboard.dtb \ sun4i-a10-mini-xplus.dtb \ sun4i-a10-hackberry.dtb \
arch/arm/boot/dts/sun4i-a10-a1000.dts new file +101 -0
101 lines not on this page · raw message
Signature · 1 line
1.8.3.4
PATCH v2 1/1 ARM: sunxi: dt: Add device tree for Mele A1000
Quoted 6 lines · Emilio L?pez
This adds a device tree usable on Mele A1000 (and A2000, as it apparently is the same device except for the case). This device features one UART port, Ethernet, an AXP209 PMU on i2c0 and two user configurable LEDs.
Signed-off-by Emilio L?pez <[email protected]>
Applied with a minor fix to the soc node address on my sunxi/dt-for-3.12 branch.
Thanks,
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130814/bcbfefa0/attachment.sig>
A message that is not in the archive (sent off-list or not yet received): CAPNxggYC8=MHp2MJHrhVsvc7vWe9mgQHYF+ata0CO2X8-75KAg@mail.gmail.com
PATCH 1/1 ARM: sunxi: dt: Add device tree for Mele A1000
Quoted 1 line · Arokux X
Tested-by Arokux <[email protected]>
We won't take any contributions using a pseudonym. Please use your real name.
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130814/b633e4c3/attachment-0001.sig>