Skip to contentSkip to conversation

Correct misspelled caching

PATCH In review Sedat Dilek 2 participants 5 messages Aug 14, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Correct misspelled caching

---
 configure.ac   |  4 ++--
 src/sna/kgem.c | 50 +++++++++++++++++++++++++-------------------------
 src/sna/kgem.h |  2 +-
 3 files changed, 28 insertions(+), 28 deletions(-)
configure.ac +2 -2
index 43c33eb..211a086 100644
@@ -371,12 +371,12 @@ fi
 
 AC_ARG_ENABLE(wt,
 	      AS_HELP_STRING([--enable-wt],
-			     [Enable use of WT cacheing (experimental) [default=no]]),
+			     [Enable use of WT caching (experimental) [default=no]]),
 	      [WT="$enableval"],
 	      [WT=no])
 AM_CONDITIONAL(USE_WT, test x$WT = xyes)
 if test "x$WT" = xyes; then
-	AC_DEFINE(USE_WT,1,[Assume WriteThrough cacheing support])
+	AC_DEFINE(USE_WT,1,[Assume WriteThrough caching support])
 	xp_msg="$xp_msg wt-cache"
 fi
 
src/sna/kgem.c +25 -25

146 lines not on this page · raw message

src/sna/kgem.h +1 -1
index e08f842..63bba4c 100644
@@ -177,7 +177,7 @@ struct kgem {
 	uint32_t has_semaphores :1;
 	uint32_t has_secure_batches :1;
 	uint32_t has_pinned_batches :1;
-	uint32_t has_cacheing :1;
+	uint32_t has_caching :1;
 	uint32_t has_llc :1;
 	uint32_t has_wt :1;
 	uint32_t has_no_reloc :1;
Signature · 1 line
1.8.3.4
#2 lore raw
Quoted 4 lines · Chris Wilson
Quoted 1 line · Sedat Dilek

Am I the only one who reads that as a hard 'ch' without the 'e'?

I am not an English native or teacher: But from what I know it's... to cache | caching | cached.
Google gives me no hits for cach*e*ing.
Anyway, the spelling should be consistent in kernel-drm | libdrm | intel-ddx | etc.

- Sedat -

#3 lore raw
Quoted 11 lines · Sedat Dilek
Quoted 4 lines · Chris Wilson
Quoted 1 line · Sedat Dilek

Am I the only one who reads that as a hard 'ch' without the 'e'?

I am not an English native or teacher: But from what I know it's... to cache | caching | cached.
Google gives me no hits for cach*e*ing.
Anyway, the spelling should be consistent in kernel-drm | libdrm | intel-ddx | etc.

It was. I blame Ben.
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#4 lore raw
Quoted 7 lines · Chris Wilson
Quoted 6 lines · Sedat Dilek
Quoted 4 lines · Chris Wilson
Quoted 1 line · Sedat Dilek

Am I the only one who reads that as a hard 'ch' without the 'e'?

Quoted 7 lines
Quoted 5 lines

I am not an English native or teacher: But from what I know it's... to cache | caching | cached.
Google gives me no hits for cach*e*ing.
Anyway, the spelling should be consistent in kernel-drm | libdrm | intel-ddx | etc.

It was. I blame Ben.

I can't say :-).
Anyway, what's next with this patch?

- Sedat -