i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

PATCH New Santosh Shilimkar 3 participants 10 messages Jul 25, 2013 – Aug 15, 2013

Subsystems (2)

I2C subsystem host drivers TI DaVinci machine support

lore

Share & tools

lore

Santosh Shilimkar

author

2013-07-25 00:28 UTC #0 lore raw

cover i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These couple of patches makes it possible to select the I2C_DAVINCI on Keystone SOCs.

Cc Sekhar Nori <[email protected]>

Cc Wolfram Sang <[email protected]>

Santosh Shilimkar (2):
i2c: davinci: remove useless mach/hardware include
i2c: davinci: Allow i2c driver available for keystone platforms

 drivers/i2c/busses/Kconfig       |    2 +-
 drivers/i2c/busses/i2c-davinci.c |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Signature · 1 line

1.7.9.5

Santosh Shilimkar

author

2013-07-25 00:28 UTC #1 lore raw

PATCH 1/2 i2c: davinci: remove useless mach/hardware include

This driver no longer uses definitions from mach/hardware.h. On the other hand, including this header breaks this driver on non-davinci platforms which don't have such a header.

Fix it.

Cc Sekhar Nori <[email protected]>

Cc Wolfram Sang <[email protected]>

Signed-off-by Santosh Shilimkar <[email protected]>

---
 drivers/i2c/busses/i2c-davinci.c |    1 -
 1 file changed, 1 deletion(-)

drivers/i2c/busses/i2c-davinci.c +0 -1

index fa55605..ddaa2a3 100644
@@ -41,7 +41,6 @@
 #include <linux/of_i2c.h>
 #include <linux/of_device.h>
 
-#include <mach/hardware.h>
 #include <linux/platform_data/i2c-davinci.h>
 
 /* ----- global defines ----------------------------------------------- */

Signature · 1 line

1.7.9.5

Sekhar Nori

2013-07-25 09:40 UTC #2 lore raw

PATCH 1/2 i2c: davinci: remove useless mach/hardware include

Quoted 10 lines · Santosh Shilimkar

This driver no longer uses definitions from mach/hardware.h. On the other hand, including this header breaks this driver on non-davinci platforms which don't have such a header.
Fix it.
Cc Sekhar Nori <[email protected]>
Cc Wolfram Sang <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>

Acked-by Sekhar Nori <[email protected]>

One minor nit:

drivers/i2c/busses/i2c-davinci.c line 43

Quoted 12 lines

---
 drivers/i2c/busses/i2c-davinci.c |    1 -
 1 file changed, 1 deletion(-)

drivers/i2c/busses/i2c-davinci.c +0 -0

index fa55605..ddaa2a3 100644
@@ -41,7 +41,6 @@
 #include <linux/of_i2c.h>
 #include <linux/of_device.h>

You can now remove this empty line too.

Thanks,
Sekhar

Quoted 5 lines

drivers/i2c/busses/i2c-davinci.c +0 -1

-#include <mach/hardware.h>
 #include <linux/platform_data/i2c-davinci.h>
 
 /* ----- global defines ----------------------------------------------- */

Santosh Shilimkar

author

2013-07-25 20:59 UTC #3 lore raw

PATCH 1/2 i2c: davinci: remove useless mach/hardware include

Quoted 20 lines · Sekhar Nori

Quoted 10 lines · Santosh Shilimkar
This driver no longer uses definitions from mach/hardware.h. On the other hand, including this header breaks this driver on non-davinci platforms which don't have such a header.
Fix it.
Cc Sekhar Nori <[email protected]>
Cc Wolfram Sang <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>
Acked-by Sekhar Nori <[email protected]>
One minor nit:
Quoted 4 lines
---
 drivers/i2c/busses/i2c-davinci.c |    1 -
 1 file changed, 1 deletion(-)

Quoted 11 lines

drivers/i2c/busses/i2c-davinci.c line 43
Quoted 8 lines
drivers/i2c/busses/i2c-davinci.c +0 -0
index fa55605..ddaa2a3 100644
@@ -41,7 +41,6 @@
 #include <linux/of_i2c.h>
 #include <linux/of_device.h>
 
You can now remove this empty line too.

Yes. Updated patch below with your ack added.

Regards,
Santosh

Quoted 1 line

From d7ae1c488ebae19028f33abff76c4d684271a7fb Mon Sep 17 00:00:00 2001

From: Santosh Shilimkar <[email protected]>
Date: Tue, 23 Jul 2013 15:40:46 -0400
Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include

This driver no longer uses definitions from mach/hardware.h. On the other hand, including this header breaks this driver on non-davinci platforms which don't have such a header.

Fix it.

Cc Wolfram Sang <[email protected]>

Acked-by Sekhar Nori <[email protected]>

Signed-off-by Santosh Shilimkar <[email protected]>

---
 drivers/i2c/busses/i2c-davinci.c |    2 --
 1 file changed, 2 deletions(-)

drivers/i2c/busses/i2c-davinci.c +0 -2

index fa55605..5898df3 100644
@@ -40,8 +40,6 @@
 #include <linux/gpio.h>
 #include <linux/of_i2c.h>
 #include <linux/of_device.h>
-
-#include <mach/hardware.h>
 #include <linux/platform_data/i2c-davinci.h>
 
 /* ----- global defines ----------------------------------------------- */

Signature · 1 line

1.7.9.5

Wolfram Sang

2013-08-15 12:31 UTC #4 lore raw

PATCH 1/2 i2c: davinci: remove useless mach/hardware include

Quoted 42 lines · Santosh Shilimkar

Quoted 20 lines · Sekhar Nori
Quoted 10 lines · Santosh Shilimkar
This driver no longer uses definitions from mach/hardware.h. On the other hand, including this header breaks this driver on non-davinci platforms which don't have such a header.
Fix it.
Cc Sekhar Nori <[email protected]>
Cc Wolfram Sang <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>
Acked-by Sekhar Nori <[email protected]>
One minor nit:
Quoted 4 lines
---
 drivers/i2c/busses/i2c-davinci.c |    1 -
 1 file changed, 1 deletion(-)
Quoted 11 lines
drivers/i2c/busses/i2c-davinci.c line 43
Quoted 8 lines
drivers/i2c/busses/i2c-davinci.c +0 -0
index fa55605..ddaa2a3 100644
@@ -41,7 +41,6 @@
 #include <linux/of_i2c.h>
 #include <linux/of_device.h>
 
You can now remove this empty line too.
Yes. Updated patch below with your ack added.
Regards,
Santosh
From d7ae1c488ebae19028f33abff76c4d684271a7fb Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <[email protected]>
Date: Tue, 23 Jul 2013 15:40:46 -0400
Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include

Quoted 5 lines

This driver no longer uses definitions from mach/hardware.h. On the other hand, including this header breaks this driver on non-davinci platforms which don't have such a header.
Fix it.

Applied to for-next, thanks! Please send a proper V2 in a seperate
message next time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130815/c8758217/attachment.sig>

Santosh Shilimkar

author

2013-07-25 00:28 UTC #5 lore raw

PATCH 2/2 i2c: davinci: Allow i2c driver available for keystone platforms

In reply to Santosh Shilimkar

Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. Update the config so that ARCH_KEYSTONE can use it.

Cc Sekhar Nori <[email protected]>

Cc Wolfram Sang <[email protected]>

Signed-off-by Santosh Shilimkar <[email protected]>

---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/i2c/busses/Kconfig +1 -1

index dc6dea6..fcdd321 100644
@@ -385,7 +385,7 @@ config I2C_CPM
 
 config I2C_DAVINCI
 	tristate "DaVinci I2C driver"
-	depends on ARCH_DAVINCI
+	depends on ARCH_DAVINCI || ARCH_KEYSTONE
 	help
 	  Support for TI DaVinci I2C controller driver.

Signature · 1 line

1.7.9.5

Wolfram Sang

Applied

2013-08-15 12:31 UTC #6 lore raw

PATCH 2/2 i2c: davinci: Allow i2c driver available for keystone platforms

Quoted 7 lines · Santosh Shilimkar

Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. Update the config so that ARCH_KEYSTONE can use it.
Cc Sekhar Nori <[email protected]>
Cc Wolfram Sang <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130815/1dbdc002/attachment.sig>

Santosh Shilimkar

author

2013-08-09 20:09 UTC #7 lore raw

cover i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

In reply to Santosh Shilimkar

Wolfram, Sekhar,

Quoted 11 lines · Santosh Shilimkar

Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These couple of patches makes it possible to select the I2C_DAVINCI on Keystone SOCs.
Cc Sekhar Nori <[email protected]>
Cc Wolfram Sang <[email protected]>
Santosh Shilimkar (2):
i2c: davinci: remove useless mach/hardware include
i2c: davinci: Allow i2c driver available for keystone platforms

Who is queuing up these patches ?

regards,
Santosh

Wolfram Sang

2013-08-11 09:53 UTC #8 lore raw

cover i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

Quoted 7 lines · Santosh Shilimkar

Wolfram, Sekhar,
Quoted 4 lines · Santosh Shilimkar
Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These couple of patches makes it possible to select the I2C_DAVINCI on Keystone SOCs.

Quoted 8 lines

Quoted 7 lines
Cc Sekhar Nori <[email protected]>
Cc Wolfram Sang <[email protected]>
Santosh Shilimkar (2):
i2c: davinci: remove useless mach/hardware include
i2c: davinci: Allow i2c driver available for keystone platforms
Who is queuing up these patches ?

I can pick them. Do they depend on something?

Shilimkar, Santosh

author

2013-08-12 00:26 UTC #9 lore raw

cover i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

(Sorry for top posting ..)

No dependency so feel free to pick and merge them appropriately.

Regards,
Santosh
________________________________________
From: Wolfram Sang [wsa at the-dreams.de]
Sent: Sunday, August 11, 2013 5:53 AM
To: Shilimkar, Santosh
Cc: Nori, Sekhar; linux-i2c at vger.kernel.org; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

Quoted 7 lines · Santosh Shilimkar

Wolfram, Sekhar,
Quoted 4 lines · Santosh Shilimkar
Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These couple of patches makes it possible to select the I2C_DAVINCI on Keystone SOCs.

Quoted 8 lines

Quoted 7 lines
Cc Sekhar Nori <[email protected]>
Cc Wolfram Sang <[email protected]>
Santosh Shilimkar (2):
i2c: davinci: remove useless mach/hardware include
i2c: davinci: Allow i2c driver available for keystone platforms
Who is queuing up these patches ?

I can pick them. Do they depend on something?