macvtap: fix up direction in comment on offloading
Subsystems (2)
PATCH 1/1 macvtap: fix up direction in comment on offloading
It speaks about receiving frames, so while
it says GSO, it really means GRO.
--- drivers/net/macvtap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/macvtap.c +1 -1
@@ -1047,7 +1047,7 @@ static int set_offload(struct macvtap_queue *q, unsigned long arg)* accept TSO frames and turning it off means that user space * does not support TSO. * For macvtap, we have to invert it to mean the same thing. -* When user space turns off TSO, we turn off GSO/LRO so that +* When user space turns off TSO, we turn off GRO/LRO so that * user-space will not receive TSO frames. */ if (feature_mask & (NETIF_F_TSO |NETIF_F_TSO6 |NETIF_F_UFO ))
Signature · 1 line
MST
Quoted 13 lines · Michael S. Tsirkin
It speaks about receiving frames, so while
it says GSO, it really means GRO.Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/net/macvtap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/macvtap.c +0
-0
drivers/net/macvtap.c static int set_offload(struct macvtap_queue *q, unsigned long arg) · line 1050
Quoted 5 lines
drivers/net/macvtap.c +1
-1@@ -1047,7 +1047,7 @@ static int set_offload(struct macvtap_queue *q, unsigned long arg)* accept TSO frames and turning it off means that user space * does not support TSO. * For macvtap, we have to invert it to mean the same thing. -* When user space turns off TSO, we turn off GSO/LRO so that +* When user space turns off TSO, we turn off GRO/LRO so that
Right fix.
Quoted 10 lines
drivers/net/macvtap.c +0
-1* user-space will not receive TSO frames. */ if (feature_mask & (NETIF_F_TSO |NETIF_F_TSO6 |NETIF_F_UFO )) --MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Amos Kong <[email protected]>
Date: Fri, 16 Aug 2013 04:41:26 +0800
Quoted 22 lines · Michael S. Tsirkin
Quoted 13 lines
It speaks about receiving frames, so while
it says GSO, it really means GRO.Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/net/macvtap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/macvtap.c +0
-0drivers/net/macvtap.c static int set_offload(struct macvtap_queue *q, unsigned long arg) · line 1050
Quoted 5 lines
drivers/net/macvtap.c +1
-1@@ -1047,7 +1047,7 @@ static int set_offload(struct macvtap_queue *q, unsigned long arg)* accept TSO frames and turning it off means that user space * does not support TSO. * For macvtap, we have to invert it to mean the same thing. -* When user space turns off TSO, we turn off GSO/LRO so that +* When user space turns off TSO, we turn off GRO/LRO so that Right fix.
Quoted 1 line
Reviewed-by Amos Kong <[email protected]>
Applied, thanks.