writeback: Fix occasional slow sync(1)
Jan Kara
reviewerPATCH 1/1 writeback: Fix occasional slow sync(1)
In case when system contains no dirty pages, wakeup_flusher_threads() will submit WB_SYNC_NONE writeback for 0 pages so wb_writeback() exits immediately without doing anything. Thus sync(1) will write all the dirty inodes from a WB_SYNC_ALL writeback pass which is slow.
Fix the problem by using get_nr_dirty_pages() in wakeup_flusher_threads() instead of calculating number of dirty pages manually. That function also takes number of dirty inodes into account.
--- fs/fs-writeback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
fs/fs-writeback.c +2 -4
@@ -1055,10 +1055,8 @@ void wakeup_flusher_threads(long nr_pages, enum wb_reason reason) {struct backing_dev_info *bdi; -if (!nr_pages) { - nr_pages =global_page_state (NR_FILE_DIRTY ) + -global_page_state (NR_UNSTABLE_NFS ); - } +if (!nr_pages) + nr_pages =get_nr_dirty_pages ();rcu_read_lock ();list_for_each_entry_rcu (bdi, &bdi_list, bdi_list) {
Signature · 1 line
1.8.1.4
Jan Kara
reviewerQuoted 5 lines · Jan Kara
In case when system contains no dirty pages,
wakeup_flusher_threads()will submitWB_SYNC_NONEwriteback for 0 pages sowb_writeback()exits immediately without doing anything. Thus sync(1) will write all the dirty inodes from aWB_SYNC_ALLwriteback pass which is slow.
Quoted 7 lines
Fix the problem by using
get_nr_dirty_pages()inwakeup_flusher_threads()instead of calculating number of dirty pages manually. That function also takes number of dirty inodes into account.Reported-by Paul Taysom <[email protected]>Signed-off-by Jan Kara <[email protected]>
Ping Al?
Honza
Quoted 24 lines
--- fs/fs-writeback.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)fs/fs-writeback.c +2
-4@@ -1055,10 +1055,8 @@ void wakeup_flusher_threads(long nr_pages, enum wb_reason reason) {struct backing_dev_info *bdi; -if (!nr_pages) { - nr_pages =global_page_state (NR_FILE_DIRTY ) + -global_page_state (NR_UNSTABLE_NFS ); - } +if (!nr_pages) + nr_pages =get_nr_dirty_pages ();rcu_read_lock ();list_for_each_entry_rcu (bdi, &bdi_list, bdi_list) {Signature · 1 line
1.8.1.4
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 8 lines · On Mon, 15 Jul 2013 11:45:14 +0200 Jan Kara <[email protected]> wrote:
In case when system contains no dirty pages,
wakeup_flusher_threads()will submitWB_SYNC_NONEwriteback for 0 pages sowb_writeback()exits immediately without doing anything. Thus sync(1) will write all the dirty inodes from aWB_SYNC_ALLwriteback pass which is slow.Fix the problem by using
get_nr_dirty_pages()inwakeup_flusher_threads()instead of calculating number of dirty pages manually. That function also takes number of dirty inodes into account.
Fair enough.
Quoted 1 line
Unexpected. What was your thinking here?
Jan Kara
reviewerQuoted 11 lines · Andrew Morton
Quoted 8 lines · On Mon, 15 Jul 2013 11:45:14 +0200 Jan Kara <[email protected]> wrote:
In case when system contains no dirty pages,
wakeup_flusher_threads()will submitWB_SYNC_NONEwriteback for 0 pages sowb_writeback()exits immediately without doing anything. Thus sync(1) will write all the dirty inodes from aWB_SYNC_ALLwriteback pass which is slow.Fix the problem by using
get_nr_dirty_pages()inwakeup_flusher_threads()instead of calculating number of dirty pages manually. That function also takes number of dirty inodes into account.
Quoted 5 lines
Fair enough.
Quoted 1 line
Unexpected. What was your thinking here?
Right, probably the problem isn't serious enough. Just discard the CC
please. Thanks!
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR