Skip to contentSkip to conversation

ARM: mxs: Add mx28evk_auart_console target

PATCH New Andreas Wass 4 participants 8 messages Aug 16, 2013 – Aug 18, 2013 Arm i.MX and Layerscape

lore
Share & tools
lore

Andreas Wass

author
#0 lore raw

PATCH 1/1 ARM: mxs: Add mx28evk_auart_console target

The target uses AUART 3 instead of the DUART for console output.

Signed-off-by Andreas Wass <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Marek Vasut <[email protected]>
---
 boards.cfg            | 1 +
 include/configs/mxs.h | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)
boards.cfg +1 -0
index 454da7f..79d6cd8 100644
@@ -203,6 +203,7 @@ mx23evk                      arm         arm926ejs   mx23evk             freesca
 m28evk                       arm         arm926ejs   m28evk              denx           mxs		m28evk
 mx28evk                      arm         arm926ejs   mx28evk             freescale      mxs		mx28evk:ENV_IS_IN_MMC
 mx28evk_nand                 arm         arm926ejs   mx28evk             freescale      mxs		mx28evk:ENV_IS_IN_NAND
+mx28evk_auart_console        arm         arm926ejs   mx28evk             freescale      mxs		mx28evk:MXS_AUART,MXS_AUART_BASE=MXS_UARTAPP3_BASE,ENV_IS_IN_MMC
 sc_sps_1                     arm         arm926ejs   sc_sps_1            schulercontrol mxs
 nhk8815                      arm         arm926ejs   nhk8815             st             nomadik
 nhk8815_onenand              arm         arm926ejs   nhk8815             st             nomadik       nhk8815:BOOT_ONENAND
include/configs/mxs.h +6 -1
index a684166..124dc1e 100644
@@ -119,11 +119,16 @@
 /* GPIO */
 #define CONFIG_MXS_GPIO
 
-/* DUART Serial Driver */
+/*
+ * DUART Serial Driver.
+ * Conflicts with AUART driver which can be set by board.
+ */
+#ifndef CONFIG_MXS_AUART
 #define CONFIG_PL011_SERIAL
 #define CONFIG_PL011_CLOCK		24000000
 #define CONFIG_PL01x_PORTS		{ (void *)MXS_UARTDBG_BASE }
 #define CONFIG_CONS_INDEX		0
+#endif
 /* Default baudrate can be overriden by board! */
 #ifndef CONFIG_BAUDRATE
 #define CONFIG_BAUDRATE			115200
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 1/1 ARM: mxs: Add mx28evk_auart_console target

Quoted 5 lines · Andreas Wass

The target uses AUART 3 instead of the DUART for console output.

Signed-off-by Andreas Wass <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Marek Vasut <[email protected]>

Why to use AUART for console? can you elaborate it a little more?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
author
#2 lore raw

PATCH 1/1 ARM: mxs: Add mx28evk_auart_console target

Dear Otavio,

Some boards don't have the DUART easily available (see STKa28 by TQ-group for instance) while a regular rs232 port is easily accessed.

The purpose of this patch is more of a demonstration how to use the AUART driver and was requested by Fabio during the submission of the AUART driver.

Best regards
Andreas Wass

16 aug 2013 kl. 19:00 skrev "Otavio Salvador" <[email protected]>:

Quoted 13 lines · Andreas Wass
Quoted 5 lines

The target uses AUART 3 instead of the DUART for console output.

Signed-off-by Andreas Wass <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Marek Vasut <[email protected]>

Why to use AUART for console? can you elaborate it a little more?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
reviewer
#3 lore raw

PATCH 1/1 ARM: mxs: Add mx28evk_auart_console target

Quoted 5 lines · Andreas Wass

Dear Otavio,

Some boards don't have the DUART easily available (see STKa28 by TQ-group for instance) while a regular rs232 port is easily accessed.

The purpose of this patch is more of a demonstration how to use the AUART driver and was requested by Fabio during the submission of the AUART driver.

Yes, correct.

With this target in place, we can have a user of the mxs auart driver that Andreas submitted recently.

Regards,

Fabio Estevam

#4 lore raw

PATCH 1/1 ARM: mxs: Add mx28evk_auart_console target

Quoted 11 lines · Fabio Estevam
Quoted 5 lines · Andreas Wass

Dear Otavio,

Some boards don't have the DUART easily available (see STKa28 by TQ-group for instance) while a regular rs232 port is easily accessed.

The purpose of this patch is more of a demonstration how to use the AUART driver and was requested by Fabio during the submission of the AUART driver.

Yes, correct.

With this target in place, we can have a user of the mxs auart driver that Andreas submitted recently.

I see.

Good :-)

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
author
#6 lore raw

PATCH 1/1 ARM: mxs: Add mx28evk_auart_console target

Dear Marek

Quoted 1 line

I wonder, why dont you add support for the TQ SoM in the first place?

I have plans to do it but I only have access to the board at work and I currently am very busy so have limited time testing the board setup, so I don't know when in time I will be able to submit such a patch.

Regards
Andreas

#7 lore raw

PATCH 1/1 ARM: mxs: Add mx28evk_auart_console target

Hi Andreas,

Quoted 7 lines

Dear Marek

Quoted 1 line

I wonder, why dont you add support for the TQ SoM in the first place?

I have plans to do it but I only have access to the board at work and I currently am very busy so have limited time testing the board setup, so I don't know when in time I will be able to submit such a patch.

Sucks, but ok.

Best regards,
Marek Vasut