Skip to contentSkip to conversation

drm/Kconfig: favor n for DRM_I915_PRELIMINARY_HW_SUPPORT

PATCH In review Ben Widawsky 5 participants 7 messages Aug 19, 2013 – Aug 20, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/Kconfig: favor n for DRM_I915_PRELIMINARY_HW_SUPPORT

We generally don't want people or distros to use this option unless they know what they're doing. I missed the initial conversation but it's likely a way for people who have a built-in i915.ko and have no other way to change the behavior.

As such:
Set default to n
Display message for what users should select (N) and while there, a small whitespace fix.

Cc Josh Triplett <[email protected]>

---
 drivers/gpu/drm/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/Kconfig +4 -1
index 62a06c7..ad4e369 100644
@@ -171,12 +171,15 @@ config DRM_I915_KMS
 config DRM_I915_PRELIMINARY_HW_SUPPORT
 	bool "Enable preliminary support for prerelease Intel hardware by default"
 	depends on DRM_I915
+	default n
 	help
 	  Choose this option if you have prerelease Intel hardware and want the
-	  i915 driver to support it by default.  You can enable such support at
+	  i915 driver to support it by default. You can enable such support at
 	  runtime with the module option i915.preliminary_hw_support=1; this
 	  option changes the default for that module option.
 
+	  If in doubt, say "N".
+
 config DRM_MGA
 	tristate "Matrox g200/g400"
 	depends on DRM && PCI
Signature · 1 line
1.8.3.4
#1 lore raw
Quoted 4 lines · Ben Widawsky

We generally don't want people or distros to use this option unless they know what they're doing. I missed the initial conversation but it's likely a way for people who have a built-in i915.ko and have no other way to change the behavior.

It's to be able to have a config file to generate kernels supporting preliminary hardware, without having to always add the command line parameter or carry a patch or changing the bootloader configuration.

Quoted 6 lines

As such:
Set default to n
Display message for what users should select (N) and while there, a small whitespace fix.

Cc Josh Triplett <[email protected]>

Missing the ':' so you didn't end up Ccing Josh.

Quoted 10 lines
---
 drivers/gpu/drm/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -0
index 62a06c7..ad4e369 100644

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 174

Quoted 4 lines
drivers/gpu/drm/Kconfig +1 -0
@@ -171,12 +171,15 @@ config DRM_I915_KMS
 config DRM_I915_PRELIMINARY_HW_SUPPORT
 	bool "Enable preliminary support for prerelease Intel hardware by default"
 	depends on DRM_I915
+	default n

That's the default, you don't have to make it explicit (but of course it doesn't hurt). make oldconfig with this new option gives:

Enable preliminary support for prerelease Intel hardware by default (DRM_I915_PRELIMINARY_HW_SUPPORT) [N/y/?] (NEW)

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 177

Quoted 4 lines
drivers/gpu/drm/Kconfig +1 -1
 	help
 	  Choose this option if you have prerelease Intel hardware and want the
-	  i915 driver to support it by default.  You can enable such support at
+	  i915 driver to support it by default. You can enable such support at

The Kconfig files have both styles, 2 spaces or 1 space after the '.'.

Quoted 15 lines
drivers/gpu/drm/Kconfig +2 -0
 	  runtime with the module option i915.preliminary_hw_support=1; this
 	  option changes the default for that module option.
 
+	  If in doubt, say "N".
+
 config DRM_MGA
 	tristate "Matrox g200/g400"
 	depends on DRM && PCI
Signature · 6 lines
1.8.3.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 10 lines · Damien Lespiau
Quoted 4 lines · Ben Widawsky

We generally don't want people or distros to use this option unless they know what they're doing. I missed the initial conversation but it's likely a way for people who have a built-in i915.ko and have no other way to change the behavior.

It's to be able to have a config file to generate kernels supporting preliminary hardware, without having to always add the command line parameter or carry a patch or changing the bootloader configuration.

Changing default module parameter options is not something we should be solving with a CONFIG option. It is solvable with modeprobe.conf. The unsolvable problem is for building in, which is the reason I agree this patch is necessary at all. (The other being systems which don't have, or have an ancient version of modprobe, but I don't believe that is the target audience). Given the recent kernels allow us to break module parameter "ABI" would be another (albeit less defensible) reason not to use a CONFIG option. All this is, "whatever" though, since the patch is already merged.

Quoted 8 lines
Quoted 6 lines

As such:
Set default to n
Display message for what users should select (N) and while there, a small whitespace fix.

Cc Josh Triplett <[email protected]>

Missing the ':' so you didn't end up Ccing Josh.

Thanks a lot for catching that. CC'd now.

Quoted 19 lines
Quoted 11 lines
---
 drivers/gpu/drm/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -0
index 62a06c7..ad4e369 100644

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 174

Quoted 4 lines
drivers/gpu/drm/Kconfig +1 -0
@@ -171,12 +171,15 @@ config DRM_I915_KMS
 config DRM_I915_PRELIMINARY_HW_SUPPORT
 	bool "Enable preliminary support for prerelease Intel hardware by default"
 	depends on DRM_I915
+	default n

That's the default, you don't have to make it explicit (but of course it doesn't hurt). make oldconfig with this new option gives:

Quoted 3 lines

Enable preliminary support for prerelease Intel hardware by default (DRM_I915_PRELIMINARY_HW_SUPPORT) [N/y/?] (NEW)

Right. We can drop it, I don't really care.

Quoted 6 lines

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 177

Quoted 4 lines
drivers/gpu/drm/Kconfig +1 -1
 	help
 	  Choose this option if you have prerelease Intel hardware and want the
-	  i915 driver to support it by default.  You can enable such support at
+	  i915 driver to support it by default. You can enable such support at

The Kconfig files have both styles, 2 spaces or 1 space after the '.'.

I learned something new here. We can drop this too then.

Quoted 6 lines

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 182

Quoted 6 lines
drivers/gpu/drm/Kconfig +2 -0
 	  runtime with the module option i915.preliminary_hw_support=1; this
 	  option changes the default for that module option.
 
+	  If in doubt, say "N".
+

Heh. You didn't comment on the one part I really wanted to add ;-). The rest of the patch doesn't matter much to me.

Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/Kconfig +0 -0
 config DRM_MGA
 	tristate "Matrox g200/g400"
 	depends on DRM && PCI
Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center
#3 lore raw
Quoted 10 lines · Ben Widawsky
Quoted 6 lines · Damien Lespiau

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 182

Quoted 5 lines · Ben Widawsky
drivers/gpu/drm/Kconfig +2 -0
 	  runtime with the module option i915.preliminary_hw_support=1; this
 	  option changes the default for that module option.
 
+	  If in doubt, say "N".
+

Heh. You didn't comment on the one part I really wanted to add ;-). The rest of the patch doesn't matter much to me.

I'm fine with adding the "If in doubt", yes. :)

- Josh Triplett

#4 lore raw
In reply to Ben Widawsky
Quoted 8 lines · Ben Widawsky
Quoted 5 lines

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 182

Quoted 5 lines
drivers/gpu/drm/Kconfig +2 -0
 	  runtime with the module option i915.preliminary_hw_support=1; this
 	  option changes the default for that module option.
 
+	  If in doubt, say "N".
+

Heh. You didn't comment on the one part I really wanted to add ;-). The rest of the patch doesn't matter much to me.

A patch with that hunk has my Reviewed-by: Damien Lespiau <[email protected]>

Signature · 1 line
Damien
#5 lore raw
Quoted 9 lines · Damien Lespiau
Quoted 8 lines · Ben Widawsky
Quoted 5 lines

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 182

Quoted 5 lines

runtime with the module option i915.preliminary_hw_support=1; this option changes the default for that module option.

drivers/gpu/drm/Kconfig +2 -0
+   If in doubt, say "N".
+

Heh. You didn't comment on the one part I really wanted to add ;-). The rest of the patch doesn't matter much to me.

Added.

Quoted 1 line

A patch with that hunk has my Reviewed-by: Damien Lespiau <[email protected]>

I already have an r-b tag from you on that patch ... ;-) -Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#6 lore raw
In reply to Damien Lespiau
Quoted 9 lines · Damien Lespiau
Quoted 4 lines · Ben Widawsky

We generally don't want people or distros to use this option unless they know what they're doing. I missed the initial conversation but it's likely a way for people who have a built-in i915.ko and have no other way to change the behavior.

It's to be able to have a config file to generate kernels supporting preliminary hardware, without having to always add the command line parameter or carry a patch or changing the bootloader configuration.

Exactly.

Quoted 8 lines
Quoted 6 lines

As such:
Set default to n
Display message for what users should select (N) and while there, a small whitespace fix.

Cc Josh Triplett <[email protected]>

Missing the ':' so you didn't end up Ccing Josh.

Thanks for fixing that. :)

Quoted 18 lines
Quoted 10 lines
---
 drivers/gpu/drm/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -0
index 62a06c7..ad4e369 100644

drivers/gpu/drm/Kconfig config DRM_I915_KMS · line 174

Quoted 4 lines
drivers/gpu/drm/Kconfig +1 -0
@@ -171,12 +171,15 @@ config DRM_I915_KMS
 config DRM_I915_PRELIMINARY_HW_SUPPORT
 	bool "Enable preliminary support for prerelease Intel hardware by default"
 	depends on DRM_I915
+	default n

That's the default, you don't have to make it explicit (but of course it doesn't hurt). make oldconfig with this new option gives:

Quoted 2 lines

Enable preliminary support for prerelease Intel hardware by default (DRM_I915_PRELIMINARY_HW_SUPPORT) [N/y/?] (NEW)

Right. I definitely would *not* have set this to default y, but default n is the default default, so it doesn't need stating.

- Josh Triplett