MPC8315 reboot failure, lockdep splat possibly related?
Greetings.
I've been experiencing occasional lockups at reboot for a few weeks, but only once every 10-20 boots. A good reboot looks like this:
[47529.721640] lm77 0-0048: shutdown [47529.725160] rtc-m41t80 0-0068: shutdown [47529.729169] i2c i2c-0: shutdown [47529.732534] fsl-ehci fsl-ehci.0: shutdown [47529.736842] sd 1:0:0:0: shutdown [47529.740239] sd 1:0:0:0: [sda] Synchronizing SCSI cache [47529.747091] uio_pci_generic 0000:00:0a.0: shutdown [47529.752079] pci 0000:00:00.0: shutdown [47529.756021] Restarting system.
While a bad one fails after the EHCI shutdown:
[ 747.578001] lm77 0-0048: shutdown [ 747.581522] rtc-m41t80 0-0068: shutdown [ 747.585538] i2c i2c-0: shutdown [ 747.588909] sd 1:0:0:0: shutdown [ 747.592304] sd 1:0:0:0: [sda] Synchronizing SCSI cache [ 747.597973] fsl-ehci fsl-ehci.0: shutdown
I enabled lockdep, and I get this splat on every boot, regardless of whether it locks up at reboot or not. Could it possibly be related? Any other ideas on how to avoid the reboot lockup?
[ 9.086051] =================================
[ 9.090393] [ INFO: inconsistent lock state ]
[ 9.094744] 3.9.7-ajf-gc39503d #1 Not tainted
[ 9.099087] ---------------------------------
[ 9.103432] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[ 9.109431] scsi_eh_1/39 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 9.114642] (&(&host->lock)->rlock){?.+...}, at: [<c02f4168>] sata_fsl_interrupt+0x50/0x250
[ 9.123137] {HARDIRQ-ON-W} state was registered at:
[ 9.128004] [<c006cdb8>] lock_acquire+0x90/0xf4
[ 9.132737] [<c043ef04>] _raw_spin_lock+0x34/0x4c
[ 9.137645] [<c02f3560>] fsl_sata_set_irq_coalescing+0x68/0x100
[ 9.143750] [<c02f36a0>] sata_fsl_init_controller+0xa8/0xc0
[ 9.149505] [<c02f3f10>] sata_fsl_probe+0x17c/0x2e8
[ 9.154568] [<c02acc90>] driver_probe_device+0x90/0x248
[ 9.159987] [<c02acf0c>] __driver_attach+0xc4/0xc8
[ 9.164964] [<c02aae74>] bus_for_each_dev+0x5c/0xa8
[ 9.170028] [<c02ac218>] bus_add_driver+0x100/0x26c
[ 9.175091] [<c02ad638>] driver_register+0x88/0x198
[ 9.180155] [<c0003a24>] do_one_initcall+0x58/0x1b4
[ 9.185226] [<c05aeeac>] kernel_init_freeable+0x118/0x1c0
[ 9.190823] [<c0004110>] kernel_init+0x18/0x108
[ 9.195542] [<c000f6b8>] ret_from_kernel_thread+0x64/0x6c
[ 9.201142] irq event stamp: 160
[ 9.204366] hardirqs last enabled at (159): [<c043f778>] _raw_spin_unlock_irq+0x30/0x50
[ 9.212469] hardirqs last disabled at (160): [<c000f414>] reenable_mmu+0x30/0x88
[ 9.219867] softirqs last enabled at (144): [<c002ae5c>] __do_softirq+0x168/0x218
[ 9.227435] softirqs last disabled at (137): [<c002b0d4>] irq_exit+0xa8/0xb4
[ 9.234481]
[ 9.234481] other info that might help us debug this:
[ 9.240995] Possible unsafe locking scenario:
[ 9.240995]
[ 9.246898] CPU0
[ 9.249337] ----
[ 9.251776] lock(&(&host->lock)->rlock);
[ 9.255878] <Interrupt>
[ 9.258492] lock(&(&host->lock)->rlock);
[ 9.262765]
[ 9.262765] *** DEADLOCK ***
[ 9.262765]
[ 9.268684] no locks held by scsi_eh_1/39.
[ 9.272767]
[ 9.272767] stack backtrace:
[ 9.277117] Call Trace:
[ 9.279589] [cfff9da0] [c0008504] show_stack+0x48/0x150 (unreliable)
[ 9.285972] [cfff9de0] [c0447d5c] print_usage_bug.part.35+0x268/0x27c
[ 9.292425] [cfff9e10] [c006ace4] mark_lock+0x2ac/0x658
[ 9.297660] [cfff9e40] [c006b7e4] __lock_acquire+0x754/0x1840
[ 9.303414] [cfff9ee0] [c006cdb8] lock_acquire+0x90/0xf4
[ 9.308745] [cfff9f20] [c043ef04] _raw_spin_lock+0x34/0x4c
[ 9.314250] [cfff9f30] [c02f4168] sata_fsl_interrupt+0x50/0x250
[ 9.320187] [cfff9f70] [c0079ff0] handle_irq_event_percpu+0x90/0x254
[ 9.326547] [cfff9fc0] [c007a1fc] handle_irq_event+0x48/0x78
[ 9.332220] [cfff9fe0] [c007c95c] handle_level_irq+0x9c/0x104
[ 9.337981] [cfff9ff0] [c000d978] call_handle_irq+0x18/0x28
[ 9.343568] [cc7139f0] [c000608c] do_IRQ+0xf0/0x1a8
[ 9.348464] [cc713a20] [c000fc8c] ret_from_except+0x0/0x14
[ 9.353983] --- Exception: 501 at _raw_spin_unlock_irq+0x40/0x50
[ 9.353983] LR = _raw_spin_unlock_irq+0x30/0x50
[ 9.364839] [cc713af0] [c043db10] wait_for_common+0xac/0x188
[ 9.370513] [cc713b30] [c02ddee4] ata_exec_internal_sg+0x2b0/0x4f0
[ 9.376699] [cc713be0] [c02de18c] ata_exec_internal+0x68/0xa8
[ 9.382454] [cc713c20] [c02de4b8] ata_dev_read_id+0x158/0x594
[ 9.388205] [cc713ca0] [c02ec244] ata_eh_recover+0xd88/0x13d0
[ 9.393962] [cc713d20] [c02f2520] sata_pmp_error_handler+0xc0/0x8ac
[ 9.400234] [cc713dd0] [c02ecdc8] ata_scsi_port_error_handler+0x464/0x5e8
[ 9.407023] [cc713e10] [c02ecfd0] ata_scsi_error+0x84/0xb8
[ 9.412528] [cc713e40] [c02c4974] scsi_error_handler+0xd8/0x47c
[ 9.418457] [cc713eb0] [c004737c] kthread+0xa8/0xac
[ 9.423355] [cc713f40] [c000f6b8] ret_from_kernel_thread+0x64/0x6cA full set of kernel messages from a hanging (fails to reboot) session is here:
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/hang-log.txt
And a full set of messages for a boot that reboots successfully:
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/no-hang-log.txt
The associated config file:
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/config.txt
The only addition I've made to this section of the kernel is my "SATA speed limit patch", discussed a few weeks back:
http://permalink.gmane.org/gmane.linux.ports.ppc.embedded/58969
That patch does touch sata_fsl_probe, but it just sets a value -- it doesn't do any locking (for better or for worse), nor does it call any other functions (and it seems that it's a function further down the stack that is triggering lockdep).
I took a quick look at the diffs between 3.9.7 (both upstream and my variant) and the current head of linux-stable, and didn't see anything that looked relevant. The two main changes I saw were switching from dev_get_drvdata to platform_get_drvdata and adding the rx_watermark. I did see that dev_set_drvdata was removed from sata_fsl_probe's exit path; not sure if that could cause this sort of error.
If anyone has ideas on how to avoid the reboot lockup, I would greatly appreciate it.
Thank you for your time!
Best regards,
Anthony Foiani
Quoted 5 lines
-----Original Message-----
From: Linuxppc-dev [mailto:linuxppc-dev- [email protected]] On Behalf Of Ant=
hony
Quoted 9 lines
Foiani
Sent: Saturday, August 17, 2013 7:10 AM
To: [email protected]
Subject: MPC8315 reboot failure, lockdep splat possibly related? =20
=20
Greetings.
=20
I've been experiencing occasional lockups at reboot for a few weeks, but =
only
Quoted 20 lines
once every 10-20 boots. A good reboot looks like this:
=20[47529.721640] lm77 0-0048: shutdown [47529.725160] rtc-m41t80 0-0068: shutdown [47529.729169] i2c i2c-0: shutdown [47529.732534] fsl-ehci fsl-ehci.0: shutdown [47529.736842] sd 1:0:0:0: shutdown [47529.740239] sd 1:0:0:0: [sda] Synchronizing SCSI cache [47529.747091] uio_pci_generic 0000:00:0a.0: shutdown [47529.752079] pci 0000:00:00.0: shutdown [47529.756021] Restarting system. =20 While a bad one fails after the EHCI shutdown: =20 [ 747.578001] lm77 0-0048: shutdown [ 747.581522] rtc-m41t80 0-0068: shutdown [ 747.585538] i2c i2c-0: shutdown [ 747.588909] sd 1:0:0:0: shutdown [ 747.592304] sd 1:0:0:0: [sda] Synchronizing SCSI cache [ 747.597973] fsl-ehci fsl-ehci.0: shutdown
Quoted 2 lines
=20
I enabled lockdep, and I get this splat on every boot, regardless of whet=
her it
Quoted 4 lines
locks up at reboot or not. Could it possibly be related? Any other ideas on how to avoid the reboot lockup? =20
[ 9.086051] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Quoted 34 lines
[ 9.090393] [ INFO: inconsistent lock state ]
[ 9.094744] 3.9.7-ajf-gc39503d #1 Not tainted
[ 9.099087] ---------------------------------
[ 9.103432] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[ 9.109431] scsi_eh_1/39 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 9.114642] (&(&host->lock)->rlock){?.+...}, at: [<c02f4168>]
sata_fsl_interrupt+0x50/0x250
[ 9.123137] {HARDIRQ-ON-W} state was registered at:
[ 9.128004] [<c006cdb8>] lock_acquire+0x90/0xf4
[ 9.132737] [<c043ef04>] _raw_spin_lock+0x34/0x4c
[ 9.137645] [<c02f3560>] fsl_sata_set_irq_coalescing+0x68/0x100
[ 9.143750] [<c02f36a0>] sata_fsl_init_controller+0xa8/0xc0
[ 9.149505] [<c02f3f10>] sata_fsl_probe+0x17c/0x2e8
[ 9.154568] [<c02acc90>] driver_probe_device+0x90/0x248
[ 9.159987] [<c02acf0c>] __driver_attach+0xc4/0xc8
[ 9.164964] [<c02aae74>] bus_for_each_dev+0x5c/0xa8
[ 9.170028] [<c02ac218>] bus_add_driver+0x100/0x26c
[ 9.175091] [<c02ad638>] driver_register+0x88/0x198
[ 9.180155] [<c0003a24>] do_one_initcall+0x58/0x1b4
[ 9.185226] [<c05aeeac>] kernel_init_freeable+0x118/0x1c0
[ 9.190823] [<c0004110>] kernel_init+0x18/0x108
[ 9.195542] [<c000f6b8>] ret_from_kernel_thread+0x64/0x6c
[ 9.201142] irq event stamp: 160
[ 9.204366] hardirqs last enabled at (159): [<c043f778>]
_raw_spin_unlock_irq+0x30/0x50
[ 9.212469] hardirqs last disabled at (160): [<c000f414>]
reenable_mmu+0x30/0x88
[ 9.219867] softirqs last enabled at (144): [<c002ae5c>]
__do_softirq+0x168/0x218
[ 9.227435] softirqs last disabled at (137): [<c002b0d4>]
irq_exit+0xa8/0xb4
[ 9.234481]
[ 9.234481] other info that might help us debug this:
[ 9.240995] Possible unsafe locking scenario:Quoted 8 lines
[ 9.240995] [ 9.246898] CPU0 [ 9.249337] ---- [ 9.251776] lock(&(&host->lock)->rlock); [ 9.255878] <Interrupt> [ 9.258492] lock(&(&host->lock)->rlock); [ 9.262765] [ 9.262765] *** DEADLOCK ***
You should get rid of this by changing spin_lock/unlock() in fsl_sata_set_i= rq_coalescing() to spin_lock_irqsave/restore()
-Bharat
Quoted 7 lines
[ 9.262765] [ 9.268684] no locks held by scsi_eh_1/39. [ 9.272767] [ 9.272767] stack backtrace: [ 9.277117] Call Trace: [ 9.279589] [cfff9da0] [c0008504] show_stack+0x48/0x150 (unreliable) [ 9.285972] [cfff9de0] [c0447d5c] print_usage_bug.part.35+0x268/0x27=
c
Quoted 12 lines
[ 9.292425] [cfff9e10] [c006ace4] mark_lock+0x2ac/0x658 [ 9.297660] [cfff9e40] [c006b7e4] __lock_acquire+0x754/0x1840 [ 9.303414] [cfff9ee0] [c006cdb8] lock_acquire+0x90/0xf4 [ 9.308745] [cfff9f20] [c043ef04] _raw_spin_lock+0x34/0x4c [ 9.314250] [cfff9f30] [c02f4168] sata_fsl_interrupt+0x50/0x250 [ 9.320187] [cfff9f70] [c0079ff0] handle_irq_event_percpu+0x90/0x254 [ 9.326547] [cfff9fc0] [c007a1fc] handle_irq_event+0x48/0x78 [ 9.332220] [cfff9fe0] [c007c95c] handle_level_irq+0x9c/0x104 [ 9.337981] [cfff9ff0] [c000d978] call_handle_irq+0x18/0x28 [ 9.343568] [cc7139f0] [c000608c] do_IRQ+0xf0/0x1a8 [ 9.348464] [cc713a20] [c000fc8c] ret_from_except+0x0/0x14 [ 9.353983] --- Exception: 501 at _raw_spin_unlock_irq+0x40/0x50
Quoted 8 lines
[ 9.353983] LR =3D _raw_spin_unlock_irq+0x30/0x50 [ 9.364839] [cc713af0] [c043db10] wait_for_common+0xac/0x188 [ 9.370513] [cc713b30] [c02ddee4] ata_exec_internal_sg+0x2b0/0x4f0 [ 9.376699] [cc713be0] [c02de18c] ata_exec_internal+0x68/0xa8 [ 9.382454] [cc713c20] [c02de4b8] ata_dev_read_id+0x158/0x594 [ 9.388205] [cc713ca0] [c02ec244] ata_eh_recover+0xd88/0x13d0 [ 9.393962] [cc713d20] [c02f2520] sata_pmp_error_handler+0xc0/0x8ac [ 9.400234] [cc713dd0] [c02ecdc8] ata_scsi_port_error_handler+0x464/=
0x5e8
Quoted 6 lines
[ 9.407023] [cc713e10] [c02ecfd0] ata_scsi_error+0x84/0xb8 [ 9.412528] [cc713e40] [c02c4974] scsi_error_handler+0xd8/0x47c [ 9.418457] [cc713eb0] [c004737c] kthread+0xa8/0xac [ 9.423355] [cc713f40] [c000f6b8] ret_from_kernel_thread+0x64/0x6c=20
A full set of kernel messages from a hanging (fails to reboot) session is=
here:
Quoted 4 lines
=20
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/hang-log.txt
=20
And a full set of messages for a boot that reboots successfully:
Quoted 8 lines
=20
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/no-hang-log.txt
=20
The associated config file:
=20
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/config.txt
=20
The only addition I've made to this section of the kernel is my "SATA spe=
ed
Quoted 5 lines
limit patch", discussed a few weeks back:
=20
http://permalink.gmane.org/gmane.linux.ports.ppc.embedded/58969
=20
That patch does touchsata_fsl_probe, but it just sets a value -- it does=
n't do
Quoted 1 line
any locking (for better or for worse), nor does it call any other functio=
ns (and
Quoted 5 lines
it seems that it's a function further down the stack that is triggering lockdep).
=20
I took a quick look at the diffs between 3.9.7 (both upstream and my variant) and the current head of linux-stable, and didn't see anything th=
at
Quoted 1 line
looked relevant. The two main changes I saw were switching from dev_get_=
drvdata
Quoted 2 lines
to
platform_get_drvdataand adding therx_watermark.
I did see thatdev_set_drvdatawas removed from sata_fsl_probe's exit pat=
h; not
Quoted 13 lines
sure if that could cause this sort of error.
=20
If anyone has ideas on how to avoid the reboot lockup, I would greatly appreciate it.
=20
Thank you for your time!
=20
Best regards,
Anthony Foiani
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
Bharat, greetings --
Quoted 2 lines · Bhushan Bharat-R65777 <[email protected]> writes:
You should get rid of this by changing spin_lock/unlock() in
fsl_sata_set_irq_coalescing()to spin_lock_irqsave/restore()
I'll do that -- thanks!
Looks like linux-next still has plain spin_lock, not the irqsave variant.
Is this something that needs to be pushed to mainline and/or stable?
If it should go upstream, is this something that Freescale can do, or should I try to put together a patch? (I'd like to avoid having to do it myself, because I'm carrying out-of-tree patches that I'd have to port to linux-next before it'd be accepted there, I fear.)
Either way, I'll definitely report if it fixes the splat on my 3.9.7 system.
Thanks again!
Best regards,
Anthony Foiani
Quoted 2 lines · Bhushan Bharat-R65777 <[email protected]> writes:
You should get rid of this by changing spin_lock/unlock() in
fsl_sata_set_irq_coalescing()to spin_lock_irqsave/restore()
I can verify that the suggested change removes the lockdep warning. The below patch is against 3.9.7 and has been tested on hardware with that release.
It applies with slight fuzz to linux-next; I've compile-tested that version, but I have not booted that build on the hardware. The linux-next patch can be found here:
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/next-sata-fsl-save-irqs-while-coalescing.patch
(or: http://preview.tinyurl.com/mpd4e9h )
Unfortunately, the hang on reboot was not easily repeatable; I'll report whether it happens in the next few days or not.
Thanks again,
Anthony Foiani
-- >8 --
Quoted 1 line
From
2abb6df770c95eb4103476c70847a78f816fe5e3Mon Sep 17 00:00:00 2001
From: Anthony Foiani <[email protected]>
Date: Sat, 17 Aug 2013 13:28:17 -0600
Subject: [PATCH] sata: fsl: save irqs while coalescing
Before this patch, I was seeing the following lockdep splat on my MPC8315 (PPC32) target:
[ 9.086051] =================================
[ 9.090393] [ INFO: inconsistent lock state ]
[ 9.094744] 3.9.7-ajf-gc39503d #1 Not tainted
[ 9.099087] ---------------------------------
[ 9.103432] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[ 9.109431] scsi_eh_1/39 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 9.114642] (&(&host->lock)->rlock){?.+...}, at: [<c02f4168>] sata_fsl_interrupt+0x50/0x250
[ 9.123137] {HARDIRQ-ON-W} state was registered at:
[ 9.128004] [<c006cdb8>] lock_acquire+0x90/0xf4
[ 9.132737] [<c043ef04>] _raw_spin_lock+0x34/0x4c
[ 9.137645] [<c02f3560>] fsl_sata_set_irq_coalescing+0x68/0x100
[ 9.143750] [<c02f36a0>] sata_fsl_init_controller+0xa8/0xc0
[ 9.149505] [<c02f3f10>] sata_fsl_probe+0x17c/0x2e8
[ 9.154568] [<c02acc90>] driver_probe_device+0x90/0x248
[ 9.159987] [<c02acf0c>] __driver_attach+0xc4/0xc8
[ 9.164964] [<c02aae74>] bus_for_each_dev+0x5c/0xa8
[ 9.170028] [<c02ac218>] bus_add_driver+0x100/0x26c
[ 9.175091] [<c02ad638>] driver_register+0x88/0x198
[ 9.180155] [<c0003a24>] do_one_initcall+0x58/0x1b4
[ 9.185226] [<c05aeeac>] kernel_init_freeable+0x118/0x1c0
[ 9.190823] [<c0004110>] kernel_init+0x18/0x108
[ 9.195542] [<c000f6b8>] ret_from_kernel_thread+0x64/0x6c
[ 9.201142] irq event stamp: 160
[ 9.204366] hardirqs last enabled at (159): [<c043f778>] _raw_spin_unlock_irq+0x30/0x50
[ 9.212469] hardirqs last disabled at (160): [<c000f414>] reenable_mmu+0x30/0x88
[ 9.219867] softirqs last enabled at (144): [<c002ae5c>] __do_softirq+0x168/0x218
[ 9.227435] softirqs last disabled at (137): [<c002b0d4>] irq_exit+0xa8/0xb4
[ 9.234481]
[ 9.234481] other info that might help us debug this:
[ 9.240995] Possible unsafe locking scenario:
[ 9.240995]
[ 9.246898] CPU0
[ 9.249337] ----
[ 9.251776] lock(&(&host->lock)->rlock);
[ 9.255878] <Interrupt>
[ 9.258492] lock(&(&host->lock)->rlock);
[ 9.262765]
[ 9.262765] *** DEADLOCK ***
[ 9.262765]
[ 9.268684] no locks held by scsi_eh_1/39.
[ 9.272767]
[ 9.272767] stack backtrace:
[ 9.277117] Call Trace:
[ 9.279589] [cfff9da0] [c0008504] show_stack+0x48/0x150 (unreliable)
[ 9.285972] [cfff9de0] [c0447d5c] print_usage_bug.part.35+0x268/0x27c
[ 9.292425] [cfff9e10] [c006ace4] mark_lock+0x2ac/0x658
[ 9.297660] [cfff9e40] [c006b7e4] __lock_acquire+0x754/0x1840
[ 9.303414] [cfff9ee0] [c006cdb8] lock_acquire+0x90/0xf4
[ 9.308745] [cfff9f20] [c043ef04] _raw_spin_lock+0x34/0x4c
[ 9.314250] [cfff9f30] [c02f4168] sata_fsl_interrupt+0x50/0x250
[ 9.320187] [cfff9f70] [c0079ff0] handle_irq_event_percpu+0x90/0x254
[ 9.326547] [cfff9fc0] [c007a1fc] handle_irq_event+0x48/0x78
[ 9.332220] [cfff9fe0] [c007c95c] handle_level_irq+0x9c/0x104
[ 9.337981] [cfff9ff0] [c000d978] call_handle_irq+0x18/0x28
[ 9.343568] [cc7139f0] [c000608c] do_IRQ+0xf0/0x1a8
[ 9.348464] [cc713a20] [c000fc8c] ret_from_except+0x0/0x14
[ 9.353983] --- Exception: 501 at _raw_spin_unlock_irq+0x40/0x50
[ 9.353983] LR = _raw_spin_unlock_irq+0x30/0x50
[ 9.364839] [cc713af0] [c043db10] wait_for_common+0xac/0x188
[ 9.370513] [cc713b30] [c02ddee4] ata_exec_internal_sg+0x2b0/0x4f0
[ 9.376699] [cc713be0] [c02de18c] ata_exec_internal+0x68/0xa8
[ 9.382454] [cc713c20] [c02de4b8] ata_dev_read_id+0x158/0x594
[ 9.388205] [cc713ca0] [c02ec244] ata_eh_recover+0xd88/0x13d0
[ 9.393962] [cc713d20] [c02f2520] sata_pmp_error_handler+0xc0/0x8ac
[ 9.400234] [cc713dd0] [c02ecdc8] ata_scsi_port_error_handler+0x464/0x5e8
[ 9.407023] [cc713e10] [c02ecfd0] ata_scsi_error+0x84/0xb8
[ 9.412528] [cc713e40] [c02c4974] scsi_error_handler+0xd8/0x47c
[ 9.418457] [cc713eb0] [c004737c] kthread+0xa8/0xac
[ 9.423355] [cc713f40] [c000f6b8] ret_from_kernel_thread+0x64/0x6cThis fix was suggested by Bhushan Bharat <[email protected]>, and was discussed in email at:
--- drivers/ata/sata_fsl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/ata/sata_fsl.c +3 -2
@@ -292,6 +292,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, {struct sata_fsl_host_priv *host_priv = host->private_data;void __iomem *hcr_base = host_priv->hcr_base; +unsigned long flags;if (count >ICC_MAX_INT_COUNT_THRESHOLD ) count =ICC_MAX_INT_COUNT_THRESHOLD ;
@@ -304,12 +305,12 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, (count > ICC_MIN_INT_COUNT_THRESHOLD)) ticks =ICC_SAFE_INT_TICKS ; -spin_lock (&host->lock); +spin_lock_irqsave (&host->lock, flags);iowrite32 ((count <<24 | ticks), hcr_base +ICC ); intr_coalescing_count = count; intr_coalescing_ticks = ticks; -spin_unlock (&host->lock); +spin_unlock_irqrestore (&host->lock, flags);DPRINTK ("intrrupt coalescing, count = 0x%x, ticks = %x\n" , intr_coalescing_count, intr_coalescing_ticks);
Signature · 1 line
1.8.1.4
Quoted 11 lines
-----Original Message-----
From: Anthony Foiani [mailto:[email protected]]
Sent: Sunday, August 18, 2013 5:37 AM
To: Bhushan Bharat-R65777
Cc: [email protected]
Subject: Re: MPC8315 reboot failure, lockdep splat possibly related? =20
Bhushan Bharat-R65777 <[email protected]> writes:
=20
Quoted 5 lines
Quoted 2 lines
You should get rid of this by changing spin_lock/unlock() in
fsl_sata_set_irq_coalescing()to spin_lock_irqsave/restore()=20
I can verify that the suggested change removes the lockdep warning. The below patch is against 3.9.7 and has been tested on hardware with tha=
t
Quoted 3 lines
release.
=20
It applies with slight fuzz to linux-next; I've compile-tested that versi=
on, but
Quoted 1 line
I have not booted that build on the hardware. The linux-next patch can b=
e found
Quoted 3 lines
here:
=20
http://scrye.com/~tkil/linux/fsl-sata-lockdep-201308/next-sata-fsl-save=
-irqs-
Quoted 2 lines
while-coalescing.patch
(or: http://preview.tinyurl.com/mpd4e9h )
Anthony, I would prefer if you can send the patch (In case not then let me = know)
Thanks
-Bharat
Quoted 2 lines
=20
Unfortunately, the hang on reboot was not easily repeatable; I'll report =
whether
Quoted 17 lines
it happens in the next few days or not.
=20
Thanks again,
Anthony Foiani
=20
-- >8 --
=20
From2abb6df770c95eb4103476c70847a78f816fe5e3Mon Sep 17 00:00:00 2001
From: Anthony Foiani <[email protected]>
Date: Sat, 17 Aug 2013 13:28:17 -0600
Subject: [PATCH] sata: fsl: save irqs while coalescing
=20
Before this patch, I was seeing the following lockdep splat on my MPC8315 (PPC32) target:
=20
Quoted 1 line
[ 9.086051] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Quoted 41 lines
[ 9.090393] [ INFO: inconsistent lock state ]
[ 9.094744] 3.9.7-ajf-gc39503d #1 Not tainted
[ 9.099087] ---------------------------------
[ 9.103432] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[ 9.109431] scsi_eh_1/39 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 9.114642] (&(&host->lock)->rlock){?.+...}, at: [<c02f4168>]
sata_fsl_interrupt+0x50/0x250
[ 9.123137] {HARDIRQ-ON-W} state was registered at:
[ 9.128004] [<c006cdb8>] lock_acquire+0x90/0xf4
[ 9.132737] [<c043ef04>] _raw_spin_lock+0x34/0x4c
[ 9.137645] [<c02f3560>] fsl_sata_set_irq_coalescing+0x68/0x100
[ 9.143750] [<c02f36a0>] sata_fsl_init_controller+0xa8/0xc0
[ 9.149505] [<c02f3f10>] sata_fsl_probe+0x17c/0x2e8
[ 9.154568] [<c02acc90>] driver_probe_device+0x90/0x248
[ 9.159987] [<c02acf0c>] __driver_attach+0xc4/0xc8
[ 9.164964] [<c02aae74>] bus_for_each_dev+0x5c/0xa8
[ 9.170028] [<c02ac218>] bus_add_driver+0x100/0x26c
[ 9.175091] [<c02ad638>] driver_register+0x88/0x198
[ 9.180155] [<c0003a24>] do_one_initcall+0x58/0x1b4
[ 9.185226] [<c05aeeac>] kernel_init_freeable+0x118/0x1c0
[ 9.190823] [<c0004110>] kernel_init+0x18/0x108
[ 9.195542] [<c000f6b8>] ret_from_kernel_thread+0x64/0x6c
[ 9.201142] irq event stamp: 160
[ 9.204366] hardirqs last enabled at (159): [<c043f778>]
_raw_spin_unlock_irq+0x30/0x50
[ 9.212469] hardirqs last disabled at (160): [<c000f414>]
reenable_mmu+0x30/0x88
[ 9.219867] softirqs last enabled at (144): [<c002ae5c>]
__do_softirq+0x168/0x218
[ 9.227435] softirqs last disabled at (137): [<c002b0d4>]
irq_exit+0xa8/0xb4
[ 9.234481]
[ 9.234481] other info that might help us debug this:
[ 9.240995] Possible unsafe locking scenario:
[ 9.240995]
[ 9.246898] CPU0
[ 9.249337] ----
[ 9.251776] lock(&(&host->lock)->rlock);
[ 9.255878] <Interrupt>
[ 9.258492] lock(&(&host->lock)->rlock);
[ 9.262765]Quoted 8 lines
[ 9.262765] *** DEADLOCK *** [ 9.262765] [ 9.268684] no locks held by scsi_eh_1/39. [ 9.272767] [ 9.272767] stack backtrace: [ 9.277117] Call Trace: [ 9.279589] [cfff9da0] [c0008504] show_stack+0x48/0x150 (unreliable) [ 9.285972] [cfff9de0] [c0447d5c] print_usage_bug.part.35+0x268/0x27=
c
Quoted 12 lines
[ 9.292425] [cfff9e10] [c006ace4] mark_lock+0x2ac/0x658 [ 9.297660] [cfff9e40] [c006b7e4] __lock_acquire+0x754/0x1840 [ 9.303414] [cfff9ee0] [c006cdb8] lock_acquire+0x90/0xf4 [ 9.308745] [cfff9f20] [c043ef04] _raw_spin_lock+0x34/0x4c [ 9.314250] [cfff9f30] [c02f4168] sata_fsl_interrupt+0x50/0x250 [ 9.320187] [cfff9f70] [c0079ff0] handle_irq_event_percpu+0x90/0x254 [ 9.326547] [cfff9fc0] [c007a1fc] handle_irq_event+0x48/0x78 [ 9.332220] [cfff9fe0] [c007c95c] handle_level_irq+0x9c/0x104 [ 9.337981] [cfff9ff0] [c000d978] call_handle_irq+0x18/0x28 [ 9.343568] [cc7139f0] [c000608c] do_IRQ+0xf0/0x1a8 [ 9.348464] [cc713a20] [c000fc8c] ret_from_except+0x0/0x14 [ 9.353983] --- Exception: 501 at _raw_spin_unlock_irq+0x40/0x50
Quoted 8 lines
[ 9.353983] LR =3D _raw_spin_unlock_irq+0x30/0x50 [ 9.364839] [cc713af0] [c043db10] wait_for_common+0xac/0x188 [ 9.370513] [cc713b30] [c02ddee4] ata_exec_internal_sg+0x2b0/0x4f0 [ 9.376699] [cc713be0] [c02de18c] ata_exec_internal+0x68/0xa8 [ 9.382454] [cc713c20] [c02de4b8] ata_dev_read_id+0x158/0x594 [ 9.388205] [cc713ca0] [c02ec244] ata_eh_recover+0xd88/0x13d0 [ 9.393962] [cc713d20] [c02f2520] sata_pmp_error_handler+0xc0/0x8ac [ 9.400234] [cc713dd0] [c02ecdc8] ata_scsi_port_error_handler+0x464/=
0x5e8
Quoted 9 lines
[ 9.407023] [cc713e10] [c02ecfd0] ata_scsi_error+0x84/0xb8 [ 9.412528] [cc713e40] [c02c4974] scsi_error_handler+0xd8/0x47c [ 9.418457] [cc713eb0] [c004737c] kthread+0xa8/0xac [ 9.423355] [cc713f40] [c000f6b8] ret_from_kernel_thread+0x64/0x6c=20
This fix was suggested by Bhushan Bharat <[email protected]>, and was discussed in email at:
=20
http://linuxppc.10917.n7.nabble.com/MPC8315-reboot-failure-lockdep-spla=
t-
drivers/ata/sata_fsl.c static void fsl_sata_set_irq_coalescing(struct ata_ho=
Quoted 12 lines
possibly-related-tp75162.html
=20Signed-off-by Anthony Foiani <[email protected]>--- drivers/ata/sata_fsl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)=20
drivers/ata/sata_fsl.c index renamed from drivers/ata/sata_fsl.c +0
-00e93ba9..c240b63 100644
drivers/ata/sata_fsl.c +0
-0@@ -292,6 +292,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_ho=
st
drivers/ata/sata_fsl.c static void fsl_sata_set_irq_coalescing(struct ata_=
Quoted 8 lines
drivers/ata/sata_fsl.c +1
-0*host, { struct sata_fsl_host_priv *host_priv =3D host->private_data; void __iomem *hcr_base =3D host_priv->hcr_base; +unsigned long flags;=20
drivers/ata/sata_fsl.c +0
-0if (count >ICC_MAX_INT_COUNT_THRESHOLD ) count =3D ICC_MAX_INT_COUNT_THRESHOLD;@@ -304,12 +305,12 @@ static void fsl_sata_set_irq_coalescing(struct ata_=
host
Quoted 18 lines
drivers/ata/sata_fsl.c +0
-0*host, (count > ICC_MIN_INT_COUNT_THRESHOLD)) ticks =3D ICC_SAFE_INT_TICKS;=20
drivers/ata/sata_fsl.c +1
-1-spin_lock (&host->lock); +spin_lock_irqsave (&host->lock, flags);iowrite32 ((count <<24 | ticks), hcr_base +ICC );=20
drivers/ata/sata_fsl.c +1
-1intr_coalescing_count =3D count; intr_coalescing_ticks =3D ticks; -spin_unlock (&host->lock); +spin_unlock_irqrestore (&host->lock, flags);=20
drivers/ata/sata_fsl.c +0
-1DPRINTK ("intrrupt coalescing, count =3D 0x%x, ticks =3D %x\n" , intr_coalescing_count, intr_coalescing_ticks); --1.8.1.4
=20
Quoted 2 lines · Bhushan Bharat-R65777 <[email protected]> writes:
Anthony, I would prefer if you can send the patch (In case not then let me know)
Sure, I'll get it sent in a few minutes.
Would you like me to put an Acked-by on it for you?
Best regards,
Anthony Foiani
PATCH 1/1 sata: fsl: save irqs while coalescing
Before this patch, I was seeing the following lockdep splat on my MPC8315 (PPC32) target:
[ 9.086051] =================================
[ 9.090393] [ INFO: inconsistent lock state ]
[ 9.094744] 3.9.7-ajf-gc39503d #1 Not tainted
[ 9.099087] ---------------------------------
[ 9.103432] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[ 9.109431] scsi_eh_1/39 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 9.114642] (&(&host->lock)->rlock){?.+...}, at: [<c02f4168>] sata_fsl_interrupt+0x50/0x250
[ 9.123137] {HARDIRQ-ON-W} state was registered at:
[ 9.128004] [<c006cdb8>] lock_acquire+0x90/0xf4
[ 9.132737] [<c043ef04>] _raw_spin_lock+0x34/0x4c
[ 9.137645] [<c02f3560>] fsl_sata_set_irq_coalescing+0x68/0x100
[ 9.143750] [<c02f36a0>] sata_fsl_init_controller+0xa8/0xc0
[ 9.149505] [<c02f3f10>] sata_fsl_probe+0x17c/0x2e8
[ 9.154568] [<c02acc90>] driver_probe_device+0x90/0x248
[ 9.159987] [<c02acf0c>] __driver_attach+0xc4/0xc8
[ 9.164964] [<c02aae74>] bus_for_each_dev+0x5c/0xa8
[ 9.170028] [<c02ac218>] bus_add_driver+0x100/0x26c
[ 9.175091] [<c02ad638>] driver_register+0x88/0x198
[ 9.180155] [<c0003a24>] do_one_initcall+0x58/0x1b4
[ 9.185226] [<c05aeeac>] kernel_init_freeable+0x118/0x1c0
[ 9.190823] [<c0004110>] kernel_init+0x18/0x108
[ 9.195542] [<c000f6b8>] ret_from_kernel_thread+0x64/0x6c
[ 9.201142] irq event stamp: 160
[ 9.204366] hardirqs last enabled at (159): [<c043f778>] _raw_spin_unlock_irq+0x30/0x50
[ 9.212469] hardirqs last disabled at (160): [<c000f414>] reenable_mmu+0x30/0x88
[ 9.219867] softirqs last enabled at (144): [<c002ae5c>] __do_softirq+0x168/0x218
[ 9.227435] softirqs last disabled at (137): [<c002b0d4>] irq_exit+0xa8/0xb4
[ 9.234481]
[ 9.234481] other info that might help us debug this:
[ 9.240995] Possible unsafe locking scenario:
[ 9.240995]
[ 9.246898] CPU0
[ 9.249337] ----
[ 9.251776] lock(&(&host->lock)->rlock);
[ 9.255878] <Interrupt>
[ 9.258492] lock(&(&host->lock)->rlock);
[ 9.262765]
[ 9.262765] *** DEADLOCK ***
[ 9.262765]
[ 9.268684] no locks held by scsi_eh_1/39.
[ 9.272767]
[ 9.272767] stack backtrace:
[ 9.277117] Call Trace:
[ 9.279589] [cfff9da0] [c0008504] show_stack+0x48/0x150 (unreliable)
[ 9.285972] [cfff9de0] [c0447d5c] print_usage_bug.part.35+0x268/0x27c
[ 9.292425] [cfff9e10] [c006ace4] mark_lock+0x2ac/0x658
[ 9.297660] [cfff9e40] [c006b7e4] __lock_acquire+0x754/0x1840
[ 9.303414] [cfff9ee0] [c006cdb8] lock_acquire+0x90/0xf4
[ 9.308745] [cfff9f20] [c043ef04] _raw_spin_lock+0x34/0x4c
[ 9.314250] [cfff9f30] [c02f4168] sata_fsl_interrupt+0x50/0x250
[ 9.320187] [cfff9f70] [c0079ff0] handle_irq_event_percpu+0x90/0x254
[ 9.326547] [cfff9fc0] [c007a1fc] handle_irq_event+0x48/0x78
[ 9.332220] [cfff9fe0] [c007c95c] handle_level_irq+0x9c/0x104
[ 9.337981] [cfff9ff0] [c000d978] call_handle_irq+0x18/0x28
[ 9.343568] [cc7139f0] [c000608c] do_IRQ+0xf0/0x1a8
[ 9.348464] [cc713a20] [c000fc8c] ret_from_except+0x0/0x14
[ 9.353983] --- Exception: 501 at _raw_spin_unlock_irq+0x40/0x50
[ 9.353983] LR = _raw_spin_unlock_irq+0x30/0x50
[ 9.364839] [cc713af0] [c043db10] wait_for_common+0xac/0x188
[ 9.370513] [cc713b30] [c02ddee4] ata_exec_internal_sg+0x2b0/0x4f0
[ 9.376699] [cc713be0] [c02de18c] ata_exec_internal+0x68/0xa8
[ 9.382454] [cc713c20] [c02de4b8] ata_dev_read_id+0x158/0x594
[ 9.388205] [cc713ca0] [c02ec244] ata_eh_recover+0xd88/0x13d0
[ 9.393962] [cc713d20] [c02f2520] sata_pmp_error_handler+0xc0/0x8ac
[ 9.400234] [cc713dd0] [c02ecdc8] ata_scsi_port_error_handler+0x464/0x5e8
[ 9.407023] [cc713e10] [c02ecfd0] ata_scsi_error+0x84/0xb8
[ 9.412528] [cc713e40] [c02c4974] scsi_error_handler+0xd8/0x47c
[ 9.418457] [cc713eb0] [c004737c] kthread+0xa8/0xac
[ 9.423355] [cc713f40] [c000f6b8] ret_from_kernel_thread+0x64/0x6cThis fix was suggested by Bhushan Bharat <[email protected]>, and was discussed in email at:
Same patch successfully tested with 3.9.7. linux-next compiled but not tested on hardware.
This patch is based off linux-next tag next-20130819 (which is commit 66a01bae29d11916c09f9f5a937cafe7d402e4a5 )
--- drivers/ata/sata_fsl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/ata/sata_fsl.c +3 -2
@@ -293,6 +293,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, {struct sata_fsl_host_priv *host_priv = host->private_data;void __iomem *hcr_base = host_priv->hcr_base; +unsigned long flags;if (count >ICC_MAX_INT_COUNT_THRESHOLD ) count =ICC_MAX_INT_COUNT_THRESHOLD ;
@@ -305,12 +306,12 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, (count > ICC_MIN_INT_COUNT_THRESHOLD)) ticks =ICC_SAFE_INT_TICKS ; -spin_lock (&host->lock); +spin_lock_irqsave (&host->lock, flags);iowrite32 ((count <<24 | ticks), hcr_base +ICC ); intr_coalescing_count = count; intr_coalescing_ticks = ticks; -spin_unlock (&host->lock); +spin_unlock_irqrestore (&host->lock, flags);DPRINTK ("interrupt coalescing, count = 0x%x, ticks = %x\n" , intr_coalescing_count, intr_coalescing_ticks);
Signature · 1 line
1.8.1.4
Re: [PATCH] sata: fsl: save irqs while coalescing
Quoted 14 lines · Anthony Foiani
drivers/ata/sata_fsl.c +1
-0@@ -293,6 +293,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, {struct sata_fsl_host_priv *host_priv = host->private_data;void __iomem *hcr_base = host_priv->hcr_base; +unsigned long flags;if (count >ICC_MAX_INT_COUNT_THRESHOLD ) count =ICC_MAX_INT_COUNT_THRESHOLD ;@@ -305,12 +306,12 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, (count > ICC_MIN_INT_COUNT_THRESHOLD))
drivers/ata/sata_fsl.c static void fsl_sata_set_irq_coalescing(struct ata_host *host, · line 314
Quoted 10 lines
drivers/ata/sata_fsl.c +2
-2ticks =ICC_SAFE_INT_TICKS ; -spin_lock (&host->lock); +spin_lock_irqsave (&host->lock, flags);iowrite32 ((count <<24 | ticks), hcr_base +ICC ); intr_coalescing_count = count; intr_coalescing_ticks = ticks; -spin_unlock (&host->lock); +spin_unlock_irqrestore (&host->lock, flags);
This should go to the SATA list and maintainer.
-Scott
PATCH 1/1 sata: fsl: save irqs while coalescing
In reply to Anthony FoianiScott Wood indicated this should go to the SATA addresses as well as, or maybe even instead of, the PPC list.
-- 8< --
Before this patch, I was seeing the following lockdep splat on my MPC8315 (PPC32) target:
[ 9.086051] =================================
[ 9.090393] [ INFO: inconsistent lock state ]
[ 9.094744] 3.9.7-ajf-gc39503d #1 Not tainted
[ 9.099087] ---------------------------------
[ 9.103432] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[ 9.109431] scsi_eh_1/39 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 9.114642] (&(&host->lock)->rlock){?.+...}, at: [<c02f4168>] sata_fsl_interrupt+0x50/0x250
[ 9.123137] {HARDIRQ-ON-W} state was registered at:
[ 9.128004] [<c006cdb8>] lock_acquire+0x90/0xf4
[ 9.132737] [<c043ef04>] _raw_spin_lock+0x34/0x4c
[ 9.137645] [<c02f3560>] fsl_sata_set_irq_coalescing+0x68/0x100
[ 9.143750] [<c02f36a0>] sata_fsl_init_controller+0xa8/0xc0
[ 9.149505] [<c02f3f10>] sata_fsl_probe+0x17c/0x2e8
[ 9.154568] [<c02acc90>] driver_probe_device+0x90/0x248
[ 9.159987] [<c02acf0c>] __driver_attach+0xc4/0xc8
[ 9.164964] [<c02aae74>] bus_for_each_dev+0x5c/0xa8
[ 9.170028] [<c02ac218>] bus_add_driver+0x100/0x26c
[ 9.175091] [<c02ad638>] driver_register+0x88/0x198
[ 9.180155] [<c0003a24>] do_one_initcall+0x58/0x1b4
[ 9.185226] [<c05aeeac>] kernel_init_freeable+0x118/0x1c0
[ 9.190823] [<c0004110>] kernel_init+0x18/0x108
[ 9.195542] [<c000f6b8>] ret_from_kernel_thread+0x64/0x6c
[ 9.201142] irq event stamp: 160
[ 9.204366] hardirqs last enabled at (159): [<c043f778>] _raw_spin_unlock_irq+0x30/0x50
[ 9.212469] hardirqs last disabled at (160): [<c000f414>] reenable_mmu+0x30/0x88
[ 9.219867] softirqs last enabled at (144): [<c002ae5c>] __do_softirq+0x168/0x218
[ 9.227435] softirqs last disabled at (137): [<c002b0d4>] irq_exit+0xa8/0xb4
[ 9.234481]
[ 9.234481] other info that might help us debug this:
[ 9.240995] Possible unsafe locking scenario:
[ 9.240995]
[ 9.246898] CPU0
[ 9.249337] ----
[ 9.251776] lock(&(&host->lock)->rlock);
[ 9.255878] <Interrupt>
[ 9.258492] lock(&(&host->lock)->rlock);
[ 9.262765]
[ 9.262765] *** DEADLOCK ***
[ 9.262765]
[ 9.268684] no locks held by scsi_eh_1/39.
[ 9.272767]
[ 9.272767] stack backtrace:
[ 9.277117] Call Trace:
[ 9.279589] [cfff9da0] [c0008504] show_stack+0x48/0x150 (unreliable)
[ 9.285972] [cfff9de0] [c0447d5c] print_usage_bug.part.35+0x268/0x27c
[ 9.292425] [cfff9e10] [c006ace4] mark_lock+0x2ac/0x658
[ 9.297660] [cfff9e40] [c006b7e4] __lock_acquire+0x754/0x1840
[ 9.303414] [cfff9ee0] [c006cdb8] lock_acquire+0x90/0xf4
[ 9.308745] [cfff9f20] [c043ef04] _raw_spin_lock+0x34/0x4c
[ 9.314250] [cfff9f30] [c02f4168] sata_fsl_interrupt+0x50/0x250
[ 9.320187] [cfff9f70] [c0079ff0] handle_irq_event_percpu+0x90/0x254
[ 9.326547] [cfff9fc0] [c007a1fc] handle_irq_event+0x48/0x78
[ 9.332220] [cfff9fe0] [c007c95c] handle_level_irq+0x9c/0x104
[ 9.337981] [cfff9ff0] [c000d978] call_handle_irq+0x18/0x28
[ 9.343568] [cc7139f0] [c000608c] do_IRQ+0xf0/0x1a8
[ 9.348464] [cc713a20] [c000fc8c] ret_from_except+0x0/0x14
[ 9.353983] --- Exception: 501 at _raw_spin_unlock_irq+0x40/0x50
[ 9.353983] LR = _raw_spin_unlock_irq+0x30/0x50
[ 9.364839] [cc713af0] [c043db10] wait_for_common+0xac/0x188
[ 9.370513] [cc713b30] [c02ddee4] ata_exec_internal_sg+0x2b0/0x4f0
[ 9.376699] [cc713be0] [c02de18c] ata_exec_internal+0x68/0xa8
[ 9.382454] [cc713c20] [c02de4b8] ata_dev_read_id+0x158/0x594
[ 9.388205] [cc713ca0] [c02ec244] ata_eh_recover+0xd88/0x13d0
[ 9.393962] [cc713d20] [c02f2520] sata_pmp_error_handler+0xc0/0x8ac
[ 9.400234] [cc713dd0] [c02ecdc8] ata_scsi_port_error_handler+0x464/0x5e8
[ 9.407023] [cc713e10] [c02ecfd0] ata_scsi_error+0x84/0xb8
[ 9.412528] [cc713e40] [c02c4974] scsi_error_handler+0xd8/0x47c
[ 9.418457] [cc713eb0] [c004737c] kthread+0xa8/0xac
[ 9.423355] [cc713f40] [c000f6b8] ret_from_kernel_thread+0x64/0x6cThis fix was suggested by Bhushan Bharat <[email protected]>, and was discussed in email at:
Same patch successfully tested with 3.9.7. linux-next compiled but not tested on hardware.
This patch is based off linux-next tag next-20130819 (which is commit 66a01bae29d11916c09f9f5a937cafe7d402e4a5 )
--- drivers/ata/sata_fsl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/ata/sata_fsl.c +3 -2
@@ -293,6 +293,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, {struct sata_fsl_host_priv *host_priv = host->private_data;void __iomem *hcr_base = host_priv->hcr_base; +unsigned long flags;if (count >ICC_MAX_INT_COUNT_THRESHOLD ) count =ICC_MAX_INT_COUNT_THRESHOLD ;
@@ -305,12 +306,12 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, (count > ICC_MIN_INT_COUNT_THRESHOLD)) ticks =ICC_SAFE_INT_TICKS ; -spin_lock (&host->lock); +spin_lock_irqsave (&host->lock, flags);iowrite32 ((count <<24 | ticks), hcr_base +ICC ); intr_coalescing_count = count; intr_coalescing_ticks = ticks; -spin_unlock (&host->lock); +spin_unlock_irqrestore (&host->lock, flags);DPRINTK ("interrupt coalescing, count = 0x%x, ticks = %x\n" , intr_coalescing_count, intr_coalescing_ticks);
Signature · 1 line
1.8.1.4
Tejun Heo
AppliedRe: [PATCH] sata: fsl: save irqs while coalescing
Quoted 4 lines · Anthony Foiani
This patch is based off linux-next tag next-20130819 (which is commit
66a01bae29d11916c09f9f5a937cafe7d402e4a5)Signed-off-by Anthony Foiani <[email protected]>
Applied to libata/for-3.11-fixes w/ stable cc'd.
Thanks.
Signature · 1 line
tejun