xfs: a chunk of comment fixes
cover xfs: a chunk of comment fixes
From: Zhi Yong Wu <[email protected]>
Submit a chunk of xfs commnt fixes.
Zhi Yong Wu (12):
xfs: fix the comment of xfs_check_sizes()
xfs: fix the comment of xfs_buf_free()
xfs: fix the comment of xfs_btree_lookup()
xfs: fix the comment of xfs_mod_incore_sb_unlocked()
xfs: fix the comment of xlog_write_setup_copy()
xfs: remove one blank line in xfs_btree_make_block_unfull()
xfs: fix the comment of xfs_iroot_realloc()
xfs: fix the comment of xfs_btree_get_iroot()
xfs: remove two unused macro definitions in xfs_linux.h
xfs: fix the comment of xlog_recover_buffer_pass2()
xfs: fix the comment of xlog_find_head()
xfs: rename bio_add_buffer() to xfs_bio_add_buffer()
fs/xfs/xfs_aops.c | 4 ++-- fs/xfs/xfs_btree.c | 5 ++--- fs/xfs/xfs_buf.c | 2 +- fs/xfs/xfs_inode.c | 2 +- fs/xfs/xfs_linux.h | 2 -- fs/xfs/xfs_log.c | 2 +- fs/xfs/xfs_log_recover.c | 4 ++-- fs/xfs/xfs_mount.c | 4 ++-- 8 files changed, 11 insertions(+), 14 deletions(-)
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 1/12 xfs: fix the comment of xfs_check_sizes()
From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_mount.c +1 -1
@@ -1194,7 +1194,7 @@ xfs_set_inoalignment(xfs_mount_t *mp) }/* -* Check that the data (and log if separate) are an ok size. +* Check that the data (and log if separate) is an ok size. */ STATIC intxfs_check_sizes (xfs_mount_t *mp)
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 2/12 xfs: fix the comment of xfs_buf_free()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_buf.c +1 -1
@@ -303,7 +303,7 @@ _xfs_buf_free_pages(* Releases the specified buffer. * * The modification state of any associated pages is left unchanged. -* The buffer most not be on any hash - use xfs_buf_rele instead for +* The buffer must not be on any hash - use xfs_buf_rele instead for * hashed and refcounted buffers */ void
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 3/12 xfs: fix the comment of xfs_btree_lookup()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_btree.c +1 -1
@@ -1684,7 +1684,7 @@ xfs_lookup_get_search_key(/* * Lookup the record. The cursor is made to point to it, based on dir. -* Return 0 if can't find any such record, 1 for success. +* stat is set to 0 if can't find any such record, 1 for success. */ int /* error */ xfs_btree_lookup(
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 4/12 xfs: fix the comment of xfs_mod_incore_sb_unlocked()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_mount.c +1 -1
@@ -1794,7 +1794,7 @@ xfs_mod_sb(xfs_trans_t *tp, __int64_t fields)/* -* xfs_mod_incore_sb_unlocked() is a utility routine common used to apply +* xfs_mod_incore_sb_unlocked() is a utility routine commonly used to apply * a delta to a specified field in the in-core superblock. Simply * switch on the field indicated and apply the delta to that field. * Fields are not allowed to dip below zero, so if the delta would
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 5/12 xfs: fix the comment of xlog_write_setup_copy()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_log.c +1 -1
@@ -2044,7 +2044,7 @@ xlog_write_setup_ophdr(* Set up the parameters of the region copy into the log. This has * to handle region write split across multiple log buffers - this * state is kept external to this function so that this code can -* can be written in an obvious, self documenting manner. +* be written in an obvious, self documenting manner. */ static int xlog_write_setup_copy(
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 6/12 xfs: remove one blank line in xfs_btree_make_block_unfull()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_btree.c | 1 - 1 file changed, 1 deletion(-)
fs/xfs/xfs_btree.c +0 -1
@@ -2756,7 +2756,6 @@ xfs_btree_make_block_unfull(if (numrecs < cur->bc_ops->get_dmaxrecs (cur, level)) {/* A root block that can be made bigger. */ -xfs_iroot_realloc (ip,1 , cur->bc_private.b.whichfork); }else {/* A root block that needs replacing */
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 7/12 xfs: fix the comment of xfs_iroot_realloc()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_inode.c +1 -1
@@ -2103,7 +2103,7 @@ xfs_ifree(* * The caller must not request to add more records than would fit in * the on-disk inode root. If the if_broot is currently NULL, then -* if we adding records one will be allocated. The caller must also +* if we are adding records, one will be allocated. The caller must also * not request that the number of records go below zero, although * it can go to zero. *
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()
Quoted 12 lines · On 08/07/13 05:11, [email protected] wrote:
From: Zhi Yong Wu<[email protected]>
Signed-off-by Zhi Yong Wu<[email protected]>--- fs/xfs/xfs_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_inode.c +0
-0
fs/xfs/xfs_inode.c xfs_ifree( · line 2109
Quoted 8 lines
fs/xfs/xfs_inode.c +1
-1@@ -2103,7 +2103,7 @@ xfs_ifree(* * The caller must not request to add more records than would fit in * the on-disk inode root. If the if_broot is currently NULL, then -* if we adding records one will be allocated. The caller must also +* if we are adding records, one will be allocated. The caller must also * not request that the number of records go below zero, although * it can go to zero. *
Change this to xfs_inode_fork.c and the series will apply on top of Dave's "current patch queue for Linux 3.12":
http://oss.sgi.com/archives/xfs/2013-07/msg00411.html
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()
Quoted 19 lines · Mark Tinguely
Quoted 18 lines · On 08/07/13 05:11, [email protected] wrote:
From: Zhi Yong Wu<[email protected]>
Signed-off-by Zhi Yong Wu<[email protected]>--- fs/xfs/xfs_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_inode.c +1
-1@@ -2103,7 +2103,7 @@ xfs_ifree(* * The caller must not request to add more records than would fit in * the on-disk inode root. If the if_broot is currently NULL, then -* if we adding records one will be allocated. The caller must also +* if we are adding records, one will be allocated. The caller must also
Quoted 8 lines
fs/xfs/xfs_inode.c xfs_ifree( · line 2109
Quoted 3 lines
fs/xfs/xfs_inode.c +0
-0* not request that the number of records go below zero, although * it can go to zero. * Change this to
xfs_inode_fork.cand the series will apply on top of Dave's "current patch queue for Linux 3.12":
Do you mean that you have done this or i need to do this? If i need to do this, can you let me know where i can get xfs git repo which has applied Dave's patchset?
Quoted 2 lines
Signature · 8 lines
Regards, Zhi Yong Wu _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()
Quoted 28 lines · Zhi Yong Wu
Quoted 19 lines · Mark Tinguely
Quoted 18 lines · On 08/07/13 05:11, [email protected] wrote:
From: Zhi Yong Wu<[email protected]>
Signed-off-by Zhi Yong Wu<[email protected]>--- fs/xfs/xfs_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_inode.c +1
-1@@ -2103,7 +2103,7 @@ xfs_ifree(* * The caller must not request to add more records than would fit in * the on-disk inode root. If the if_broot is currently NULL, then -* if we adding records one will be allocated. The caller must also +* if we are adding records, one will be allocated. The caller must also Quoted 8 lines
fs/xfs/xfs_inode.c xfs_ifree( · line 2109
Quoted 3 lines
fs/xfs/xfs_inode.c +0
-0* not request that the number of records go below zero, although * it can go to zero. * Change this to
xfs_inode_fork.cand the series will apply on top of Dave's "current patch queue for Linux 3.12":
Quoted 6 lines
Do you mean that you have done this or i need to do this? If i need to do this, can you let me know where i can get xfs git repo which has applied Dave's patchset?
Quoted 2 lines
http://oss.sgi.com/archives/xfs/2013-07/msg00411.html
If approved, we can make the change on commit.
The patches look okay to me.
--Mark.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()
Quoted 42 lines · Mark Tinguely
Quoted 41 lines · Zhi Yong Wu
Quoted 24 lines · Mark Tinguely
Quoted 22 lines · On 08/07/13 05:11, [email protected] wrote:
From: Zhi Yong Wu<[email protected]>
Signed-off-by Zhi Yong Wu<[email protected]>--- fs/xfs/xfs_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_inode.c +1
-1@@ -2103,7 +2103,7 @@ xfs_ifree(* * The caller must not request to add more records than would fit in * the on-disk inode root. If the if_broot is currently NULL, then -* if we adding records one will be allocated. The caller must also +* if we are adding records, one will be allocated. The caller must also
* not request that the number of records go below zero, although
* it can go to zero.Quoted 8 lines
Quoted 1 line
*Change this to
xfs_inode_fork.cand the series will apply on top of Dave's
"current patch queue for Linux 3.12":Do you mean that you have done this or i need to do this? If i need to do this,
can you let me know where i can get xfs git repo which has applied Dave's patchset?Quoted 1 line
Quoted 5 lines
Quoted 1 line
Quoted 1 line
http://oss.sgi.com/archives/xfs/2013-07/msg00411.htmlIf approved, we can make the change on commit.
Please feel free to do it, thanks a lot.
Quoted 5 lines
The patches look okay to me.
--Mark.
Signature · 8 lines
Regards, Zhi Yong Wu _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 8/12 xfs: fix the comment of xfs_btree_get_iroot()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_btree.c +1 -1
@@ -510,7 +510,7 @@ xfs_btree_ptr_addr( }/* -* Get a the root block which is stored in the inode. +* Get the root block which is stored in the inode. * * For now this btree implementation assumes the btree root is always * stored in the if_broot field of an inode fork.
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 9/12 xfs: remove two unused macro definitions in xfs_linux.h
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_linux.h | 2 -- 1 file changed, 2 deletions(-)
fs/xfs/xfs_linux.h +0 -2
@@ -114,8 +114,6 @@#define xfs_inherit_sync xfs_params.inherit_sync.val#define xfs_inherit_nodump xfs_params.inherit_nodump.val#define xfs_inherit_noatime xfs_params.inherit_noatim.val -#define xfs_buf_timer_centisecs xfs_params.xfs_buf_timer.val -#define xfs_buf_age_centisecs xfs_params.xfs_buf_age.val#define xfs_inherit_nosymlinks xfs_params.inherit_nosym.val#define xfs_rotorstep xfs_params.rotorstep.val#define xfs_inherit_nodefrag xfs_params.inherit_nodfrg.val
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 10/12 xfs: fix the comment of xlog_recover_buffer_pass2()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_log_recover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_log_recover.c +1 -1
@@ -2425,7 +2425,7 @@ xlog_recover_do_dquot_buffer(* over the log during recovery. During the first we build a table of * those buffers which have been cancelled, and during the second we * only replay those buffers which do not have corresponding cancel -* records in the table. See xlog_recover_do_buffer_pass[1,2] above +* records in the table. See xlog_recover_buffer_pass[1,2] above * for more details on the implementation of the table of cancel records. */ STATIC int
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 11/12 xfs: fix the comment of xlog_find_head()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_log_recover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_log_recover.c +1 -1
@@ -607,7 +607,7 @@ out:/* * Head is defined to be the point of the log where the next log write -* write could go. This means that incomplete LR writes at the end are +* could go. This means that incomplete LR writes at the end are * eliminated when calculating the head. We aren't guaranteed that previous * LR have complete transactions. We only know that a cycle number of * current cycle number -1 won't be present in the log if we start writing
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 12/12 xfs: rename bio_add_buffer() to xfs_bio_add_buffer()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
Follow up with xfs naming style.
--- fs/xfs/xfs_aops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/xfs/xfs_aops.c +2 -2
@@ -451,7 +451,7 @@ xfs_start_page_writeback(end_page_writeback (page); } -static inline int bio_add_buffer (struct bio *bio,struct buffer_head *bh) +static inline int xfs_bio_add_buffer (struct bio *bio,struct buffer_head *bh) {return bio_add_page (bio, bh->b_page, bh->b_size,bh_offset (bh)); }
@@ -525,7 +525,7 @@ xfs_submit_ioend( goto retry; } -if (bio_add_buffer (bio, bh) != bh->b_size) { +if (xfs_bio_add_buffer (bio, bh) != bh->b_size) {xfs_submit_ioend_bio (wbc, ioend, bio); goto retry; }
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Ben Myers
AppliedQuoted 3 lines · On Wed, Aug 07, 2013 at 06:10:57PM +0800, [email protected] wrote:
From: Zhi Yong Wu <[email protected]>
Submit a chunk of xfs commnt fixes.
Applied this series. Thanks.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs