Skip to contentSkip to conversation

ARM: OMAP: dma: fix error return code in omap_system_dma_probe()

PATCH New Wei Yongjun 2 participants 2 messages Jul 16, 2013 – Aug 21, 2013

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

PATCH 1/1 ARM: OMAP: dma: fix error return code in omap_system_dma_probe()

From: Wei Yongjun <[email protected]>

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.

Signed-off-by Wei Yongjun <[email protected]>
---
 arch/arm/plat-omap/dma.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/dma.c +1 -0
index 4d463ca..0376606 100644
@@ -2083,6 +2083,7 @@ static int omap_system_dma_probe(struct platform_device *pdev)
 		dma_irq = platform_get_irq_byname(pdev, irq_name);
 		if (dma_irq < 0) {
 			dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq);
+			ret = dma_irq;
 			goto exit_dma_lch_fail;
 		}
 		ret = setup_irq(dma_irq, &omap24xx_dma_irq);
#1 lore raw

PATCH 1/1 ARM: OMAP: dma: fix error return code in omap_system_dma_probe()

Quoted 4 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.

Thanks applying into omap-for-v3.12/fixes-non-critical.

Tony

Quoted 22 lines
Signed-off-by Wei Yongjun <[email protected]>
---
 arch/arm/plat-omap/dma.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/dma.c +1 -1
index 4d463ca..0376606 100644
@@ -2083,6 +2083,7 @@ static int omap_system_dma_probe(struct platform_device *pdev)
 		dma_irq = platform_get_irq_byname(pdev, irq_name);
 		if (dma_irq < 0) {
 			dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq);
+			ret = dma_irq;
 			goto exit_dma_lch_fail;
 		}
 		ret = setup_irq(dma_irq, &omap24xx_dma_irq);
 
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html