Skip to contentSkip to conversation

ARM: at91: at91sam9260: add missing pinctrl on mmc

PATCH Superseded ludovic.desroches at atmel.com 2 participants 4 messages Aug 21, 2013

Subsystems (2)
Device tree bindings Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

ludovic.desroches at atmel.com

author
#0 lore raw

PATCH v2 1/1 ARM: at91: at91sam9260: add missing pinctrl on mmc

From: Ludovic Desroches <[email protected]>

pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover, add minimal pin configuration to not cause error if overloading is forgotten in board files.

Signed-off-by Ludovic Desroches <[email protected]>
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

---

v2:
- add minimal pin configuration

 arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +2 -0
index 84c4bef..b4de52a 100644
@@ -477,6 +477,8 @@
 				interrupts = <9 4 0>;
 				#address-cells = <1>;
 				#size-cells = <0>;
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
 				status = "disabled";
 			};
Signature · 1 line
1.7.11.3
#1 lore raw

PATCH v2 1/1 ARM: at91: at91sam9260: add missing pinctrl on mmc

On 21/08/2013 09:42, ludovic.desroches at atmel.com :

Quoted 8 lines

From: Ludovic Desroches <[email protected]>

pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover, add minimal pin configuration to not cause error if overloading is forgotten in board files.

Signed-off-by Ludovic Desroches <[email protected]>
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

(modified the "interrupts" property to add the macro definition).

Acked-by Nicolas Ferre <[email protected]>

stacked in at91-3.12-dt.

Due to macro change, I can't tag it for -stable. We have to remember to add it when it is accepted upstream.

thanks.

Quoted 22 lines

---

v2:
- add minimal pin configuration

  arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +2 -0
index 84c4bef..b4de52a 100644
@@ -477,6 +477,8 @@
  				interrupts = <9 4 0>;
  				#address-cells = <1>;
  				#size-cells = <0>;
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
  				status = "disabled";
  			};
Signature · 1 line
Nicolas Ferre
author
#2 lore raw

PATCH v2 1/1 ARM: at91: at91sam9260: add missing pinctrl on mmc

Quoted 7 lines · Nicolas Ferre

On 21/08/2013 09:42, ludovic.desroches at atmel.com :

Quoted 6 lines

From: Ludovic Desroches <[email protected]>

pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover, add minimal pin configuration to not cause error if overloading is forgotten in board files.

Quoted 6 lines
Quoted 2 lines
Signed-off-by Ludovic Desroches <[email protected]>
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

(modified the "interrupts" property to add the macro definition).

Acked-by Nicolas Ferre <[email protected]>

After discussing with Jean-Christophe keeping the first version of the patch seems a better choice because the user will be notified if he forgets to overload pin configuration instead of thinking that everything goes right and having a default pin configuration that could not fit its configuration.

Quoted 34 lines

stacked in at91-3.12-dt.

Due to macro change, I can't tag it for -stable. We have to remember to add it when it is accepted upstream.

thanks.

Quoted 22 lines

---

v2:
- add minimal pin configuration

 arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +2 -0
index 84c4bef..b4de52a 100644
@@ -477,6 +477,8 @@
 				interrupts = <9 4 0>;
 				#address-cells = <1>;
 				#size-cells = <0>;
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
 				status = "disabled";
 			};
Signature · 1 line
Nicolas Ferre
#3 lore raw

PATCH v2 1/1 ARM: at91: at91sam9260: add missing pinctrl on mmc

On 21/08/2013 10:56, Ludovic Desroches :

Quoted 11 lines · Nicolas Ferre
Quoted 10 lines

On 21/08/2013 09:42, ludovic.desroches at atmel.com :

Quoted 8 lines

From: Ludovic Desroches <[email protected]>

pinctrl-names was missing causing mmc pinctrl to never be requested. Moreover, add minimal pin configuration to not cause error if overloading is forgotten in board files.

Signed-off-by Ludovic Desroches <[email protected]>
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Quoted 8 lines
Quoted 3 lines

(modified the "interrupts" property to add the macro definition).

Acked-by Nicolas Ferre <[email protected]>

After discussing with Jean-Christophe keeping the first version of the patch seems a better choice because the user will be notified if he forgets to overload pin configuration instead of thinking that everything goes right and having a default pin configuration that could not fit its configuration.

Ah, okay: that makes sense.

Quoted 1 line
Quoted 1 line

stacked in at91-3.12-dt.

So I replace the patch.

Thanks,

Quoted 34 lines
Quoted 32 lines

Due to macro change, I can't tag it for -stable. We have to remember to add it when it is accepted upstream.

thanks.

Quoted 14 lines

---

v2:
- add minimal pin configuration

  arch/arm/boot/dts/at91sam9260.dtsi | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +0 -0
index 84c4bef..b4de52a 100644

arch/arm/boot/dts/at91sam9260.dtsi line 484

Quoted 8 lines
arch/arm/boot/dts/at91sam9260.dtsi +2 -0
@@ -477,6 +477,8 @@
  				interrupts = <9 4 0>;
  				#address-cells = <1>;
  				#size-cells = <0>;
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_mmc0_clk &pinctrl_mmc0_slot1_cmd_dat0>;
  				status = "disabled";
  			};

--
Nicolas Ferre

Signature · 1 line
Nicolas Ferre