Skip to contentSkip to conversation

sh_vou: almost forever loop in sh_vou_try_fmt_vid_out()

PATCH In review Dan Carpenter 2 participants 2 messages Aug 23, 2013 – Aug 26, 2013

Subsystems (2)
Media (V4L/DVB) Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sh_vou: almost forever loop in sh_vou_try_fmt_vid_out()

The "i < " part of the "i < ARRAY_SIZE()" condition was missing.

Signed-off-by Dan Carpenter <[email protected]>
drivers/media/platform/sh_vou.c +2 -1
index 7a9c5e9..41f612c 100644
@@ -776,9 +776,10 @@ static int sh_vou_try_fmt_vid_out(struct file *file, void *priv,
 	v4l_bound_align_image(&pix->width, 0, VOU_MAX_IMAGE_WIDTH, 1,
 			      &pix->height, 0, VOU_MAX_IMAGE_HEIGHT, 1, 0);
 
-	for (i = 0; ARRAY_SIZE(vou_fmt); i++)
+	for (i = 0; i < ARRAY_SIZE(vou_fmt); i++) {
 		if (vou_fmt[i].pfmt = pix->pixelformat)
 			return 0;
+	}
 
 	pix->pixelformat = vou_fmt[0].pfmt;
Reviewed-by Lad, Prabhakar on v1 1/1
#1 lore raw
Quoted 3 lines · Dan Carpenter

The "i < " part of the "i < ARRAY_SIZE()" condition was missing.

Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Lad, Prabhakar <[email protected]>

Regards,
--Prabhakar Lad

Quoted 17 lines
drivers/media/platform/sh_vou.c +2 -1
index 7a9c5e9..41f612c 100644
@@ -776,9 +776,10 @@ static int sh_vou_try_fmt_vid_out(struct file *file, void *priv,
        v4l_bound_align_image(&pix->width, 0, VOU_MAX_IMAGE_WIDTH, 1,
                              &pix->height, 0, VOU_MAX_IMAGE_HEIGHT, 1, 0);
 
-       for (i = 0; ARRAY_SIZE(vou_fmt); i++)
+       for (i = 0; i < ARRAY_SIZE(vou_fmt); i++) {
                if (vou_fmt[i].pfmt == pix->pixelformat)
                        return 0;
+       }
 
        pix->pixelformat = vou_fmt[0].pfmt;